Deprecate client alias registration on HttpClient interface

ruudk · ruudk · commit 85f511d6d667 · 2021-07-12T10:52:11.000+02:00
diff --git a/src/DependencyInjection/HttplugExtension.php b/src/DependencyInjection/HttplugExtension.php
@@ -383,8 +383,10 @@ private function configureClient(ContainerBuilder $container, $clientName, array
         $serviceId = 'httplug.client.'.$clientName;
 
         if (method_exists($container, 'registerAliasForArgument')) {
-            $container->registerAliasForArgument($serviceId, HttpClient::class, $clientName);
+            $alias = $container->registerAliasForArgument($serviceId, HttpClient::class, $clientName);
             if (interface_exists(ClientInterface::class)) {
+                $alias->setDeprecated('php-http/httplug-bundle', '1.22', 'The "%alias_id%" alias is deprecated, use "Psr\Http\Client\ClientInterface" instead.');
+
                 $container->registerAliasForArgument($serviceId, ClientInterface::class, $clientName);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -383,8 +383,10 @@ private function configureClient(ContainerBuilder $container, $clientName, array`
`383`	`383`	`$serviceId = 'httplug.client.'.$clientName;`
`384`	`384`
`385`	`385`	`if (method_exists($container, 'registerAliasForArgument')) {`
`386`		`- $container->registerAliasForArgument($serviceId, HttpClient::class, $clientName);`
	`386`	`+ $alias = $container->registerAliasForArgument($serviceId, HttpClient::class, $clientName);`
`387`	`387`	`if (interface_exists(ClientInterface::class)) {`
	`388`	`+ $alias->setDeprecated('php-http/httplug-bundle', '1.22', 'The "%alias_id%" alias is deprecated, use "Psr\Http\Client\ClientInterface" instead.');`
	`389`	`+`
`388`	`390`	`$container->registerAliasForArgument($serviceId, ClientInterface::class, $clientName);`
`389`	`391`	`}`
`390`	`392`	`}`