React: migrate client factory to use PSR-17

Author: glaubinix

composer.json

@@ -45,7 +45,8 @@
         "php-http/guzzle6-adapter": "<1.1",
         "php-http/curl-client": "<2.0",
         "php-http/socket-client": "<2.0",
-        "kriswallsmith/buzz": "<0.17"
+        "kriswallsmith/buzz": "<0.17",
+        "php-http/react-adapter": "<3.0"
     },
     "require-dev": {
         "guzzlehttp/psr7": "^1.7 || ^2.0",

src/ClientFactory/ReactFactory.php

@@ -5,23 +5,12 @@
 namespace Http\HttplugBundle\ClientFactory;
 
 use Http\Adapter\React\Client;
-use Http\Message\MessageFactory;
 
 /**
  * @author Tobias Nyholm <tobias.nyholm@gmail.com>
  */
 class ReactFactory implements ClientFactory
 {
-    /**
-     * @var MessageFactory
-     */
-    private $messageFactory;
-
-    public function __construct(MessageFactory $messageFactory)
-    {
-        $this->messageFactory = $messageFactory;
-    }
-
     /**
      * {@inheritdoc}
      */
@@ -31,6 +20,6 @@ public function createClient(array $config = [])
             throw new \LogicException('To use the React adapter you need to install the "php-http/react-adapter" package.');
         }
 
-        return new Client($this->messageFactory);
+        return new Client();
     }
 }

src/Resources/config/services.xml

@@ -91,9 +91,7 @@
         </service>
         <service id="httplug.factory.guzzle6" class="Http\HttplugBundle\ClientFactory\Guzzle6Factory" public="false" />
         <service id="httplug.factory.guzzle7" class="Http\HttplugBundle\ClientFactory\Guzzle7Factory" public="false" />
-        <service id="httplug.factory.react" class="Http\HttplugBundle\ClientFactory\ReactFactory" public="false">
-            <argument type="service" id="httplug.message_factory"/>
-        </service>
+        <service id="httplug.factory.react" class="Http\HttplugBundle\ClientFactory\ReactFactory" public="false" />
         <service id="httplug.factory.socket" class="Http\HttplugBundle\ClientFactory\SocketFactory" public="false">
             <argument type="service" id="httplug.message_factory"/>
         </service>

tests/Unit/ClientFactory/ReactFactoryTest.php

@@ -20,7 +20,7 @@ public function testCreateClient(): void
             $this->markTestSkipped('React adapter is not installed');
         }
 
-        $factory = new ReactFactory($this->getMockBuilder(MessageFactory::class)->getMock());
+        $factory = new ReactFactory();
         $client = $factory->createClient();
 
         $this->assertInstanceOf(Client::class, $client);