Added exception

Author: Nyholm

ClientFactory/ClientFactoryInterface.php

@@ -3,6 +3,7 @@
 namespace Http\HttplugBundle\ClientFactory;
 
 use Http\Client\HttpClient;
+use Http\HttplugBundle\Exception\ClientWasNotCreated;
 
 /**
  * Interface ClientFactoryInterface.
@@ -15,8 +16,10 @@ interface ClientFactoryInterface
      * @param array $config
      *
      * @return HttpClient
+     *
+     * @throws ClientWasNotCreated
      */
-    public function configure(array $config = array());
+    public function createClient(array $config = array());
 
     /**
      * Return the name of the client.

ClientFactory/DummyFactory.php

@@ -3,6 +3,7 @@
 namespace Http\HttplugBundle\ClientFactory;
 
 use Http\Client\HttpClient;
+use Http\HttplugBundle\Exception\ClientWasNotCreated;
 
 /**
  * This class is used with the dependency injection when we register the service. It acts like a place holder and
@@ -13,21 +14,15 @@
 class DummyFactory implements ClientFactoryInterface
 {
     /**
-     * Configure and return a client.
-     *
-     * @param array $config
-     *
-     * @return HttpClient
+     * {@inheritdoc}
      */
-    public function configure(array $config = array())
+    public function createClient(array $config = array())
     {
-        return;
+        throw new ClientWasNotCreated('The DummyFactory should not be used.');
     }
 
     /**
-     * Return the name of the client.
-     *
-     * @return string
+     * {@inheritdoc}
      */
     public function getName()
     {

ClientFactory/GenericClientFactory.php

@@ -17,18 +17,18 @@ class GenericClientFactory
     private $clientFactories;
 
     /**
-     * @param string $adapter
+     * @param string $name
      * @param array  $config
      *
      * @return HttpClient
      */
-    public function getClient($adapter, array $config = [])
+    public function getClient($name, array $config = [])
     {
-        if (!isset($this->clientFactories[$adapter])) {
-            throw new \InvalidArgumentException(sprintf('No configurator named %s was found.', $adapter));
+        if (!isset($this->clientFactories[$name])) {
+            throw new \InvalidArgumentException(sprintf('No configurator named %s was found.', $name));
         }
 
-        return $this->clientFactories[$adapter]->configure($config);
+        return $this->clientFactories[$name]->createClient($config);
     }
 
     /**

ClientFactory/Guzzle5Factory.php

@@ -13,7 +13,7 @@ class Guzzle5Factory implements ClientFactoryInterface
     /**
      * {@inheritdoc}
      */
-    public function configure(array $config = array())
+    public function createClient(array $config = array())
     {
         $client = new Client($config);
 

ClientFactory/Guzzle6Factory.php

@@ -10,7 +10,7 @@
  */
 class Guzzle6Factory implements ClientFactoryInterface
 {
-    public function configure(array $config = array())
+    public function createClient(array $config = array())
     {
         $client = new Client($config);
 

Exception/ClientWasNotCreated.php

@@ -0,0 +1,7 @@
+<?php
+
+namespace Http\HttplugBundle\Exception;
+
+class ClientWasNotCreated extends \Exception
+{
+}