don't make clients explicitly public

Author: fbourigault

DependencyInjection/HttplugExtension.php

@@ -14,7 +14,6 @@
 use Http\Message\Authentication\Wsse;
 use Psr\Http\Message\UriInterface;
 use Symfony\Component\Config\FileLocator;
-use Symfony\Component\DependencyInjection\Alias;
 use Symfony\Component\DependencyInjection\ChildDefinition;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Definition;
@@ -51,7 +50,7 @@ public function load(array $configs, ContainerBuilder $container)
 
         // Set main aliases
         foreach ($config['main_alias'] as $type => $id) {
-            $container->setAlias(sprintf('httplug.%s', $type), new Alias($id, true));
+            $container->setAlias(sprintf('httplug.%s', $type), $id);
         }
 
         // Configure toolbar
@@ -104,7 +103,7 @@ private function configureClients(ContainerBuilder $container, array $config)
             // If we do not have a client named 'default'
             if (!isset($config['clients']['default'])) {
                 // Alias the first client to httplug.client.default
-                $container->setAlias('httplug.client.default', new Alias('httplug.client.'.$first, true));
+                $container->setAlias('httplug.client.default', 'httplug.client.'.$first);
             }
         }
     }
@@ -298,7 +297,6 @@ private function configureClient(ContainerBuilder $container, $clientName, array
 
         $container
             ->register($serviceId, PluginClient::class)
-            ->setPublic(true)
             ->setFactory([new Reference(PluginClientFactory::class), 'createClient'])
             ->addArgument(new Reference($serviceId.'.client'))
             ->addArgument(

Tests/Resources/app/AppKernel.php

@@ -108,11 +108,22 @@ public function process(ContainerBuilder $container)
             'httplug.async_client.default',
             'httplug.client.default',
             'app.http.plugin.custom',
+            'httplug.client.acme',
         ];
         foreach ($services as $service) {
             if ($container->hasDefinition($service)) {
                 $container->getDefinition($service)->setPublic(true);
             }
+
+        }
+
+        $aliases = [
+            'httplug.client',
+        ];
+        foreach ($aliases as $alias) {
+            if ($container->hasAlias($alias)) {
+                $container->getAlias($alias)->setPublic(true);
+            }
         }
     }
 }