add tests for rediss connection

Author: jeff1985

RedisConnectionFactory.php

@@ -50,13 +50,18 @@ public function __construct($config = 'redis:')
         }
 
         $this->config = array_replace($this->defaultConfig(), $config);
+        if (isset($this->config['vendor'])) {
+            $vendor = $this->config['vendor'];
+        } else {
+            $vendor = "";
+        }
 
         $supportedVendors = ['predis', 'phpredis', 'custom'];
-        if (false == in_array($this->config['vendor'], $supportedVendors, true)) {
+        if (false == in_array($vendor, $supportedVendors, true)) {
             throw new \LogicException(sprintf(
                 'Unsupported redis vendor given. It must be either "%s". Got "%s"',
                 implode('", "', $supportedVendors),
-                $this->config['vendor']
+                $vendor
             ));
         }
     }
@@ -133,8 +138,15 @@ private function parseDsn($dsn)
             $config = array_replace($queryConfig, $config);
         }
 
+        if (isset($config['vendor'])) {
+            $vendor = $config['vendor'];
+        } else {
+            $vendor = "";
+        }
+
+
         //predis additionaly supports tls as scheme, but it must remain in the $config array
-        if ($config['vendor']!='predis') {
+        if ($vendor!='predis') {
             if ($config['scheme']!='redis') throw new \LogicException(sprintf($unsupportedError, $dsn));
             unset($config['scheme']);
         }

Tests/RedisConnectionFactoryConfigTest.php

@@ -125,6 +125,46 @@ public static function provideConfigs()
             ],
         ];
 
+        //check normal redis connection for predis library
+        yield [
+            'redis://localhost:1234?foo=bar&lazy=0&vendor=predis',
+            [
+                'host' => 'localhost',
+                'port' => 1234,
+                'timeout' => null,
+                'reserved' => null,
+                'retry_interval' => null,
+                'vendor' => 'predis',
+                'persisted' => false,
+                'lazy' => false,
+                'foo' => 'bar',
+                'database' => 0,
+                'scheme' => 'redis',
+                'redis' => null,
+            ],
+        ];
+
+        //check tls connection for predis library
+        yield [
+            'rediss://localhost:1234?foo=bar&lazy=0&vendor=predis',
+            [
+                'host' => 'localhost',
+                'port' => 1234,
+                'timeout' => null,
+                'reserved' => null,
+                'retry_interval' => null,
+                'vendor' => 'predis',
+                'persisted' => false,
+                'lazy' => false,
+                'foo' => 'bar',
+                'database' => 0,
+                'scheme' => 'rediss',
+                'redis' => null,
+            ],
+        ];
+
+
+
         yield [
             ['host' => 'localhost', 'port' => 1234, 'foo' => 'bar'],
             [