From 21c62d2bfffc7394278b64345213688fa761f1bd Mon Sep 17 00:00:00 2001 From: Alan Poulain Date: Mon, 14 Jan 2019 15:46:25 +0100 Subject: [PATCH] Requeuing a message should not acknowledge it beforehand --- pkg/pheanstalk/PheanstalkConsumer.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/pheanstalk/PheanstalkConsumer.php b/pkg/pheanstalk/PheanstalkConsumer.php index 337b77d9d..bfd9fb3b0 100644 --- a/pkg/pheanstalk/PheanstalkConsumer.php +++ b/pkg/pheanstalk/PheanstalkConsumer.php @@ -88,11 +88,13 @@ public function acknowledge(Message $message): void */ public function reject(Message $message, bool $requeue = false): void { - $this->acknowledge($message); - if ($requeue) { $this->pheanstalk->release($message->getJob(), $message->getPriority(), $message->getDelay()); + + return; } + + $this->acknowledge($message); } private function convertJobToMessage(Job $job): PheanstalkMessage