Skip to content

Commit 9b8ba08

Browse files
committed
replace amqp-lib deprecated public property with getters
1 parent b7b283b commit 9b8ba08

5 files changed

+9
-14
lines changed

pkg/amqp-lib/AmqpContext.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -309,9 +309,9 @@ public function convertMessage(LibAMQPMessage $amqpMessage): InteropAmqpMessage
309309
unset($headers['application_headers']);
310310

311311
$message = new AmqpMessage($amqpMessage->getBody(), $properties, $headers);
312-
$message->setDeliveryTag((int) $amqpMessage->delivery_info['delivery_tag']);
313-
$message->setRedelivered($amqpMessage->delivery_info['redelivered']);
314-
$message->setRoutingKey($amqpMessage->delivery_info['routing_key']);
312+
$message->setDeliveryTag((int) $amqpMessage->getDeliveryTag());
313+
$message->setRedelivered($amqpMessage->isRedelivered());
314+
$message->setRoutingKey($amqpMessage->getRoutingKey());
315315

316316
return $message;
317317
}

pkg/amqp-lib/AmqpSubscriptionConsumer.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,13 +102,13 @@ public function subscribe(Consumer $consumer, callable $callback): void
102102

103103
$libCallback = function (LibAMQPMessage $message) {
104104
$receivedMessage = $this->context->convertMessage($message);
105-
$receivedMessage->setConsumerTag($message->delivery_info['consumer_tag']);
105+
$receivedMessage->setConsumerTag($message->getConsumerTag());
106106

107107
/**
108108
* @var AmqpConsumer
109109
* @var callable $callback
110110
*/
111-
list($consumer, $callback) = $this->subscribers[$message->delivery_info['consumer_tag']];
111+
list($consumer, $callback) = $this->subscribers[$message->getConsumerTag()];
112112

113113
if (false === call_user_func($callback, $receivedMessage, $consumer)) {
114114
throw new StopBasicConsumptionException();

pkg/amqp-lib/Tests/AmqpConsumerTest.php

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -112,10 +112,7 @@ public function testOnRejectShouldRejectMessage()
112112
public function testShouldReturnMessageOnReceiveNoWait()
113113
{
114114
$libMessage = new \PhpAmqpLib\Message\AMQPMessage('body');
115-
$libMessage->delivery_info['delivery_tag'] = 'delivery-tag';
116-
$libMessage->delivery_info['routing_key'] = 'routing-key';
117-
$libMessage->delivery_info['redelivered'] = true;
118-
$libMessage->delivery_info['routing_key'] = 'routing-key';
115+
$libMessage->setDeliveryInfo('delivery-tag', true, '', 'routing-key');
119116

120117
$message = new AmqpMessage();
121118

@@ -149,9 +146,7 @@ public function testShouldReturnMessageOnReceiveNoWait()
149146
public function testShouldReturnMessageOnReceiveWithReceiveMethodBasicGet()
150147
{
151148
$libMessage = new \PhpAmqpLib\Message\AMQPMessage('body');
152-
$libMessage->delivery_info['delivery_tag'] = 'delivery-tag';
153-
$libMessage->delivery_info['routing_key'] = 'routing-key';
154-
$libMessage->delivery_info['redelivered'] = true;
149+
$libMessage->setDeliveryInfo('delivery-tag', true, '', 'routing-key');
155150

156151
$message = new AmqpMessage();
157152

pkg/amqp-lib/Tests/Spec/AmqpSubscriptionConsumerConsumeUntilUnsubscribedTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
*/
1414
class AmqpSubscriptionConsumerConsumeUntilUnsubscribedTest extends SubscriptionConsumerConsumeUntilUnsubscribedSpec
1515
{
16-
protected function tearDown()
16+
protected function tearDown(): void
1717
{
1818
if ($this->subscriptionConsumer) {
1919
$this->subscriptionConsumer->unsubscribeAll();

pkg/amqp-lib/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"license": "MIT",
88
"require": {
99
"php": "^7.1.3",
10-
"php-amqplib/php-amqplib": "^2.10",
10+
"php-amqplib/php-amqplib": "^3.2",
1111
"queue-interop/amqp-interop": "^0.8",
1212
"queue-interop/queue-interop": "^0.7|^0.8",
1313
"enqueue/amqp-tools": "^0.9"

0 commit comments

Comments
 (0)