Move client passed to SqsConnectionFactory out of config array

Author: elazar

docs/transport/sqs.md

@@ -36,7 +36,7 @@ $psrContext = $factory->createContext();
 
 // using a pre-configured client
 $client = new Aws\Sqs\SqsClient([ /* ... */ ]);
-$factory = new SqsConnectionFactory(['client' => $client]);
+$factory = new SqsConnectionFactory($client);
 
 // if you have enqueue/enqueue library installed you can use a function from there to create the context
 $psrContext = \Enqueue\dsn_to_context('sqs:');

pkg/sqs/SqsConnectionFactory.php

@@ -19,7 +19,6 @@ class SqsConnectionFactory implements PsrConnectionFactory
 
     /**
      * $config = [
-     *   'client' => null,          - Pre-configured instance of Aws\Sqs\SqsClient. If provided, all other settings except for 'lazy' are ignored.
      *   'key' => null              - AWS credentials. If no credentials are provided, the SDK will attempt to load them from the environment.
      *   'secret' => null,          - AWS credentials. If no credentials are provided, the SDK will attempt to load them from the environment.
      *   'token' => null,           - AWS credentials. If no credentials are provided, the SDK will attempt to load them from the environment.
@@ -35,12 +34,12 @@ class SqsConnectionFactory implements PsrConnectionFactory
      * sqs:
      * sqs::?key=aKey&secret=aSecret&token=aToken
      *
-     * @param array|string|null $config
+     * @param array|string|SqsClient|null $config
      */
     public function __construct($config = 'sqs:')
     {
-        if (is_array($config) && isset($config['client']) && $config['client'] instanceof SqsClient) {
-            $this->client = $config['client'];
+        if ($config instanceof SqsClient) {
+            return $this->client = $config;
         } elseif (empty($config) || 'sqs:' === $config) {
             $config = [];
         } elseif (is_string($config)) {

pkg/sqs/Tests/SqsConnectionFactoryTest.php

@@ -53,10 +53,7 @@ public function testCouldBeConstructedWithClient()
     {
         $client = $this->createMock(SqsClient::class);
 
-        $factory = new SqsConnectionFactory([
-            'client' => $client,
-            'lazy' => false,
-        ]);
+        $factory = new SqsConnectionFactory($client);
 
         $context = $factory->createContext();