Skip to content

Commit f96f723

Browse files
committed
UserServiceTest: getting rid of using a few global constants.
No functional changes.
1 parent 845c73f commit f96f723

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

src/test/java/ru/mystamps/web/service/UserServiceTest.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -84,16 +84,18 @@ public class UserServiceTest {
8484
@Before
8585
public void setUp() {
8686
when(encoder.encodePassword(anyString(), anyString())).thenReturn(TEST_HASH);
87-
when(usersActivationDao.findOne(anyString())).thenReturn(getUsersActivation());
87+
88+
UsersActivation activation = getUsersActivation();
89+
when(usersActivationDao.findOne(anyString())).thenReturn(activation);
8890

8991
registrationForm = new RegisterAccountForm();
90-
registrationForm.setEmail(TEST_EMAIL);
92+
registrationForm.setEmail("john.dou@example.org");
9193

9294
activationForm = new ActivateAccountForm();
9395
activationForm.setLogin(TEST_LOGIN);
9496
activationForm.setPassword(TEST_PASSWORD);
9597
activationForm.setName(TEST_NAME);
96-
activationForm.setActivationKey(TEST_ACTIVATION_KEY);
98+
activationForm.setActivationKey(activation.getActivationKey());
9799

98100
service = new UserServiceImpl(userDao, usersActivationDao, encoder);
99101
}
@@ -182,16 +184,16 @@ public void findRegistrationRequestByActivationKeyShouldCallDao() {
182184
when(usersActivationDao.findOne(anyString())).thenReturn(expectedActivation);
183185

184186
UsersActivation activation =
185-
service.findRegistrationRequestByActivationKey(TEST_ACTIVATION_KEY);
187+
service.findRegistrationRequestByActivationKey(expectedActivation.getActivationKey());
186188

187189
assertThat(activation).isEqualTo(expectedActivation);
188190
}
189191

190192

191193
@Test
192194
public void findRegistrationRequestByActivationKeyShouldPassActivationKeyToDao() {
193-
service.findRegistrationRequestByActivationKey(TEST_ACTIVATION_KEY);
194-
verify(usersActivationDao).findOne(TEST_ACTIVATION_KEY);
195+
service.findRegistrationRequestByActivationKey("0987654321");
196+
verify(usersActivationDao).findOne("0987654321");
195197
}
196198

197199
//

0 commit comments

Comments
 (0)