WhenAdminAddSeries.issueYearFieldShouldHaveOptionsForRangeFrom1840ToCurrentYear: port to Robot Framework.

Addressed to #530

No functional changes.

Author: php-coder

src/test/java/ru/mystamps/web/tests/cases/WhenAdminAddSeries.java

@@ -19,10 +19,6 @@
 
 import java.io.File;
 import java.net.URISyntaxException;
-import java.util.ArrayList;
-import java.util.Calendar;
-import java.util.GregorianCalendar;
-import java.util.List;
 
 import org.springframework.beans.factory.annotation.Value;
 
@@ -45,22 +41,10 @@
  */
 public class WhenAdminAddSeries extends WhenAnyUserAtAnyPageWithForm<AddSeriesPage> {
 
-	private static final int SINCE_YEAR     = 1840;
-	private static final int CURRENT_YEAR   = new GregorianCalendar().get(Calendar.YEAR);
-	
-	private static final List<String> EXPECTED_YEARS =
-		new ArrayList<>(CURRENT_YEAR - SINCE_YEAR + 1);
-	
 	private static final String SAMPLE_IMAGE_NAME = "test.png";
 	private static final String SAMPLE_IMAGE_PATH;
 
 	static {
-		EXPECTED_YEARS.add("Year");
-		// years in reverse order
-		for (int i = CURRENT_YEAR; i >= SINCE_YEAR; i--) {
-			EXPECTED_YEARS.add(String.valueOf(i));
-		}
-		
 		try {
 			SAMPLE_IMAGE_PATH = new File(
 				WhenAdminAddSeries.class.getClassLoader().getResource(SAMPLE_IMAGE_NAME).toURI()
@@ -116,13 +100,6 @@ public void shouldHaveStandardStructure() {
 		checkStandardStructure();
 	}
 
-	@Test(groups = "misc", dependsOnGroups = "std")
-	public void issueYearFieldShouldHaveOptionsForRangeFrom1840ToCurrentYear() {
-		page.showDateOfRelease();
-		
-		assertThat(page.getYearFieldValues()).isEqualTo(EXPECTED_YEARS);
-	}
-	
 	@Test(groups = "misc", dependsOnGroups = "std")
 	public void catalogNumbersShouldBeStripedFromSpaces() {
 		page.showCatalogNumbers();

src/test/robotframework/series/creation/misc.robot

@@ -1,5 +1,6 @@
 *** Settings ***
 Documentation    Verify miscellaneous aspects of series creation
+Library          Collections
 Library          Selenium2Library
 Suite Setup      Before Test Suite
 Suite Teardown   After Test Suite
@@ -14,6 +15,18 @@ Catalog numbers should accept valid values
 	71, 81, 91
 	1000
 
+Issue year should have options for range from 1840 to the current year
+	[Documentation]              Verify that field with year provides all valid values
+	Click Element                id=specify-issue-date-link
+	${availableYears}=           Get List Items  id=year
+	${currentYear}=              Get Time  year  NOW
+	${numberOfYears}=            Get Length  ${availableYears}
+	# +2 here is to include the current year and option with title
+	${expectedNumberOfYears}=    Evaluate  ${currentYear}-1840+2
+	List Should Contain Value    ${availableYears}  1840
+	List Should Contain Value    ${availableYears}  ${currentYear}
+	Should Be Equal As Integers  ${numberOfYears}  ${expectedNumberOfYears}
+
 *** Keywords ***
 Before Test Suite
 	[Documentation]                     Login as admin and go to create series page