chore: remove support for sending emails via SMTP.

Migration path:
- application-prod.properties: remove spring.mail.* properties
- application-prod.properties: add exclusion for org.springframework.boot.autoconfigure.mail.MailSenderAutoConfiguration
- application-prod.properties: add exclusion for org.springframework.boot.autoconfigure.mail.MailSenderValidatorAutoConfiguration

Note that SEND_MAIL_VIA_HTTP_API Togglz feature hasn'e been removed from
database to allow downgrades to the previous versions. The feature will
be cleaned up in the one of the following releases.

Fix #1022

Author: php-coder

pom.xml

@@ -16,6 +16,13 @@
 			<version>${thymeleaf.togglz.version}</version>
 		</dependency>
 
+		<!-- Required for InternetAddress class -->
+		<dependency>
+			<groupId>com.sun.mail</groupId>
+			<artifactId>javax.mail</artifactId>
+			<version>${javax-mail.version}</version>
+		</dependency>
+		
 		<dependency>
 			<groupId>javax.validation</groupId>
 			<artifactId>validation-api</artifactId>
@@ -109,12 +116,6 @@
 			<artifactId>spring-boot-starter-logging</artifactId>
 		</dependency>
 
-		<!-- https://github.com/spring-projects/spring-boot/blob/v1.5.21.RELEASE/spring-boot-starters/spring-boot-starter-mail/pom.xml -->
-		<dependency>
-			<groupId>org.springframework.boot</groupId>
-			<artifactId>spring-boot-starter-mail</artifactId>
-		</dependency>
-		
 		<!-- https://github.com/spring-projects/spring-boot/blob/v1.5.21.RELEASE/spring-boot-starters/spring-boot-starter-security/pom.xml -->
 		<dependency>
 			<groupId>org.springframework.boot</groupId>

src/main/java/ru/mystamps/web/feature/site/SiteConfig.java

@@ -25,7 +25,6 @@
 import org.springframework.context.annotation.Configuration;
 import org.springframework.core.env.Environment;
 import org.springframework.jdbc.core.namedparam.NamedParameterJdbcTemplate;
-import org.springframework.mail.javamail.JavaMailSender;
 import ru.mystamps.web.feature.account.UserService;
 import ru.mystamps.web.feature.account.UsersActivationService;
 import ru.mystamps.web.feature.category.CategoryService;
@@ -34,9 +33,7 @@
 import ru.mystamps.web.feature.report.ReportService;
 import ru.mystamps.web.feature.series.SeriesService;
 import ru.mystamps.web.support.mailgun.ApiMailgunEmailSendingStrategy;
-import ru.mystamps.web.support.mailgun.FallbackMailgunEmailSendingStrategy;
 import ru.mystamps.web.support.mailgun.MailgunEmailSendingStrategy;
-import ru.mystamps.web.support.mailgun.SmtpMailgunEmailSendingStrategy;
 
 import java.util.Locale;
 
@@ -103,7 +100,6 @@ public static class Services {
 		private final ReportService reportService;
 		private final SeriesService seriesService;
 		private final Environment env;
-		private final JavaMailSender mailSender;
 		private final NamedParameterJdbcTemplate jdbcTemplate;
 		private final MessageSource messageSource;
 		private final RestTemplateBuilder restTemplateBuilder;
@@ -135,9 +131,11 @@ public MailService mailService() {
 			String password = env.getRequiredProperty("mailgun.password");
 			String endpoint = env.getRequiredProperty("mailgun.endpoint");
 
-			MailgunEmailSendingStrategy mailStrategy = new FallbackMailgunEmailSendingStrategy(
-				new ApiMailgunEmailSendingStrategy(restTemplateBuilder, endpoint, user, password),
-				new SmtpMailgunEmailSendingStrategy(mailSender)
+			MailgunEmailSendingStrategy mailStrategy = new ApiMailgunEmailSendingStrategy(
+				restTemplateBuilder,
+				endpoint,
+				user,
+				password
 			);
 
 			return new MailServiceImpl(

src/main/java/ru/mystamps/web/support/mailgun/FallbackMailgunEmailSendingStrategy.java

@@ -30,7 +30,6 @@ public interface MailgunEmailSendingStrategy {
 	 * @param email data and meta-data for sending an e-mail
 	 * @throws EmailSendingException when any error occurs
 	 * @see ApiMailgunEmailSendingStrategy
-	 * @see SmtpMailgunEmailSendingStrategy
 	 * @see <a href="https://documentation.mailgun.com/en/latest/user_manual.html#tagging">Tagging</a>
 	 * @see <a href="https://documentation.mailgun.com/en/latest/user_manual.html#sending-in-test-mode">Sending in Test Mode</a>
 	 */

src/main/java/ru/mystamps/web/support/mailgun/MailgunEmailSendingStrategy.java

@@ -22,6 +22,7 @@
 import org.togglz.core.annotation.Label;
 import org.togglz.core.context.FeatureContext;
 
+// @todo #1022 Togglz: remove SEND_MAIL_VIA_HTTP_API from database
 public enum Features implements Feature {
 
 	@Label("/series/{id}: possibility to user to add series to collection")
@@ -48,10 +49,6 @@ public enum Features implements Feature {
 	@EnabledByDefault
 	SEND_ACTIVATION_MAIL,
 
-	@Label("Send mail via HTTP API and fallback to SMTP as the last resort")
-	@EnabledByDefault
-	SEND_MAIL_VIA_HTTP_API,
-	
 	@Label("/series/add: show link with auto-suggestions")
 	@EnabledByDefault
 	SHOW_SUGGESTION_LINK;

src/main/java/ru/mystamps/web/support/mailgun/SmtpMailgunEmailSendingStrategy.java

@@ -61,6 +61,8 @@ spring.autoconfigure.exclude: \
 	, org.springframework.boot.autoconfigure.couchbase.CouchbaseAutoConfiguration \
 	, org.springframework.boot.autoconfigure.data.couchbase.CouchbaseDataAutoConfiguration \
 	, org.springframework.boot.autoconfigure.data.couchbase.CouchbaseRepositoriesAutoConfiguration \
+	, org.springframework.boot.autoconfigure.mail.MailSenderAutoConfiguration \
+	, org.springframework.boot.autoconfigure.mail.MailSenderValidatorAutoConfiguration \
 	, org.springframework.boot.autoconfigure.mobile.DeviceDelegatingViewResolverAutoConfiguration \
 	, org.springframework.boot.autoconfigure.mobile.DeviceResolverAutoConfiguration \
 	, org.springframework.boot.autoconfigure.data.elasticsearch.ElasticsearchAutoConfiguration \

src/main/java/ru/mystamps/web/support/togglz/Features.java

@@ -59,6 +59,8 @@ spring.autoconfigure.exclude: \
 	, org.springframework.boot.autoconfigure.couchbase.CouchbaseAutoConfiguration \
 	, org.springframework.boot.autoconfigure.data.couchbase.CouchbaseDataAutoConfiguration \
 	, org.springframework.boot.autoconfigure.data.couchbase.CouchbaseRepositoriesAutoConfiguration \
+	, org.springframework.boot.autoconfigure.mail.MailSenderAutoConfiguration \
+	, org.springframework.boot.autoconfigure.mail.MailSenderValidatorAutoConfiguration \
 	, org.springframework.boot.autoconfigure.mobile.DeviceDelegatingViewResolverAutoConfiguration \
 	, org.springframework.boot.autoconfigure.mobile.DeviceResolverAutoConfiguration \
 	, org.springframework.boot.autoconfigure.data.elasticsearch.ElasticsearchAutoConfiguration \

src/main/resources/application-test.properties

@@ -6,12 +6,6 @@ spring.datasource.password: {{ user_db_password }}
 spring.datasource.driver-class-name: com.mysql.jdbc.Driver
 spring.datasource.initialize: false
 
-spring.mail.host: smtp.mailgun.org
-spring.mail.port: 25
-spring.mail.username: postmaster@my-stamps.ru
-spring.mail.password: {{ user_mail_password }}
-spring.mail.test-connection: true
-
 spring.messages.cache-seconds: -1
 spring.messages.fallback-to-system-locale: false
 spring.messages.basename: \
@@ -67,6 +61,8 @@ spring.autoconfigure.exclude: \
 	, org.springframework.boot.autoconfigure.data.elasticsearch.ElasticsearchDataAutoConfiguration \
 	, org.springframework.boot.autoconfigure.data.elasticsearch.ElasticsearchRepositoriesAutoConfiguration \
 	, org.springframework.boot.autoconfigure.ldap.embedded.EmbeddedLdapAutoConfiguration \
+	, org.springframework.boot.autoconfigure.mail.MailSenderAutoConfiguration \
+	, org.springframework.boot.autoconfigure.mail.MailSenderValidatorAutoConfiguration \
 	, org.springframework.boot.autoconfigure.mongo.embedded.EmbeddedMongoAutoConfiguration \
 	, org.springframework.boot.autoconfigure.web.ErrorMvcAutoConfiguration \
 	, org.springframework.boot.autoconfigure.social.FacebookAutoConfiguration \

src/main/resources/application-travis.properties

@@ -6,7 +6,6 @@
   vars:
     profile: 'test'
     user_db_password: 'q1'
-    user_mail_password: 'q2'
     mailgun_api_password: 'q3'
     # required for Ubuntu 16.04. which installs Python 2.x to a non-standard path
     ansible_python_interpreter: "/usr/bin/python2.7"