CategoryService.countCategoriesOf(): change argument from Collection to Integer.

Addressed to #120

No functional changes.

Author: php-coder

src/main/java/ru/mystamps/web/controller/CollectionController.java

@@ -70,7 +70,8 @@ public String showInfo(
 		model.addAttribute("seriesOfCollection", seriesOfCollection);
 
 		if (seriesOfCollection.iterator().hasNext()) {
-			model.addAttribute("categoryCounter", categoryService.countCategoriesOf(collection));
+			// CheckStyle: ignore LineLength for next 1 line
+			model.addAttribute("categoryCounter", categoryService.countCategoriesOf(collection.getId()));
 			model.addAttribute("countryCounter", countryService.countCountriesOf(collection));
 			model.addAttribute("seriesCounter", seriesService.countSeriesOf(collectionId));
 			model.addAttribute("stampsCounter", seriesService.countStampsOf(collectionId));

src/main/java/ru/mystamps/web/service/CategoryService.java

@@ -31,7 +31,7 @@ public interface CategoryService {
 	Iterable<SelectEntityDto> findAllAsSelectEntities(String lang);
 	Iterable<LinkEntityDto> findAllAsLinkEntities(String lang);
 	long countAll();
-	long countCategoriesOf(Collection collection);
+	long countCategoriesOf(Integer collectionId);
 	long countByName(String name);
 	long countByNameRu(String name);
 	Map<String, Integer> getStatisticsOf(Collection collection, String lang);

src/main/java/ru/mystamps/web/service/CategoryServiceImpl.java

@@ -100,11 +100,10 @@ public long countAll() {
 
 	@Override
 	@Transactional(readOnly = true)
-	public long countCategoriesOf(Collection collection) {
-		Validate.isTrue(collection != null, "Collection must be non null");
-		Validate.isTrue(collection.getId() != null, "Collection id must be non null");
+	public long countCategoriesOf(Integer collectionId) {
+		Validate.isTrue(collectionId != null, "Collection id must be non null");
 
-		return categoryDao.countCategoriesOfCollection(collection.getId());
+		return categoryDao.countCategoriesOfCollection(collectionId);
 	}
 
 	@Override

src/test/groovy/ru/mystamps/web/service/CategoryServiceImplTest.groovy

@@ -278,31 +278,18 @@ class CategoryServiceImplTest extends Specification {
 	// Tests for countCategoriesOf()
 	//
 
-	def "countCategoriesOf() should throw exception when collection is null"() {
-		when:
-			service.countCategoriesOf(null)
-		then:
-			thrown IllegalArgumentException
-	}
-	
 	def "countCategoriesOf() should throw exception when collection id is null"() {
-		given:
-			Collection collection = Mock()
-			collection.getId() >> null
 		when:
-			service.countCategoriesOf(collection)
+			service.countCategoriesOf(null)
 		then:
 			thrown IllegalArgumentException
 	}
 
 	def "countCategoriesOf() should pass arguments to dao"() {
 		given:
 			Integer expectedCollectionId = 10
-		and:
-			Collection expectedCollection = Mock()
-			expectedCollection.getId() >> expectedCollectionId
 		when:
-			service.countCategoriesOf(expectedCollection)
+			service.countCategoriesOf(expectedCollectionId)
 		then:
 			1 * categoryDao.countCategoriesOfCollection({ Integer collectionId ->
 				assert expectedCollectionId == collectionId