Skip to content

Commit b8cd1f8

Browse files
committed
WhenAdminAddSeries,WhenUserAddSeries: combine together test cases for catalog numbers.
-shouldIgnoreDuplicatedMichelNumbers -shouldIgnoreDuplicatedScottNumbers -shouldIgnoreDuplicatedYvertNumbers -shouldIgnoreDuplicatedGibbonsNumbers +shouldIgnoreDuplicatedCatalogNumbers No functional changes.
1 parent a8e7634 commit b8cd1f8

File tree

2 files changed

+10
-86
lines changed

2 files changed

+10
-86
lines changed

src/test/java/ru/mystamps/web/tests/cases/WhenAdminAddSeries.java

Lines changed: 5 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -367,62 +367,24 @@ public void shouldCreateSeriesWithAllFieldsFilled() {
367367
}
368368

369369
@Test(groups = "logic", dependsOnGroups = { "std", "valid", "invalid", "misc" })
370-
public void shouldIgnoreDuplicatedMichelNumbers() {
370+
public void shouldIgnoreDuplicatedCatalogNumbers() {
371371
page.fillCategory(validCategoryName);
372372
page.fillQuantity("2");
373373
page.fillImage(SAMPLE_IMAGE_PATH);
374374
page.showCatalogNumbers();
375-
page.fillMichelNumbers("104,105,104");
376-
377-
AbstractPage next = page.submit();
378-
assertThat(next).isInstanceOf(InfoSeriesPage.class);
379375

380-
InfoSeriesPage nextPage = (InfoSeriesPage)next;
381-
assertThat(nextPage.getMichelCatalogInfo()).isEqualTo("#104, 105");
382-
}
383-
384-
@Test(groups = "logic", dependsOnGroups = { "std", "valid", "invalid", "misc" })
385-
public void shouldIgnoreDuplicatedScottNumbers() {
386-
page.fillCategory(validCategoryName);
387-
page.fillQuantity("2");
388-
page.fillImage(SAMPLE_IMAGE_PATH);
389-
page.showCatalogNumbers();
376+
page.fillMichelNumbers("104,105,104");
390377
page.fillScottNumbers("114,115,114");
391-
392-
AbstractPage next = page.submit();
393-
assertThat(next).isInstanceOf(InfoSeriesPage.class);
394-
395-
InfoSeriesPage nextPage = (InfoSeriesPage)next;
396-
assertThat(nextPage.getScottCatalogInfo()).isEqualTo("#114, 115");
397-
}
398-
399-
@Test(groups = "logic", dependsOnGroups = { "std", "valid", "invalid", "misc" })
400-
public void shouldIgnoreDuplicatedYvertNumbers() {
401-
page.fillCategory(validCategoryName);
402-
page.fillQuantity("2");
403-
page.fillImage(SAMPLE_IMAGE_PATH);
404-
page.showCatalogNumbers();
405378
page.fillYvertNumbers("124,125,124");
406-
407-
AbstractPage next = page.submit();
408-
assertThat(next).isInstanceOf(InfoSeriesPage.class);
409-
410-
InfoSeriesPage nextPage = (InfoSeriesPage)next;
411-
assertThat(nextPage.getYvertCatalogInfo()).isEqualTo("#124, 125");
412-
}
413-
414-
@Test(groups = "logic", dependsOnGroups = { "std", "valid", "invalid", "misc" })
415-
public void shouldIgnoreDuplicatedGibbonsNumbers() {
416-
page.fillCategory(validCategoryName);
417-
page.fillQuantity("2");
418-
page.fillImage(SAMPLE_IMAGE_PATH);
419-
page.showCatalogNumbers();
420379
page.fillGibbonsNumbers("134,135,134");
421380

422381
AbstractPage next = page.submit();
423382
assertThat(next).isInstanceOf(InfoSeriesPage.class);
424383

425384
InfoSeriesPage nextPage = (InfoSeriesPage)next;
385+
assertThat(nextPage.getMichelCatalogInfo()).isEqualTo("#104, 105");
386+
assertThat(nextPage.getScottCatalogInfo()).isEqualTo("#114, 115");
387+
assertThat(nextPage.getYvertCatalogInfo()).isEqualTo("#124, 125");
426388
assertThat(nextPage.getGibbonsCatalogInfo()).isEqualTo("#134, 135");
427389
}
428390

src/test/java/ru/mystamps/web/tests/cases/WhenUserAddSeries.java

Lines changed: 5 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -334,62 +334,24 @@ public void shouldCreateSeriesWithAllFieldsFilled() {
334334
}
335335

336336
@Test(groups = "logic", dependsOnGroups = { "std", "valid", "invalid", "misc" })
337-
public void shouldIgnoreDuplicatedMichelNumbers() {
337+
public void shouldIgnoreDuplicatedCatalogNumbers() {
338338
page.fillCategory(validCategoryName);
339339
page.fillQuantity("2");
340340
page.fillImage(SAMPLE_IMAGE_PATH);
341341
page.showCatalogNumbers();
342-
page.fillMichelNumbers("4,5,4");
343-
344-
AbstractPage next = page.submit();
345-
assertThat(next).isInstanceOf(InfoSeriesPage.class);
346342

347-
InfoSeriesPage nextPage = (InfoSeriesPage)next;
348-
assertThat(nextPage.getMichelCatalogInfo()).isEqualTo("#4, 5");
349-
}
350-
351-
@Test(groups = "logic", dependsOnGroups = { "std", "valid", "invalid", "misc" })
352-
public void shouldIgnoreDuplicatedScottNumbers() {
353-
page.fillCategory(validCategoryName);
354-
page.fillQuantity("2");
355-
page.fillImage(SAMPLE_IMAGE_PATH);
356-
page.showCatalogNumbers();
343+
page.fillMichelNumbers("4,5,4");
357344
page.fillScottNumbers("14,15,14");
358-
359-
AbstractPage next = page.submit();
360-
assertThat(next).isInstanceOf(InfoSeriesPage.class);
361-
362-
InfoSeriesPage nextPage = (InfoSeriesPage)next;
363-
assertThat(nextPage.getScottCatalogInfo()).isEqualTo("#14, 15");
364-
}
365-
366-
@Test(groups = "logic", dependsOnGroups = { "std", "valid", "invalid", "misc" })
367-
public void shouldIgnoreDuplicatedYvertNumbers() {
368-
page.fillCategory(validCategoryName);
369-
page.fillQuantity("2");
370-
page.fillImage(SAMPLE_IMAGE_PATH);
371-
page.showCatalogNumbers();
372345
page.fillYvertNumbers("24,25,24");
373-
374-
AbstractPage next = page.submit();
375-
assertThat(next).isInstanceOf(InfoSeriesPage.class);
376-
377-
InfoSeriesPage nextPage = (InfoSeriesPage)next;
378-
assertThat(nextPage.getYvertCatalogInfo()).isEqualTo("#24, 25");
379-
}
380-
381-
@Test(groups = "logic", dependsOnGroups = { "std", "valid", "invalid", "misc" })
382-
public void shouldIgnoreDuplicatedGibbonsNumbers() {
383-
page.fillCategory(validCategoryName);
384-
page.fillQuantity("2");
385-
page.fillImage(SAMPLE_IMAGE_PATH);
386-
page.showCatalogNumbers();
387346
page.fillGibbonsNumbers("34,35,34");
388347

389348
AbstractPage next = page.submit();
390349
assertThat(next).isInstanceOf(InfoSeriesPage.class);
391350

392351
InfoSeriesPage nextPage = (InfoSeriesPage)next;
352+
assertThat(nextPage.getMichelCatalogInfo()).isEqualTo("#4, 5");
353+
assertThat(nextPage.getScottCatalogInfo()).isEqualTo("#14, 15");
354+
assertThat(nextPage.getYvertCatalogInfo()).isEqualTo("#24, 25");
393355
assertThat(nextPage.getGibbonsCatalogInfo()).isEqualTo("#34, 35");
394356
}
395357

0 commit comments

Comments
 (0)