ImageServiceImpl: use NOPLogger for unit tests to reduce output to console.

No functional changes.

Author: php-coder

src/main/java/ru/mystamps/web/config/ServicesConfig.java

@@ -90,6 +90,7 @@ public CronService getCronService() {
 	@Bean
 	public ImageService getImageService() {
 		return new ImageServiceImpl(
+			LoggerFactory.getLogger(ImageServiceImpl.class),
 			strategiesConfig.getImagePersistenceStrategy(),
 			new TimedImagePreviewStrategy(new ThumbnailatorImagePreviewStrategy()),
 			daoConfig.getImageDao()

src/main/java/ru/mystamps/web/service/ImageServiceImpl.java

@@ -23,7 +23,6 @@
 import org.apache.commons.lang3.Validate;
 
 import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 import org.springframework.transaction.annotation.Transactional;
 import org.springframework.web.multipart.MultipartFile;
@@ -46,8 +45,8 @@
 
 @RequiredArgsConstructor
 public class ImageServiceImpl implements ImageService {
-	private static final Logger LOG = LoggerFactory.getLogger(ImageServiceImpl.class);
 
+	private final Logger log;
 	private final ImagePersistenceStrategy imagePersistenceStrategy;
 	private final ImagePreviewStrategy imagePreviewStrategy;
 	private final ImageDao imageDao;
@@ -77,7 +76,7 @@ public ImageInfoDto save(MultipartFile file) {
 		}
 
 		ImageInfoDto imageInfo = new ImageInfoDto(imageId, imageType);
-		LOG.info("Image info has been saved to database ({})", imageInfo);
+		log.info("Image info has been saved to database ({})", imageInfo);
 
 		imagePersistenceStrategy.save(file, imageInfo);
 
@@ -134,7 +133,7 @@ public void addToSeries(Integer seriesId, Integer imageId) {
 
 		imageDao.addToSeries(seriesId, imageId);
 
-		LOG.info("Series #{}: image #{} was added", seriesId, imageId);
+		log.info("Series #{}: image #{} was added", seriesId, imageId);
 	}
 
 	@Override
@@ -161,7 +160,7 @@ private ImageDto createPreview(ImageInfoDto previewInfo, byte[] image) {
 			return new DbImageDto("jpeg", preview);
 
 		} catch (CreateImagePreviewException | ImagePersistenceException ex) {
-			LOG.warn(
+			log.warn(
 				String.format("Image #%d: couldn't create/save preview", previewInfo.getId()),
 				ex
 			);

src/test/groovy/ru/mystamps/web/service/ImageServiceImplTest.groovy

@@ -22,6 +22,8 @@ import org.springframework.web.multipart.MultipartFile
 import spock.lang.Specification
 import spock.lang.Unroll
 
+import org.slf4j.helpers.NOPLogger
+
 import ru.mystamps.web.dao.ImageDao
 import ru.mystamps.web.dao.dto.ImageDto
 import ru.mystamps.web.dao.dto.ImageInfoDto
@@ -35,8 +37,12 @@ class ImageServiceImplTest extends Specification {
 	private final ImagePreviewStrategy imagePreviewStrategy = Mock()
 	private final ImagePersistenceStrategy imagePersistenceStrategy = Mock()
 
-	private final ImageService service =
-		new ImageServiceImpl(imagePersistenceStrategy, imagePreviewStrategy, imageDao)
+	private final ImageService service = new ImageServiceImpl(
+		NOPLogger.NOP_LOGGER,
+		imagePersistenceStrategy,
+		imagePreviewStrategy,
+		imageDao
+	)
 
 	def setup() {
 		multipartFile.size >> 1024L