CollectionServiceImpl: rename a member.

No functional changes.

Author: php-coder

src/main/java/ru/mystamps/web/service/CollectionServiceImpl.java

@@ -38,7 +38,7 @@
 public class CollectionServiceImpl implements CollectionService {
 	private static final Logger LOG = LoggerFactory.getLogger(CollectionServiceImpl.class);
 
-	private final JdbcCollectionDao jdbcCollectionDao;
+	private final JdbcCollectionDao collectionDao;
 
 	@Override
 	@Transactional
@@ -52,7 +52,7 @@ public void createCollection(User user) {
 		Validate.isTrue(slug != null, "Slug for string '%s' is null", user.getLogin());
 		collection.setSlug(slug);
 
-		Integer id = jdbcCollectionDao.add(collection);
+		Integer id = collectionDao.add(collection);
 
 		LOG.info("Collection #{} has been created ({})", id, collection);
 	}
@@ -64,10 +64,10 @@ public UrlEntityDto addToCollection(Integer userId, Integer seriesId) {
 		Validate.isTrue(userId != null, "User id must be non null");
 		Validate.isTrue(seriesId != null, "Series id must be non null");
 
-		UrlEntityDto url = jdbcCollectionDao.findCollectionUrlEntityByUserId(userId);
+		UrlEntityDto url = collectionDao.findCollectionUrlEntityByUserId(userId);
 		Integer collectionId = url.getId();
 
-		jdbcCollectionDao.addSeriesToCollection(collectionId, seriesId);
+		collectionDao.addSeriesToCollection(collectionId, seriesId);
 
 		LOG.info(
 			"Series #{} has been added to collection #{} of user #{}",
@@ -86,10 +86,10 @@ public UrlEntityDto removeFromCollection(Integer userId, Integer seriesId) {
 		Validate.isTrue(userId != null, "User id must be non null");
 		Validate.isTrue(seriesId != null, "Series id must be non null");
 
-		UrlEntityDto url = jdbcCollectionDao.findCollectionUrlEntityByUserId(userId);
+		UrlEntityDto url = collectionDao.findCollectionUrlEntityByUserId(userId);
 		Integer collectionId = url.getId();
 
-		jdbcCollectionDao.removeSeriesFromCollection(collectionId, seriesId);
+		collectionDao.removeSeriesFromCollection(collectionId, seriesId);
 
 		LOG.info(
 			"Series #{} has been removed from collection of user #{}",
@@ -110,7 +110,7 @@ public boolean isSeriesInCollection(Integer userId, Integer seriesId) {
 			return false;
 		}
 
-		boolean isSeriesInCollection = jdbcCollectionDao.isSeriesInUserCollection(userId, seriesId);
+		boolean isSeriesInCollection = collectionDao.isSeriesInUserCollection(userId, seriesId);
 
 		LOG.debug(
 			"Series #{} belongs to collection of user #{}: {}",
@@ -125,15 +125,15 @@ public boolean isSeriesInCollection(Integer userId, Integer seriesId) {
 	@Override
 	@Transactional(readOnly = true)
 	public long countCollectionsOfUsers() {
-		return jdbcCollectionDao.countCollectionsOfUsers();
+		return collectionDao.countCollectionsOfUsers();
 	}
 
 	@Override
 	@Transactional(readOnly = true)
 	public Iterable<LinkEntityDto> findRecentlyCreated(int quantity) {
 		Validate.isTrue(quantity > 0, "Quantity must be greater than 0");
 
-		return jdbcCollectionDao.findLastCreated(quantity);
+		return collectionDao.findLastCreated(quantity);
 	}
 
 }

src/test/groovy/ru/mystamps/web/service/CollectionServiceImplTest.groovy

@@ -23,12 +23,12 @@ import spock.lang.Unroll
 import ru.mystamps.web.dao.JdbcCollectionDao
 
 class CollectionServiceImplTest extends Specification {
-	private JdbcCollectionDao jdbcCollectionDao = Mock()
+	private JdbcCollectionDao collectionDao = Mock()
 
 	private CollectionService service
 
 	def setup() {
-		service = new CollectionServiceImpl(jdbcCollectionDao)
+		service = new CollectionServiceImpl(collectionDao)
 	}
 
 	//
@@ -53,7 +53,7 @@ class CollectionServiceImplTest extends Specification {
 		when:
 			service.findRecentlyCreated(expectedQuantity)
 		then:
-			1 * jdbcCollectionDao.findLastCreated({ int quantity ->
+			1 * collectionDao.findLastCreated({ int quantity ->
 				assert expectedQuantity == quantity
 				return true
 			}) >> []