license/sortpom: show aggregated message

Author: php-coder

Dangerfile

@@ -97,29 +97,34 @@ license_output = 'license.log'
 unless File.file?(license_output)
 	warn("Couldn't find #{license_output}. Result of checking licenses is unknown")
 else
-	errors_count = 0
+	errors = []
 	File.readlines(license_output)
 		.select { |line| line.start_with? '[WARNING]' }
 		.each do |line|
 			errors_count += 1
 			line.sub!('[WARNING] ', '')
 			line.sub!(pwd, '')
 			if line =~ /Missing header in: .*/
-				parsed = line.match(/(?<msg>[^:]+) in: (?<file>.*)/)
+				parsed = line.match(/(?<msg>Missing header in: )(?<file>.*)/)
 				msg    = parsed['msg']
 				file   = parsed['file']
 				file   = github.html_link("#{file}#L1")
-				fail("license error in #{file}: #{msg}")
-			else
-				fail("license error: #{line}")
+				line = "#{msg}#{file}"
 			end
+			errors << line
 		end
 
-	link = 'https://github.com/php-coder/mystamps/wiki/check-license-header'
-	if errors_count == 1
-		message("license plugin reports about #{errors_count} error. Please, fix it by executing `mvn license:format`. See also: <a href=\"#{link}\">#{link}</a>")
-	elsif errors_count > 0
-		message("license plugin reports about #{errors_count} errors. Please, fix them by executing `mvn license:format`. See also: <a href=\"#{link}\">#{link}</a>")
+	unless errors.empty?
+		link = 'https://github.com/php-coder/mystamps/wiki/check-license-header'
+		if errors_cnt == 1
+			message("license plugin reports about #{errors_cnt} error. "\
+					"Please, fix it by executing `mvn license:format`. "\
+					"See also: <a href=\"#{link}\">#{link}</a>")
+		elsif errors_cnt > 1
+			message("license plugin reports about #{errors_cnt} errors. "\
+					"Please, fix them by executing `mvn license:format`. "\
+					"See also: <a href=\"#{link}\">#{link}</a>")
+		end
 	end
 end
 
@@ -128,7 +133,7 @@ sortpom_output = 'pom.log'
 unless File.file?(sortpom_output)
 	warn("Couldn't find #{sortpom_output}. Result of checking pom.xml is unknown")
 else
-	errors_count = 0
+	errors = []
 	File.readlines(sortpom_output).each do |line|
 		# don't process lines after this message
 		if line.start_with? '[INFO] BUILD FAILURE'
@@ -140,21 +145,25 @@ else
 			next
 		end
 
-		# ignore summary message
-		if line =~ /The file .* is not sorted/
-			next
-		end
-		
-		errors_count += 1
-		line.sub!('[ERROR] ', '')
-		fail("pom.xml error: #{line}")
+		line.!sub('[ERROR] ', '')
+		errors << line
 	end
 
-	link = 'https://github.com/php-coder/mystamps/wiki/sortpom',
-	if errors_count == 1
-		message("sortpom plugin reports about #{errors_count} error. Please, fix it by executing `mvn sortpom:sort`. See also: <a href=\"#{link}\">#{link}</a>")
-	elsif errors_count > 0
-		message("sortpom plugin reports about #{errors_count} errors. Please, fix them by executing `mvn sortpom:sort`. See also: <a href=\"#{link}\">#{link}</a>")
+	unless errors.empty?
+		link = 'https://github.com/php-coder/mystamps/wiki/sortpom',
+		errors_cnt = errors.size()
+		error_msgs = errors.join("\n")
+		if errors_cnt == 1
+			message("sortpom plugin reports about #{errors_cnt} error:\n"\
+					"#{error_msgs}\n"\
+					"Please, fix it by executing `mvn sortpom:sort`. "\
+					"See also: <a href=\"#{link}\">#{link}</a>")
+		elsif errors_cnt > 1
+			message("sortpom plugin reports about #{errors_cnt} errors:\n"\
+					"#{error_msgs}\n"\
+					"Please, fix them by executing `mvn sortpom:sort`. "\
+					"See also: <a href=\"#{link}\">#{link}</a>")
+		end
 	end
 end