Skip to content

Commit a136271

Browse files
php-coderphp-coder
committed
refactor: use a new way of writing element locators to fix warnings.
Prior this change there were a lot of warnings like the following: [ WARN ] '=' is deprecated as locator strategy separator. ':' should be used instead Address to 1001
1 parent 185a5d6 commit a136271

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

57 files changed

+813
-813
lines changed

‎src/test/robotframework/account/activation/logic.robot

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,24 +8,24 @@ Force Tags account activation logic
88

99
*** Test Cases ***
1010
Activate account with full info (fill all fields)
11-
Input Text id=login 1st-test-login
12-
Input Text id=name Test Suite
13-
Input Text id=password test-password
14-
Input Text id=passwordConfirmation test-password
15-
Input Text id=activationKey 7777744444
16-
Submit Form id=activate-account-form
11+
Input Text id:login 1st-test-login
12+
Input Text id:name Test Suite
13+
Input Text id:password test-password
14+
Input Text id:passwordConfirmation test-password
15+
Input Text id:activationKey 7777744444
16+
Submit Form id:activate-account-form
1717
Location Should Be ${SITE_URL}/account/auth
18-
Element Text Should Be id=msg-success Account successfully activated! Now you can pass authentication.
18+
Element Text Should Be id:msg-success Account successfully activated! Now you can pass authentication.
1919

2020
Activate account with only required info (fill only mandatory fields)
21-
Input Text id=login 2nd-test-login
22-
Input Text id=name ${EMPTY}
23-
Input Text id=password test-password
24-
Input Text id=passwordConfirmation test-password
25-
Input Text id=activationKey 4444477777
26-
Submit Form id=activate-account-form
21+
Input Text id:login 2nd-test-login
22+
Input Text id:name ${EMPTY}
23+
Input Text id:password test-password
24+
Input Text id:passwordConfirmation test-password
25+
Input Text id:activationKey 4444477777
26+
Submit Form id:activate-account-form
2727
Location Should Be ${SITE_URL}/account/auth
28-
Element Text Should Be id=msg-success Account successfully activated! Now you can pass authentication.
28+
Element Text Should Be id:msg-success Account successfully activated! Now you can pass authentication.
2929

3030
*** Keywords ***
3131
Before Test Suite

‎src/test/robotframework/account/activation/misc-anonymous.robot

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -10,27 +10,27 @@ Force Tags account activation misc
1010
*** Test Cases ***
1111
Activation key should be auto filled from url
1212
Go To ${SITE_URL}/account/activate?key=7777755555
13-
Textfield Value Should Be id=activationKey 7777755555
13+
Textfield Value Should Be id:activationKey 7777755555
1414

1515
Most short login should be accepted
16-
Input Text id=login ab
17-
Submit Form id=activate-account-form
18-
Page Should Not Contain Element id=login.errors
16+
Input Text id:login ab
17+
Submit Form id:activate-account-form
18+
Page Should Not Contain Element id:login.errors
1919

2020
Most long login should be accepted
21-
Input Text id=login abcde1234567890
22-
Submit Form id=activate-account-form
23-
Page Should Not Contain Element id=login.errors
21+
Input Text id:login abcde1234567890
22+
Submit Form id:activate-account-form
23+
Page Should Not Contain Element id:login.errors
2424

2525
Login with allowed characters should be accepted
26-
Input Text id=login t.3.s.7-T_E_S_T
27-
Submit Form id=activate-account-form
28-
Page Should Not Contain Element id=login.errors
26+
Input Text id:login t.3.s.7-T_E_S_T
27+
Submit Form id:activate-account-form
28+
Page Should Not Contain Element id:login.errors
2929

3030
Login should be striped from leading and trailing spaces
31-
Input Text id=login ${SPACE * 2}testLogin${SPACE * 2}
32-
Submit Form id=activate-account-form
33-
Textfield Value Should Be id=login testLogin
31+
Input Text id:login ${SPACE * 2}testLogin${SPACE * 2}
32+
Submit Form id:activate-account-form
33+
Textfield Value Should Be id:login testLogin
3434

3535
Name with allowed characters should be accepted
3636
[Template] Name should not cause an error
@@ -39,19 +39,19 @@ Name with allowed characters should be accepted
3939
Семён Якушев
4040

4141
Name should be striped from leading and trailing spaces
42-
Input Text id=name ${SPACE * 2}test${SPACE * 2}
43-
Submit Form id=activate-account-form
44-
Textfield Value Should Be id=name test
42+
Input Text id:name ${SPACE * 2}test${SPACE * 2}
43+
Submit Form id:activate-account-form
44+
Textfield Value Should Be id:name test
4545

4646
Most short password should be accepted
47-
Input Text id=password 1234
48-
Submit Form id=activate-account-form
49-
Page Should Not Contain Element id=password.errors
47+
Input Text id:password 1234
48+
Submit Form id:activate-account-form
49+
Page Should Not Contain Element id:password.errors
5050

5151
Password with allowed characters should be accepted
52-
Input Text id=password t3s7-T_E_S_T
53-
Submit Form id=activate-account-form
54-
Page Should Not Contain Element id=password.errors
52+
Input Text id:password t3s7-T_E_S_T
53+
Submit Form id:activate-account-form
54+
Page Should Not Contain Element id:password.errors
5555

5656
*** Keywords ***
5757
Before Test Suite
@@ -65,6 +65,6 @@ Disable Client Validation
6565
Name should not cause an error
6666
[Arguments] ${name}
6767
Disable Client Validation
68-
Input Text id=name ${name}
69-
Submit Form id=activate-account-form
70-
Page Should Not Contain Element id=name.errors
68+
Input Text id:name ${name}
69+
Submit Form id:activate-account-form
70+
Page Should Not Contain Element id:name.errors

‎src/test/robotframework/account/activation/misc-user.robot

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Force Tags account activation misc
1010
*** Test Cases ***
1111
User cannot activate account again
1212
Page Should Contain You have already activated account
13-
Page Should Not Contain Element id=activate-account-form
13+
Page Should Not Contain Element id:activate-account-form
1414

1515
*** Keywords ***
1616
Before Test Suite

‎src/test/robotframework/account/activation/validation.robot

Lines changed: 53 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -9,36 +9,36 @@ Force Tags account activation validation
99

1010
*** Test Cases ***
1111
Activate account with matching login and password
12-
Input Text id=login admin
13-
Input Text id=password admin
14-
Submit Form id=activate-account-form
15-
Element Text Should Be id=password.errors Password and login must be different
12+
Input Text id:login admin
13+
Input Text id:password admin
14+
Submit Form id:activate-account-form
15+
Element Text Should Be id:password.errors Password and login must be different
1616

1717
Activate account with mismatching password and password confirmation
18-
Input Text id=password password123
19-
Input Text id=passwordConfirmation password321
20-
Submit Form id=activate-account-form
21-
Element Text Should Be id=passwordConfirmation.errors Password mismatch
18+
Input Text id:password password123
19+
Input Text id:passwordConfirmation password321
20+
Submit Form id:activate-account-form
21+
Element Text Should Be id:passwordConfirmation.errors Password mismatch
2222

2323
Activate account with too short login
24-
Input Text id=login a
25-
Submit Form id=activate-account-form
26-
Element Text Should Be id=login.errors Value is less than allowable minimum of 2 characters
24+
Input Text id:login a
25+
Submit Form id:activate-account-form
26+
Element Text Should Be id:login.errors Value is less than allowable minimum of 2 characters
2727

2828
Activate account with too long login
29-
Input Text id=login abcde12345fghkl6
30-
Submit Form id=activate-account-form
31-
Element Text Should Be id=login.errors Value is greater than allowable maximum of 15 characters
29+
Input Text id:login abcde12345fghkl6
30+
Submit Form id:activate-account-form
31+
Element Text Should Be id:login.errors Value is greater than allowable maximum of 15 characters
3232

3333
Activate account with forbidden characters in login
34-
Input Text id=login 't@$t'
35-
Submit Form id=activate-account-form
36-
Element Text Should Be id=login.errors Login must consist only latin letters, digits, dot, hyphen or underscore
34+
Input Text id:login 't@$t'
35+
Submit Form id:activate-account-form
36+
Element Text Should Be id:login.errors Login must consist only latin letters, digits, dot, hyphen or underscore
3737

3838
Activate account with existing login
39-
Input Text id=login coder
40-
Submit Form id=activate-account-form
41-
Element Text Should Be id=login.errors Login already exists
39+
Input Text id:login coder
40+
Submit Form id:activate-account-form
41+
Element Text Should Be id:login.errors Login already exists
4242

4343
Activate account with repetition of the special characters in login
4444
[Template] Login should not contain repeated special characters
@@ -50,55 +50,55 @@ Activate account with repetition of the special characters in login
5050

5151
Activate account with too long name
5252
${letter}= Set Variable j
53-
Input Text id=name ${letter * 101}
54-
Submit Form id=activate-account-form
55-
Element Text Should Be id=name.errors Value is greater than allowable maximum of 100 characters
53+
Input Text id:name ${letter * 101}
54+
Submit Form id:activate-account-form
55+
Element Text Should Be id:name.errors Value is greater than allowable maximum of 100 characters
5656

5757
Activate account with with forbidden characters in name
58-
Input Text id=name M@st3r_
59-
Submit Form id=activate-account-form
60-
Element Text Should Be id=name.errors Name must consist only letters, hyphen or spaces
58+
Input Text id:name M@st3r_
59+
Submit Form id:activate-account-form
60+
Element Text Should Be id:name.errors Name must consist only letters, hyphen or spaces
6161

6262
Activate account with name that starts with hyphen
63-
Input Text id=name -test
64-
Submit Form id=activate-account-form
65-
Element Text Should Be id=name.errors Value must not start or end with hyphen
63+
Input Text id:name -test
64+
Submit Form id:activate-account-form
65+
Element Text Should Be id:name.errors Value must not start or end with hyphen
6666

6767
Activate account with name that ends with hyphen
68-
Input Text id=name test-
69-
Submit Form id=activate-account-form
70-
Element Text Should Be id=name.errors Value must not start or end with hyphen
68+
Input Text id:name test-
69+
Submit Form id:activate-account-form
70+
Element Text Should Be id:name.errors Value must not start or end with hyphen
7171

7272
Activate account with too short password
73-
Input Text id=password 123
74-
Submit Form id=activate-account-form
75-
Element Text Should Be id=password.errors Value is less than allowable minimum of 4 characters
73+
Input Text id:password 123
74+
Submit Form id:activate-account-form
75+
Element Text Should Be id:password.errors Value is less than allowable minimum of 4 characters
7676

7777
Activate account with too long password
7878
${letter}= Set Variable j
79-
Input Text id=password ${letter * 73}
80-
Submit Form id=activate-account-form
81-
Element Text Should Be id=password.errors Value is greater than allowable maximum of 72 characters
79+
Input Text id:password ${letter * 73}
80+
Submit Form id:activate-account-form
81+
Element Text Should Be id:password.errors Value is greater than allowable maximum of 72 characters
8282

8383
Activate account with too short activation key
84-
Input Text id=activationKey 12345
85-
Submit Form id=activate-account-form
86-
Element Text Should Be id=activationKey.errors Value length must be equal to 10 characters
84+
Input Text id:activationKey 12345
85+
Submit Form id:activate-account-form
86+
Element Text Should Be id:activationKey.errors Value length must be equal to 10 characters
8787

8888
Activate account with too long activation key
89-
Input Text id=activationKey 1234567890123
90-
Submit Form id=activate-account-form
91-
Element Text Should Be id=activationKey.errors Value length must be equal to 10 characters
89+
Input Text id:activationKey 1234567890123
90+
Submit Form id:activate-account-form
91+
Element Text Should Be id:activationKey.errors Value length must be equal to 10 characters
9292

9393
Activate account with forbidden characters in activation key
94-
Input Text id=activationKey A123=+TEST
95-
Submit Form id=activate-account-form
96-
Element Text Should Be id=activationKey.errors Key must consist only latin letters in lower case or digits
94+
Input Text id:activationKey A123=+TEST
95+
Submit Form id:activate-account-form
96+
Element Text Should Be id:activationKey.errors Key must consist only latin letters in lower case or digits
9797

9898
Activate account with wrong activation key
99-
Input Text id=activationKey 1112223334
100-
Submit Form id=activate-account-form
101-
Element Text Should Be id=activationKey.errors Invalid activation key
99+
Input Text id:activationKey 1112223334
100+
Submit Form id:activate-account-form
101+
Element Text Should Be id:activationKey.errors Invalid activation key
102102

103103
*** Keywords ***
104104
Before Test Suite
@@ -114,6 +114,6 @@ Disable Client Validation
114114
Login should not contain repeated special characters
115115
[Arguments] ${login}
116116
Disable Client Validation
117-
Input Text id=login ${login}
118-
Submit Form id=activate-account-form
119-
Element Text Should Be id=login.errors Login must not contain repetition of hyphen, dot or underscore
117+
Input Text id:login ${login}
118+
Submit Form id:activate-account-form
119+
Element Text Should Be id:login.errors Login must not contain repetition of hyphen, dot or underscore

‎src/test/robotframework/account/authentication/logic.robot

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,19 +7,19 @@ Force Tags account authentication logic
77

88
*** Test Cases ***
99
Successful authentication
10-
Input Text id=login coder
11-
Input Text id=password test
12-
Submit Form id=auth-account-form
10+
Input Text id:login coder
11+
Input Text id:password test
12+
Submit Form id:auth-account-form
1313
Location Should Be ${SITE_URL}/
14-
Page Should Contain Link link=Test Suite
15-
Page Should Contain Button value=Sign out
14+
Page Should Contain Link link:Test Suite
15+
Page Should Contain Button value:Sign out
1616

1717
Log out
1818
Go To ${SITE_URL}/account/auth
19-
Submit Form id=logout-form
19+
Submit Form id:logout-form
2020
Location Should Be ${SITE_URL}/
21-
Page Should Contain Link link=Sign in
22-
Page Should Contain Link link=Register
21+
Page Should Contain Link link:Sign in
22+
Page Should Contain Link link:Register
2323

2424
*** Keywords ***
2525
Before Test Suite

‎src/test/robotframework/account/authentication/misc-user.robot

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Force Tags account authentication misc
1010
*** Test Cases ***
1111
User cannot authenticate again
1212
Page Should Contain You have already authenticated
13-
Page Should Not Contain Element id=auth-account-form
13+
Page Should Not Contain Element id:auth-account-form
1414

1515
*** Keywords ***
1616
Before Test Suite

‎src/test/robotframework/account/authentication/validation.robot

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,16 @@ Force Tags account authentication validation
99
*** Test Cases ***
1010
Authenticate with empty credentials
1111
[Setup] Disable Client Validation
12-
Input Text id=login ${EMPTY}
13-
Input Text id=password ${EMPTY}
14-
Submit Form id=auth-account-form
15-
Element Text Should Be id=form.errors Invalid login or password
12+
Input Text id:login ${EMPTY}
13+
Input Text id:password ${EMPTY}
14+
Submit Form id:auth-account-form
15+
Element Text Should Be id:form.errors Invalid login or password
1616

1717
Authenticate with invalid credentials
18-
Input Text id=login test
19-
Input Text id=password test
20-
Submit Form id=auth-account-form
21-
Element Text Should Be id=form.errors Invalid login or password
18+
Input Text id:login test
19+
Input Text id:password test
20+
Submit Form id:auth-account-form
21+
Element Text Should Be id:form.errors Invalid login or password
2222

2323
*** Keywords ***
2424
Before Test Suite

‎src/test/robotframework/account/registration/logic.robot

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ Force Tags account registration logic
99

1010
*** Test Cases ***
1111
After account creation an e-mail with activation link should be send
12-
Input Text id=email coder@rock.home
13-
Submit Form id=register-account-form
14-
Element Text Should Be id=msg-success Instructions to finish registration have been sent to your e-mail
12+
Input Text id:email coder@rock.home
13+
Submit Form id:register-account-form
14+
Element Text Should Be id:msg-success Instructions to finish registration have been sent to your e-mail
1515
# check that e-mail has been sent by querying Wiremock. See http://wiremock.org/docs/verifying/
1616
Create Session mailserver ${MOCK_SERVER}
1717
${searchQuery}= Set Variable { "method": "POST", "url": "/mailgun/send-message" }

‎src/test/robotframework/account/registration/misc-anonymous.robot

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ Force Tags account registration misc
88

99
*** Test Cases ***
1010
Email should be striped from leading and trailing spaces
11-
Input Text id=email ${SPACE * 2}test${SPACE * 2}
12-
Submit Form id=register-account-form
13-
Emailfield Value Should Be id=email test
11+
Input Text id:email ${SPACE * 2}test${SPACE * 2}
12+
Submit Form id:register-account-form
13+
Emailfield Value Should Be id:email test
1414

1515
*** Keywords ***
1616
Before Test Suite

‎src/test/robotframework/account/registration/misc-user.robot

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Force Tags account registration misc
1010
*** Test Cases ***
1111
User cannot register account again
1212
Page Should Contain You have already registered
13-
Page Should Not Contain Element id=register-account-form
13+
Page Should Not Contain Element id:register-account-form
1414

1515
*** Keywords ***
1616
Before Test Suite

0 commit comments

Comments
 (0)