Skip to content

Commit 9efb759

Browse files
committed
refactor(RequireImageOrImageUrl): move validatior with its implementation to ru.mystamps.web.feature.series package.
Addressed to #927 No functional changes.
1 parent 4b0b51f commit 9efb759

File tree

6 files changed

+6
-9
lines changed

6 files changed

+6
-9
lines changed

src/main/java/ru/mystamps/web/feature/series/AddImageForm.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
import ru.mystamps.web.support.beanvalidation.MaxFileSize.Unit;
3535
import ru.mystamps.web.support.beanvalidation.NotEmptyFile;
3636
import ru.mystamps.web.support.beanvalidation.NotEmptyFilename;
37-
import ru.mystamps.web.support.beanvalidation.RequireImageOrImageUrl;
3837

3938
import static ru.mystamps.web.validation.ValidationRules.MAX_IMAGE_SIZE;
4039

src/main/java/ru/mystamps/web/feature/series/AddSeriesForm.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
import ru.mystamps.web.support.beanvalidation.NotEmptyFilename;
4747
import ru.mystamps.web.support.beanvalidation.NotNullIfFirstField;
4848
import ru.mystamps.web.support.beanvalidation.Price;
49-
import ru.mystamps.web.support.beanvalidation.RequireImageOrImageUrl;
5049

5150
import static ru.mystamps.web.validation.ValidationRules.MAX_DAYS_IN_MONTH;
5251
import static ru.mystamps.web.validation.ValidationRules.MAX_IMAGE_SIZE;

src/main/java/ru/mystamps/web/support/beanvalidation/RequireImageOrImageUrl.java renamed to src/main/java/ru/mystamps/web/feature/series/RequireImageOrImageUrl.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* along with this program; if not, write to the Free Software
1616
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
1717
*/
18-
package ru.mystamps.web.support.beanvalidation;
18+
package ru.mystamps.web.feature.series;
1919

2020
import java.lang.annotation.Documented;
2121
import java.lang.annotation.Retention;
@@ -39,8 +39,7 @@
3939
@Constraint(validatedBy = RequireImageOrImageUrlValidator.class)
4040
@Documented
4141
public @interface RequireImageOrImageUrl {
42-
// CheckStyle: ignore LineLength for next 1 line
43-
String message() default "{ru.mystamps.web.support.beanvalidation.RequireImageOrImageUrl.message}";
42+
String message() default "{ru.mystamps.web.feature.series.RequireImageOrImageUrl.message}";
4443
Class<?>[] groups() default {};
4544
Class<? extends Payload>[] payload() default {};
4645
}

src/main/java/ru/mystamps/web/support/beanvalidation/RequireImageOrImageUrlValidator.java renamed to src/main/java/ru/mystamps/web/feature/series/RequireImageOrImageUrlValidator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@
1515
* along with this program; if not, write to the Free Software
1616
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
1717
*/
18-
package ru.mystamps.web.support.beanvalidation;
18+
package ru.mystamps.web.feature.series;
1919

2020
import javax.validation.ConstraintValidator;
2121
import javax.validation.ConstraintValidatorContext;
2222

23-
import ru.mystamps.web.feature.series.HasImageOrImageUrl;
23+
import ru.mystamps.web.support.beanvalidation.ConstraintViolationUtils;
2424

2525
/**
2626
* Implementation of the {@link RequireImageOrImageUrl} validator.

src/main/resources/ru/mystamps/i18n/ValidationMessages.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,14 @@ ru.mystamps.web.support.beanvalidation.NotNullIfFirstField.message = Field '{sec
1818
ru.mystamps.web.support.beanvalidation.Price.message = Invalid value
1919
ru.mystamps.web.support.beanvalidation.ImageFile.message = Cannot detect file type. Must be image in JPEG or PNG format
2020
ru.mystamps.web.support.beanvalidation.MaxFileSize.message = File size must be not greater than {value} ${unit.name()}
21-
ru.mystamps.web.support.beanvalidation.RequireImageOrImageUrl.message = Image or image URL must be specified
2221

2322
ru.mystamps.web.feature.category.UniqueCategoryName.message = Category already exists
2423
ru.mystamps.web.feature.category.UniqueCategorySlug.message = Category with similar name already exists
2524
ru.mystamps.web.feature.collection.MaxNumberOfStamps.message = Number of stamps must be less than or equal to a stamps quantity in the series
2625
ru.mystamps.web.feature.country.UniqueCountryName.message = Country already exists
2726
ru.mystamps.web.feature.country.UniqueCountrySlug.message = Country with similar name already exists
2827
ru.mystamps.web.feature.series.ReleaseDateIsNotInFuture.message = Release date must not be in future
28+
ru.mystamps.web.feature.series.RequireImageOrImageUrl.message = Image or image URL must be specified
2929

3030
ru.mystamps.web.service.dto.DownloadResult.INVALID_URL = Invalid URL
3131
ru.mystamps.web.service.dto.DownloadResult.INVALID_REDIRECT = URL must not redirect to another address

src/main/resources/ru/mystamps/i18n/ValidationMessages_ru.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,14 @@ ru.mystamps.web.support.beanvalidation.NotNullIfFirstField.message = Поле '{
1818
ru.mystamps.web.support.beanvalidation.Price.message = Некорректное значение
1919
ru.mystamps.web.support.beanvalidation.ImageFile.message = Не удалось определить тип файла. Должен быть изображением в формате JPEG или PNG
2020
ru.mystamps.web.support.beanvalidation.MaxFileSize.message = Размер файла должен быть не более {value} ${unit.name().equals('Mbytes') ? 'Мбайт' : unit.name().equals('Kbytes') ? 'Кбайт' : 'байт'}
21-
ru.mystamps.web.support.beanvalidation.RequireImageOrImageUrl.message = Необходимо выбрать изображение либо указать ссылку на него
2221

2322
ru.mystamps.web.feature.category.UniqueCategoryName.message = Категория уже есть в базе
2423
ru.mystamps.web.feature.category.UniqueCategorySlug.message = Категория с похожим названием уже есть в базе
2524
ru.mystamps.web.feature.collection.MaxNumberOfStamps.message = Количество марок должно быть меньше либо равно количеству марок в серии
2625
ru.mystamps.web.feature.country.UniqueCountryName.message = Страна уже есть в базе
2726
ru.mystamps.web.feature.country.UniqueCountrySlug.message = Страна с похожим названием уже есть в базе
2827
ru.mystamps.web.feature.series.ReleaseDateIsNotInFuture.message = Дата выпуска не может быть в будущем
28+
ru.mystamps.web.feature.series.RequireImageOrImageUrl.message = Необходимо выбрать изображение либо указать ссылку на него
2929

3030
ru.mystamps.web.service.dto.DownloadResult.INVALID_URL = Неправильный URL
3131
ru.mystamps.web.service.dto.DownloadResult.INVALID_REDIRECT = URL не должен перенаправлять на другой адрес

0 commit comments

Comments
 (0)