Skip to content

Commit 92ff7df

Browse files
committed
MaxNumberOfStamps: move validation with its implementation to ru.mystamps.web.feature.collection package.
Addressed to #927 No functional changes.
1 parent 4433b2f commit 92ff7df

File tree

5 files changed

+6
-7
lines changed

5 files changed

+6
-7
lines changed

src/main/java/ru/mystamps/web/feature/collection/AddToCollectionForm.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import lombok.Setter;
2727

2828
import ru.mystamps.web.dao.dto.Currency;
29-
import ru.mystamps.web.support.beanvalidation.MaxNumberOfStamps;
3029

3130
import static ru.mystamps.web.validation.ValidationRules.MIN_STAMPS_IN_SERIES;
3231

src/main/java/ru/mystamps/web/support/beanvalidation/MaxNumberOfStamps.java renamed to src/main/java/ru/mystamps/web/feature/collection/MaxNumberOfStamps.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* along with this program; if not, write to the Free Software
1616
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
1717
*/
18-
package ru.mystamps.web.support.beanvalidation;
18+
package ru.mystamps.web.feature.collection;
1919

2020
import java.lang.annotation.Documented;
2121
import java.lang.annotation.Retention;
@@ -36,7 +36,7 @@
3636
@Constraint(validatedBy = MaxNumberOfStampsValidator.class)
3737
@Documented
3838
public @interface MaxNumberOfStamps {
39-
String message() default "{ru.mystamps.web.support.beanvalidation.MaxNumberOfStamps.message}";
39+
String message() default "{ru.mystamps.web.feature.collection.MaxNumberOfStamps.message}";
4040
Class<?>[] groups() default {};
4141
Class<? extends Payload>[] payload() default {};
4242
}

src/main/java/ru/mystamps/web/support/beanvalidation/MaxNumberOfStampsValidator.java renamed to src/main/java/ru/mystamps/web/feature/collection/MaxNumberOfStampsValidator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@
1515
* along with this program; if not, write to the Free Software
1616
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
1717
*/
18-
package ru.mystamps.web.support.beanvalidation;
18+
package ru.mystamps.web.feature.collection;
1919

2020
import javax.validation.ConstraintValidator;
2121
import javax.validation.ConstraintValidatorContext;
2222

2323
import lombok.RequiredArgsConstructor;
2424

25-
import ru.mystamps.web.feature.collection.AddToCollectionDto;
2625
import ru.mystamps.web.service.SeriesService;
26+
import ru.mystamps.web.support.beanvalidation.ConstraintViolationUtils;
2727

2828
/**
2929
* Implementation of the {@link MaxNumberOfStamps} validator.

src/main/resources/ru/mystamps/i18n/ValidationMessages.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ ru.mystamps.web.support.beanvalidation.Price.message = Invalid value
2020
ru.mystamps.web.support.beanvalidation.ImageFile.message = Cannot detect file type. Must be image in JPEG or PNG format
2121
ru.mystamps.web.support.beanvalidation.MaxFileSize.message = File size must be not greater than {value} ${unit.name()}
2222
ru.mystamps.web.support.beanvalidation.RequireImageOrImageUrl.message = Image or image URL must be specified
23-
ru.mystamps.web.support.beanvalidation.MaxNumberOfStamps.message = Number of stamps must be less than or equal to a stamps quantity in the series
2423

2524
ru.mystamps.web.feature.category.UniqueCategoryName.message = Category already exists
2625
ru.mystamps.web.feature.category.UniqueCategorySlug.message = Category with similar name already exists
26+
ru.mystamps.web.feature.collection.MaxNumberOfStamps.message = Number of stamps must be less than or equal to a stamps quantity in the series
2727
ru.mystamps.web.feature.country.UniqueCountryName.message = Country already exists
2828
ru.mystamps.web.feature.country.UniqueCountrySlug.message = Country with similar name already exists
2929

src/main/resources/ru/mystamps/i18n/ValidationMessages_ru.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ ru.mystamps.web.support.beanvalidation.Price.message = Некорректное
2020
ru.mystamps.web.support.beanvalidation.ImageFile.message = Не удалось определить тип файла. Должен быть изображением в формате JPEG или PNG
2121
ru.mystamps.web.support.beanvalidation.MaxFileSize.message = Размер файла должен быть не более {value} ${unit.name().equals('Mbytes') ? 'Мбайт' : unit.name().equals('Kbytes') ? 'Кбайт' : 'байт'}
2222
ru.mystamps.web.support.beanvalidation.RequireImageOrImageUrl.message = Необходимо выбрать изображение либо указать ссылку на него
23-
ru.mystamps.web.support.beanvalidation.MaxNumberOfStamps.message = Количество марок должно быть меньше либо равно количеству марок в серии
2423

2524
ru.mystamps.web.feature.category.UniqueCategoryName.message = Категория уже есть в базе
2625
ru.mystamps.web.feature.category.UniqueCategorySlug.message = Категория с похожим названием уже есть в базе
26+
ru.mystamps.web.feature.collection.MaxNumberOfStamps.message = Количество марок должно быть меньше либо равно количеству марок в серии
2727
ru.mystamps.web.feature.country.UniqueCountryName.message = Страна уже есть в базе
2828
ru.mystamps.web.feature.country.UniqueCountrySlug.message = Страна с похожим названием уже есть в базе
2929

0 commit comments

Comments
 (0)