Integration tests: remove checkServerResponseCode() check.

I don't want to port it to Robot Framework because
a) it will be hard
b) now I don't think that this check was so useful

Author: php-coder

src/test/java/ru/mystamps/web/tests/cases/WhenAdminAddCategory.java

@@ -64,12 +64,6 @@ public void shouldHaveStandardStructure() {
 		checkStandardStructure();
 	}
 
-	@Override
-	protected void checkServerResponseCode() {
-		// Ignore this check because server always returns 403 for anonymous user and our test suite
-		// lack ability to check response code after authentication.
-	}
-	
 	@Override
 	protected void shouldHaveUserBar() {
 		// Ignore this check because when user authenticated there is no links for login/register.

src/test/java/ru/mystamps/web/tests/cases/WhenAdminAddCountry.java

@@ -64,12 +64,6 @@ public void shouldHaveStandardStructure() {
 		checkStandardStructure();
 	}
 
-	@Override
-	protected void checkServerResponseCode() {
-		// Ignore this check because server always returns 403 for anonymous user and our test suite
-		// lack ability to check response code after authentication.
-	}
-	
 	@Override
 	protected void shouldHaveUserBar() {
 		// Ignore this check because when user authenticated there is no links for login/register.

src/test/java/ru/mystamps/web/tests/cases/WhenAdminAddSeries.java

@@ -448,12 +448,6 @@ public Object[][] getInvalidCatalogPrices() {
 		};
 	}
 
-	@Override
-	protected void checkServerResponseCode() {
-		// Ignore this check because server always returns 403 for anonymous user and our test suite
-		// lack ability to check response code after authentication.
-	}
-	
 	@Override
 	protected void shouldHaveUserBar() {
 		// Ignore this check because when user authenticated there is no links for login/register.

src/test/java/ru/mystamps/web/tests/cases/WhenAnonymousUserAddCategory.java

@@ -17,8 +17,6 @@
  */
 package ru.mystamps.web.tests.cases;
 
-import java.net.HttpURLConnection;
-
 import org.testng.annotations.BeforeClass;
 import org.testng.annotations.Test;
 
@@ -34,7 +32,6 @@ public class WhenAnonymousUserAddCategory extends WhenAnyUserAtAnyPage<Unauthori
 	public WhenAnonymousUserAddCategory() {
 		super(UnauthorizedErrorPage.class);
 		hasTitleWithoutStandardPrefix(tr("t_403_title"));
-		hasResponseServerCode(HttpURLConnection.HTTP_FORBIDDEN);
 	}
 
 	@BeforeClass

src/test/java/ru/mystamps/web/tests/cases/WhenAnonymousUserAddCountry.java

@@ -17,8 +17,6 @@
  */
 package ru.mystamps.web.tests.cases;
 
-import java.net.HttpURLConnection;
-
 import org.testng.annotations.BeforeClass;
 import org.testng.annotations.Test;
 
@@ -35,7 +33,6 @@ public class WhenAnonymousUserAddCountry extends WhenAnyUserAtAnyPage<Unauthoriz
 	public WhenAnonymousUserAddCountry() {
 		super(UnauthorizedErrorPage.class);
 		hasTitleWithoutStandardPrefix(tr("t_403_title"));
-		hasResponseServerCode(HttpURLConnection.HTTP_FORBIDDEN);
 	}
 
 	@BeforeClass

src/test/java/ru/mystamps/web/tests/cases/WhenAnonymousUserAddSeries.java

@@ -17,8 +17,6 @@
  */
 package ru.mystamps.web.tests.cases;
 
-import java.net.HttpURLConnection;
-
 import org.testng.annotations.BeforeClass;
 import org.testng.annotations.Test;
 
@@ -35,7 +33,6 @@ public class WhenAnonymousUserAddSeries extends WhenAnyUserAtAnyPage<Unauthorize
 	public WhenAnonymousUserAddSeries() {
 		super(UnauthorizedErrorPage.class);
 		hasTitleWithoutStandardPrefix(tr("t_403_title"));
-		hasResponseServerCode(HttpURLConnection.HTTP_FORBIDDEN);
 	}
 
 	@BeforeClass

src/test/java/ru/mystamps/web/tests/cases/WhenAnonymousUserAtForbiddenPage.java

@@ -17,8 +17,6 @@
  */
 package ru.mystamps.web.tests.cases;
 
-import java.net.HttpURLConnection;
-
 import org.testng.annotations.BeforeClass;
 import org.testng.annotations.Test;
 
@@ -36,7 +34,6 @@ public class WhenAnonymousUserAtForbiddenPage
 	public WhenAnonymousUserAtForbiddenPage() {
 		super(ForbiddenErrorPage.class);
 		hasTitleWithoutStandardPrefix(tr("t_403_title"));
-		hasResponseServerCode(HttpURLConnection.HTTP_FORBIDDEN);
 	}
 
 	@BeforeClass

src/test/java/ru/mystamps/web/tests/cases/WhenAnonymousUserOpenNotExistingCategoryPage.java

@@ -17,8 +17,6 @@
  */
 package ru.mystamps.web.tests.cases;
 
-import java.net.HttpURLConnection;
-
 import org.testng.annotations.Test;
 
 import ru.mystamps.web.Url;
@@ -34,7 +32,6 @@ public class WhenAnonymousUserOpenNotExistingCategoryPage
 	public WhenAnonymousUserOpenNotExistingCategoryPage() {
 		super(NotFoundErrorPage.class);
 		hasTitleWithoutStandardPrefix(tr("t_404_title"));
-		hasResponseServerCode(HttpURLConnection.HTTP_NOT_FOUND);
 	}
 
 	@Test(groups = "logic")

src/test/java/ru/mystamps/web/tests/cases/WhenAnonymousUserOpenNotExistingCollectionPage.java

@@ -17,8 +17,6 @@
  */
 package ru.mystamps.web.tests.cases;
 
-import java.net.HttpURLConnection;
-
 import org.testng.annotations.Test;
 
 import ru.mystamps.web.Url;
@@ -34,7 +32,6 @@ public class WhenAnonymousUserOpenNotExistingCollectionPage
 	public WhenAnonymousUserOpenNotExistingCollectionPage() {
 		super(NotFoundErrorPage.class);
 		hasTitleWithoutStandardPrefix(tr("t_404_title"));
-		hasResponseServerCode(HttpURLConnection.HTTP_NOT_FOUND);
 	}
 
 	@Test(groups = "logic")

src/test/java/ru/mystamps/web/tests/cases/WhenAnonymousUserOpenNotExistingCountryPage.java

@@ -17,8 +17,6 @@
  */
 package ru.mystamps.web.tests.cases;
 
-import java.net.HttpURLConnection;
-
 import static org.fest.assertions.api.Assertions.assertThat;
 
 import org.testng.annotations.Test;
@@ -34,7 +32,6 @@ public class WhenAnonymousUserOpenNotExistingCountryPage
 	public WhenAnonymousUserOpenNotExistingCountryPage() {
 		super(NotFoundErrorPage.class);
 		hasTitleWithoutStandardPrefix(tr("t_404_title"));
-		hasResponseServerCode(HttpURLConnection.HTTP_NOT_FOUND);
 	}
 
 	@Test(groups = "logic")

src/test/java/ru/mystamps/web/tests/cases/WhenAnonymousUserOpenNotExistingPage.java

@@ -19,8 +19,6 @@
 
 import static org.fest.assertions.api.Assertions.assertThat;
 
-import java.net.HttpURLConnection;
-
 import org.testng.annotations.BeforeClass;
 import org.testng.annotations.Test;
 
@@ -33,7 +31,6 @@ public class WhenAnonymousUserOpenNotExistingPage extends WhenAnyUserAtAnyPage<N
 	public WhenAnonymousUserOpenNotExistingPage() {
 		super(NotFoundErrorPage.class);
 		hasTitleWithoutStandardPrefix(tr("t_404_title"));
-		hasResponseServerCode(HttpURLConnection.HTTP_NOT_FOUND);
 	}
 
 	@BeforeClass

src/test/java/ru/mystamps/web/tests/cases/WhenAnonymousUserOpenNotExistingSeriesPage.java

@@ -17,8 +17,6 @@
  */
 package ru.mystamps.web.tests.cases;
 
-import java.net.HttpURLConnection;
-
 import static org.fest.assertions.api.Assertions.assertThat;
 
 import org.testng.annotations.Test;
@@ -34,7 +32,6 @@ public class WhenAnonymousUserOpenNotExistingSeriesPage
 	public WhenAnonymousUserOpenNotExistingSeriesPage() {
 		super(NotFoundErrorPage.class);
 		hasTitleWithoutStandardPrefix(tr("t_404_title"));
-		hasResponseServerCode(HttpURLConnection.HTTP_NOT_FOUND);
 	}
 
 	@Test(groups = "logic")

src/test/java/ru/mystamps/web/tests/cases/WhenAnonymousUserOpenTogglzConsole.java

@@ -17,8 +17,6 @@
  */
 package ru.mystamps.web.tests.cases;
 
-import java.net.HttpURLConnection;
-
 import org.testng.annotations.BeforeClass;
 import org.testng.annotations.Test;
 
@@ -34,7 +32,6 @@ public class WhenAnonymousUserOpenTogglzConsole extends WhenAnyUserAtAnyPage<For
 	public WhenAnonymousUserOpenTogglzConsole() {
 		super(ForbiddenErrorPage.class);
 		hasTitleWithoutStandardPrefix(tr("t_403_title"));
-		hasResponseServerCode(HttpURLConnection.HTTP_FORBIDDEN);
 	}
 
 	@BeforeClass

src/test/java/ru/mystamps/web/tests/cases/WhenAnyUserAtAnyPage.java

@@ -17,8 +17,6 @@
  */
 package ru.mystamps.web.tests.cases;
 
-import java.net.HttpURLConnection;
-
 import org.openqa.selenium.support.PageFactory;
 
 import org.springframework.boot.test.context.ConfigFileApplicationContextInitializer;
@@ -52,11 +50,6 @@ abstract class WhenAnyUserAtAnyPage<T extends AbstractPage>
 
 	protected final T page;
 
-	/**
-	 * @see hasResponseServerCode()
-	 */
-	private int serverCode = HttpURLConnection.HTTP_OK;
-	
 	/**
 	 * @see hasTitle()
 	 * @see hasTitleWithoutStandardPrefix()
@@ -73,10 +66,6 @@ abstract class WhenAnyUserAtAnyPage<T extends AbstractPage>
 		page = PageFactory.initElements(WebDriverFactory.getDriver(), pageClass);
 	}
 
-	protected void hasResponseServerCode(int serverCode) {
-		this.serverCode = serverCode;
-	}
-	
 	protected void hasTitle(String title) {
 		this.title = TITLE_PREFIX + title;
 	}
@@ -90,7 +79,6 @@ protected void hasHeader(String header) {
 	}
 
 	protected void checkStandardStructure() {
-		checkServerResponseCode();
 		shouldHaveTitle();
 		shouldHaveLogo();
 		shouldHaveUserBar();
@@ -99,12 +87,6 @@ protected void checkStandardStructure() {
 		shouldHaveFooter();
 	}
 
-	protected void checkServerResponseCode() {
-		assertThat(page.getServerResponseCode())
-			.overridingErrorMessage("Server response code")
-			.isEqualTo(serverCode);
-	}
-	
 	private void shouldHaveTitle() {
 		Validate.validState(
 			title != null,

src/test/java/ru/mystamps/web/tests/cases/WhenUserAddSeries.java

@@ -415,12 +415,6 @@ public Object[][] getInvalidCatalogPrices() {
 		};
 	}
 
-	@Override
-	protected void checkServerResponseCode() {
-		// Ignore this check because server always returns 403 for anonymous user and our test suite
-		// lack ability to check response code after authentication.
-	}
-	
 	@Override
 	protected void shouldHaveUserBar() {
 		// Ignore this check because when user authenticated there is no links for login/register.

src/test/java/ru/mystamps/web/tests/cases/WhenUserOpenTogglzConsole.java

@@ -17,8 +17,6 @@
  */
 package ru.mystamps.web.tests.cases;
 
-import java.net.HttpURLConnection;
-
 import org.testng.annotations.AfterClass;
 import org.testng.annotations.BeforeClass;
 import org.testng.annotations.Test;
@@ -43,7 +41,6 @@ public class WhenUserOpenTogglzConsole extends WhenAnyUserAtAnyPage<ForbiddenErr
 	public WhenUserOpenTogglzConsole() {
 		super(ForbiddenErrorPage.class);
 		hasTitleWithoutStandardPrefix(tr("t_403_title"));
-		hasResponseServerCode(HttpURLConnection.HTTP_FORBIDDEN);
 	}
 
 	@BeforeClass

src/test/java/ru/mystamps/web/tests/page/AbstractPage.java

@@ -17,9 +17,6 @@
  */
 package ru.mystamps.web.tests.page;
 
-import java.io.IOException;
-import java.net.URL;
-import java.net.HttpURLConnection;
 import java.util.List;
 
 import org.openqa.selenium.By;
@@ -59,30 +56,6 @@ public void open(String pageUrl) {
 		driver.get(Url.SITE + pageUrl);
 	}
 
-	/**
-	 * Opens page and returns server response code.
-	 * In case of error returns -1.
-	 */
-	public int getServerResponseCode() {
-		/**
-		 * FIXME: currently we can't get access to server response from Selenium :(
-		 * @see http://code.google.com/p/selenium/issues/detail?id=141
-		 */
-		
-		try {
-			// As workaround, for a while, use HttpUrlConnection
-			// (but it leads to two connection to each page).
-			URL url = new URL(getFullUrl());
-			HttpURLConnection conn = (HttpURLConnection)url.openConnection();
-			return conn.getResponseCode();
-		
-		} catch (IOException ex) {
-			// don't throw exception because it leads to error in tests
-			// instead of failure
-			return -1;
-		}
-	}
-	
 	private String getFullUrl() {
 		return Url.SITE + pageUrl;
 	}