handle surefire

Author: php-coder

Dangerfile

@@ -28,9 +28,9 @@ def print_errors_summary(program, errors, link = '')
 
 	msg = ''
 	if errors == 1
-		msg = "#{program} reports about #{errors} error. Please, fix it."
+		msg = "#{program} reported about #{errors} error. Please, fix it."
 	elsif errors > 0
-		msg = "#{program} reports about #{errors} errors. Please, fix them."
+		msg = "#{program} reported about #{errors} errors. Please, fix them."
 	end
 
 	unless link.empty?
@@ -127,12 +127,12 @@ else
 		errors_cnt = errors.size()
 		error_msgs = errors.join("</li>\n<li>")
 		if errors_cnt == 1
-			fail("license-maven-plugin reports about #{errors_cnt} error:\n"\
+			fail("license-maven-plugin reported about #{errors_cnt} error:\n"\
 				"<ul><li>#{error_msgs}</li></ul>\n"\
 				"Please, fix it by executing `mvn license:format`\n"\
 				"See also: <a href=\"#{link}\">#{link}</a>")
 		elsif errors_cnt > 1
-			fail("license-maven-plugin reports about #{errors_cnt} errors:\n"\
+			fail("license-maven-plugin reported about #{errors_cnt} errors:\n"\
 				"<ul><li>#{error_msgs}</li></ul>\n"\
 				"Please, fix them by executing `mvn license:format`\n"\
 				"See also: <a href=\"#{link}\">#{link}</a>")
@@ -166,12 +166,12 @@ else
 		errors_cnt = errors.size()
 		error_msgs = errors.join("</li>\n<li>")
 		if errors_cnt == 1
-			fail("sortpom-maven-plugin reports about #{errors_cnt} error:\n"\
+			fail("sortpom-maven-plugin reported about #{errors_cnt} error:\n"\
 				"<ul><li>#{error_msgs}</li></ul>\n"\
 				"Please, fix it by executing `mvn sortpom:sort`\n"\
 				"See also: <a href=\"#{link}\">#{link}</a>")
 		elsif errors_cnt > 1
-			fail("sortpom-maven-plugin reports about #{errors_cnt} errors:\n"\
+			fail("sortpom-maven-plugin reported about #{errors_cnt} errors:\n"\
 				"<ul><li>#{error_msgs}</li></ul>\n"\
 				"Please, fix them by executing `mvn sortpom:sort`\n"\
 				"See also: <a href=\"#{link}\">#{link}</a>")
@@ -400,6 +400,50 @@ else
 	end
 end
 
+# Handle `mvn test` reports
+# maven-surefire-plugin generates multiple XML files (one result file per test class).
+#
+# Example:
+# <testsuite name="ru.mystamps.web.service.CronServiceImplTest" time="0.175" tests="7" errors="0" skipped="0" failures="2">
+#   <testcase name="sendDailyStatistics() should prepare report and pass it to mail service" classname="ru.mystamps.web.service.CronServiceImplTest" time="0.107">
+#     <failure message="Condition not satisfied: bla bla bla" type="org.spockframework.runtime.SpockComparisonFailure">
+#       org.spockframework.runtime.SpockComparisonFailure: bla bla bla
+#     </failure>
+#   </testcase>
+# </testsuite>
+#
+test_reports_pattern = 'target/surefire-reports/TEST-*.xml'
+test_reports = Dir.glob(test_reports_pattern)
+if test_reports.empty?
+	warn("Couldn't find #{test_reports_pattern}. maven-surefire-plugin results is unknown")
+else
+	errors_count = 0
+	test_reports.each do |file|
+		doc = Nokogiri::XML(File.open(file))
+		testsuite = doc.xpath('/testsuite').first
+		failures  = testsuite['failures']
+		if failures.to_i == 0
+			next
+		end
+		
+		testsuite.xpath('.//failure').each do |failure|
+			errors_count += 1
+			msg = failure['message']
+			tc  = failure.parent
+			file = tc['classname'].gsub(/\./, '/')
+			path = "src/test/groovy/#{file}.groovy"
+			if File.file?(path)
+				file = path
+			end
+			# TODO: try to findout the test case and use it for highlighting line numbers
+			file = github.html_link(file)
+			testcase = tc['name']
+			fail("maven-surefire-plugin error in #{file}:\nTest case `#{testcase}` fails with message:\n#{msg}")
+		end
+	end
+	print_errors_summary 'maven-surefire-plugin', errors_count, 'https://github.com/php-coder/mystamps/wiki/unit-tests'
+end
+
 # Handle `mvn findbugs:check` results
 findbugs_report = 'target/findbugsXml.xml'
 unless File.file?(findbugs_report)

pom.xml

@@ -436,6 +436,10 @@
 		<commons.lang.version>3.4</commons.lang.version>
 		<compiler.plugin.version>3.6.1</compiler.plugin.version>
 		<coveralls.plugin.version>2.2.0</coveralls.plugin.version>
+		
+		<!-- Disable XML reports by default. Enabled manually by passing -DdisableXmlReport=false in CI environment -->
+		<disableXmlReport>true</disableXmlReport>
+		
 		<enforcer.plugin.version>1.4.1</enforcer.plugin.version>
 		<failsafe.plugin.version>2.19.1</failsafe.plugin.version>
 		<fest.assert.version>2.0M8</fest.assert.version>
@@ -796,7 +800,7 @@
 				<version>${surefire.plugin.version}</version>
 				<configuration>
 					<skipTests>${skipUnitTests}</skipTests>
-					<disableXmlReport>true</disableXmlReport>
+					<disableXmlReport>${disableXmlReport}</disableXmlReport>
 					<!-- Run junit tests only (see #SUREFIRE-377) -->
 					<testNGArtifactName>none:none</testNGArtifactName>
 				</configuration>

src/main/scripts/ci/check-build-and-verify.sh

@@ -53,6 +53,7 @@ if [ "$RUN_ONLY_INTEGRATION_TESTS" = 'no' ]; then
 		-Denforcer.skip=true \
 		-Dmaven.resources.skip=true \
 		-DskipMinify=true \
+		-DdisableXmlReport=false \
 		>test.log 2>&1 || TEST_FAIL=yes
 	# run after tests for getting compiled sources
 	mvn --batch-mode findbugs:check >findbugs.log 2>&1 || FINDBUGS_FAIL=yes