Skip to content

Commit 818e92b

Browse files
committed
ImageService(save): explicitly specify locale when calling String.toUpperCase().
Reported by PMD: "When doing String.toLowerCase()/toUpperCase() conversions, use Locales to avoids problems with languages that have unusual conventions, i.e. Turkish." No functional changes.
1 parent b982f2c commit 818e92b

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/main/java/ru/mystamps/web/service/ImageService.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
package ru.mystamps.web.service;
1919

2020
import java.io.IOException;
21+
import java.util.Locale;
2122

2223
import javax.inject.Inject;
2324

@@ -57,7 +58,7 @@ String save(final MultipartFile file) {
5758
);
5859

5960
final Image image = new Image();
60-
image.setType(Image.Type.valueOf(extension.toUpperCase()));
61+
image.setType(Image.Type.valueOf(extension.toUpperCase(Locale.US)));
6162

6263
try {
6364
image.setData(file.getBytes());

0 commit comments

Comments
 (0)