Extracted method: SiteServiceTest.getAuthFailedType() -> TestObjects.createAuthFailedActivityType()

No functional changes.

Author: php-coder

src/test/java/ru/mystamps/web/service/SiteServiceTest.java

@@ -233,7 +233,8 @@ public void logAboutAbsentPageShouldPassEmptyStringToDaoForUnknownUserAgent() {
 
 	@Test
 	public void logAboutFailedAuthenticationShouldCallDao() {
-		when(suspiciousActivityTypeDao.findByName(anyString())).thenReturn(getAuthFailedType());
+		when(suspiciousActivityTypeDao.findByName(anyString()))
+			.thenReturn(TestObjects.createAuthFailedActivityType());
 
 		service.logAboutFailedAuthentication(TEST_PAGE, null, null, null, null);
 
@@ -249,7 +250,7 @@ public void logAboutFailedAuthenticationShouldThrowExceptionWhenActivityTypeNotF
 
 	@Test
 	public void logAboutFailedAuthenticationShouldPassActivityTypeToDao() {
-		SuspiciousActivityType expectedType = getAuthFailedType();
+		SuspiciousActivityType expectedType = TestObjects.createAuthFailedActivityType();
 		when(suspiciousActivityTypeDao.findByName(anyString())).thenReturn(expectedType);
 
 		service.logAboutFailedAuthentication(TEST_PAGE, null, null, null, null);
@@ -261,7 +262,8 @@ public void logAboutFailedAuthenticationShouldPassActivityTypeToDao() {
 
 	@Test
 	public void logAboutFailedAuthenticationShouldAssignOccuredAtToCurrentDate() {
-		when(suspiciousActivityTypeDao.findByName(anyString())).thenReturn(getAuthFailedType());
+		when(suspiciousActivityTypeDao.findByName(anyString()))
+			.thenReturn(TestObjects.createAuthFailedActivityType());
 
 		service.logAboutFailedAuthentication(TEST_PAGE, null, null, null, null);
 
@@ -272,14 +274,16 @@ public void logAboutFailedAuthenticationShouldAssignOccuredAtToCurrentDate() {
 
 	@Test(expected = IllegalArgumentException.class)
 	public void logAboutFailedAuthenticationShouldThrowExceptionWhenPageIsNull() {
-		when(suspiciousActivityTypeDao.findByName(anyString())).thenReturn(getAuthFailedType());
+		when(suspiciousActivityTypeDao.findByName(anyString()))
+			.thenReturn(TestObjects.createAuthFailedActivityType());
 
 		service.logAboutFailedAuthentication(null, null, null, null, null);
 	}
 
 	@Test
 	public void logAboutFailedAuthenticationShouldPassPageToDao() {
-		when(suspiciousActivityTypeDao.findByName(anyString())).thenReturn(getAuthFailedType());
+		when(suspiciousActivityTypeDao.findByName(anyString()))
+			.thenReturn(TestObjects.createAuthFailedActivityType());
 
 		service.logAboutFailedAuthentication(TEST_PAGE, null, null, null, null);
 
@@ -290,7 +294,8 @@ public void logAboutFailedAuthenticationShouldPassPageToDao() {
 
 	@Test
 	public void logAboutFailedAuthenticationShouldPassNullToDaoForUnknownUser() {
-		when(suspiciousActivityTypeDao.findByName(anyString())).thenReturn(getAuthFailedType());
+		when(suspiciousActivityTypeDao.findByName(anyString()))
+			.thenReturn(TestObjects.createAuthFailedActivityType());
 
 		service.logAboutFailedAuthentication(TEST_PAGE, null, null, null, null);
 
@@ -302,7 +307,8 @@ public void logAboutFailedAuthenticationShouldPassNullToDaoForUnknownUser() {
 	@Test
 	public void logAboutFailedAuthenticationShouldPassUserToDao() {
 		User user = getUser();
-		when(suspiciousActivityTypeDao.findByName(anyString())).thenReturn(getAuthFailedType());
+		when(suspiciousActivityTypeDao.findByName(anyString()))
+			.thenReturn(TestObjects.createAuthFailedActivityType());
 
 		service.logAboutFailedAuthentication(TEST_PAGE, user, null, null, null);
 
@@ -313,7 +319,8 @@ public void logAboutFailedAuthenticationShouldPassUserToDao() {
 
 	@Test
 	public void logAboutFailedAuthenticationShouldPassIpToDao() {
-		when(suspiciousActivityTypeDao.findByName(anyString())).thenReturn(getAuthFailedType());
+		when(suspiciousActivityTypeDao.findByName(anyString()))
+			.thenReturn(TestObjects.createAuthFailedActivityType());
 
 		service.logAboutFailedAuthentication(TEST_PAGE, null, TEST_IP, null, null);
 
@@ -324,7 +331,8 @@ public void logAboutFailedAuthenticationShouldPassIpToDao() {
 
 	@Test
 	public void logAboutFailedAuthenticationShouldPassEmptyStringToDaoForUnknownIp() {
-		when(suspiciousActivityTypeDao.findByName(anyString())).thenReturn(getAuthFailedType());
+		when(suspiciousActivityTypeDao.findByName(anyString()))
+			.thenReturn(TestObjects.createAuthFailedActivityType());
 
 		service.logAboutFailedAuthentication(TEST_PAGE, null, null, null, null);
 
@@ -335,7 +343,8 @@ public void logAboutFailedAuthenticationShouldPassEmptyStringToDaoForUnknownIp()
 
 	@Test
 	public void logAboutFailedAuthenticationShouldPassRefererToDao() {
-		when(suspiciousActivityTypeDao.findByName(anyString())).thenReturn(getAuthFailedType());
+		when(suspiciousActivityTypeDao.findByName(anyString()))
+			.thenReturn(TestObjects.createAuthFailedActivityType());
 
 		service.logAboutFailedAuthentication(TEST_PAGE, null, null, TEST_REFERER_PAGE, null);
 
@@ -346,7 +355,8 @@ public void logAboutFailedAuthenticationShouldPassRefererToDao() {
 
 	@Test
 	public void logAboutFailedAuthenticationShouldPassEmptyStringToDaoForUnknownReferer() {
-		when(suspiciousActivityTypeDao.findByName(anyString())).thenReturn(getAuthFailedType());
+		when(suspiciousActivityTypeDao.findByName(anyString()))
+			.thenReturn(TestObjects.createAuthFailedActivityType());
 
 		service.logAboutFailedAuthentication(TEST_PAGE, null, null, null, null);
 
@@ -357,7 +367,8 @@ public void logAboutFailedAuthenticationShouldPassEmptyStringToDaoForUnknownRefe
 
 	@Test
 	public void logAboutFailedAuthenticationShouldPassUserAgentToDao() {
-		when(suspiciousActivityTypeDao.findByName(anyString())).thenReturn(getAuthFailedType());
+		when(suspiciousActivityTypeDao.findByName(anyString()))
+			.thenReturn(TestObjects.createAuthFailedActivityType());
 
 		service.logAboutFailedAuthentication(TEST_PAGE, null, null, null, TEST_USER_AGENT);
 
@@ -368,7 +379,8 @@ public void logAboutFailedAuthenticationShouldPassUserAgentToDao() {
 
 	@Test
 	public void logAboutFailedAuthenticationShouldPassEmptyStringToDaoForUnknownUserAgent() {
-		when(suspiciousActivityTypeDao.findByName(anyString())).thenReturn(getAuthFailedType());
+		when(suspiciousActivityTypeDao.findByName(anyString()))
+			.thenReturn(TestObjects.createAuthFailedActivityType());
 
 		service.logAboutFailedAuthentication(TEST_PAGE, null, null, null, null);
 
@@ -377,13 +389,6 @@ public void logAboutFailedAuthenticationShouldPassEmptyStringToDaoForUnknownUser
 		assertThat(activityCaptor.getValue().getUserAgent()).isEmpty();
 	}
 
-	private SuspiciousActivityType getAuthFailedType() {
-		SuspiciousActivityType type = new SuspiciousActivityType();
-		type.setId(2);
-		type.setName("AuthenticationFailed");
-		return type;
-	}
-	
 	private User getUser() {
 		final Integer anyId = 777;
 		User user = new User();

src/test/java/ru/mystamps/web/service/TestObjects.java

@@ -59,4 +59,11 @@ public static SuspiciousActivityType createPageNotFoundActivityType() {
 		return type;
 	}
 
+	public static SuspiciousActivityType createAuthFailedActivityType() {
+		SuspiciousActivityType type = new SuspiciousActivityType();
+		type.setId(2);
+		type.setName("AuthenticationFailed");
+		return type;
+	}
+	
 }