Skip to content

Commit 7a58bc9

Browse files
committed
CollectionDao.markAsModified(): rename argument.
No functional changes.
1 parent b62fe67 commit 7a58bc9

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

src/main/java/ru/mystamps/web/dao/CollectionDao.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public interface CollectionDao {
2828
List<LinkEntityDto> findLastCreated(int quantity);
2929
long countCollectionsOfUsers();
3030
Integer add(AddCollectionDbDto collection);
31-
void markAsModified(Integer updatedBy, Date updatedAt);
31+
void markAsModified(Integer userId, Date updatedAt);
3232
boolean isSeriesInUserCollection(Integer userId, Integer seriesId);
3333
void addSeriesToUserCollection(Integer userId, Integer seriesId);
3434
void removeSeriesFromUserCollection(Integer userId, Integer seriesId);

src/main/java/ru/mystamps/web/dao/impl/JdbcCollectionDao.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,12 +119,13 @@ public Integer add(AddCollectionDbDto collection) {
119119

120120
/**
121121
* @author John Shkarin
122+
* @author Slava Semushin
122123
*/
123124
@Override
124-
public void markAsModified(Integer updatedBy, Date updatedAt) {
125+
public void markAsModified(Integer userId, Date updatedAt) {
125126
Map<String, Object> params = new HashMap<>();
126127
params.put("updated_at", updatedAt);
127-
params.put("updated_by", updatedBy);
128+
params.put("updated_by", userId);
128129

129130
int affected = jdbcTemplate.update(
130131
markAsModifiedSql,

src/test/groovy/ru/mystamps/web/service/CollectionServiceImplTest.groovy

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,8 @@ class CollectionServiceImplTest extends Specification {
127127
return true
128128
})
129129
and:
130-
1 * collectionDao.markAsModified({ Integer updatedBy ->
131-
assert updatedBy == expectedUserId
130+
1 * collectionDao.markAsModified({ Integer userId ->
131+
assert userId == expectedUserId
132132
return true
133133
}, { Date updatedAt ->
134134
assert DateUtils.roughlyEqual(updatedAt, new Date())
@@ -170,8 +170,8 @@ class CollectionServiceImplTest extends Specification {
170170
return true
171171
})
172172
and:
173-
1 * collectionDao.markAsModified({ Integer updatedBy ->
174-
assert updatedBy == expectedUserId
173+
1 * collectionDao.markAsModified({ Integer userId ->
174+
assert userId == expectedUserId
175175
return true
176176
}, { Date updatedAt ->
177177
assert DateUtils.roughlyEqual(updatedAt, new Date())

0 commit comments

Comments
 (0)