Redirects user after sending data to protect from double submission.

/account/register -> /successful/registration
/account/activate -> /successful/activation

Fixed #74

Author: php-coder

src/main/java/ru/mystamps/web/SiteMap.java

@@ -34,6 +34,8 @@ public final class SiteMap {
 	// defined at src/main/resources/spring/DispatcherServletContext.xml
 	public static final String INDEX_PAGE_URL            = "/";
 	public static final String MAINTENANCE_PAGE_URL      = "/site/maintenance";
+	public static final String SUCCESSFUL_REGISTRATION_PAGE_URL = "/successful/registration";
+	public static final String SUCCESSFUL_ACTIVATION_PAGE_URL = "/successful/activation";
 
 	public static final String REGISTRATION_PAGE_URL     = "/account/register";
 	public static final String AUTHENTICATION_PAGE_URL   = "/account/auth";

src/main/java/ru/mystamps/web/controller/ActivateAccountController.java

@@ -38,6 +38,7 @@
 
 import static ru.mystamps.web.SiteMap.ACTIVATE_ACCOUNT_PAGE_URL;
 import static ru.mystamps.web.SiteMap.ACTIVATE_ACCOUNT_PAGE_WITH_KEY_URL;
+import static ru.mystamps.web.SiteMap.SUCCESSFUL_ACTIVATION_PAGE_URL;
 
 @Controller
 public class ActivateAccountController {
@@ -91,7 +92,7 @@ public String processInput(
 			form.getActivationKey()
 		);
 
-		return "account/activation_successful";
+		return "redirect:" + SUCCESSFUL_ACTIVATION_PAGE_URL;
 	}
 
 }

src/main/java/ru/mystamps/web/controller/RegisterAccountController.java

@@ -34,6 +34,7 @@
 import ru.mystamps.web.validation.RegisterAccountValidator;
 
 import static ru.mystamps.web.SiteMap.REGISTRATION_PAGE_URL;
+import static ru.mystamps.web.SiteMap.SUCCESSFUL_REGISTRATION_PAGE_URL;
 
 @Controller
 @RequestMapping(REGISTRATION_PAGE_URL)
@@ -73,8 +74,7 @@ public String processInput(
 
 		userService.addRegistrationRequest(form.getEmail());
 
-		// TODO: do redirect to protect from double submission (#74)
-		return "account/activation_sent";
+		return "redirect:" + SUCCESSFUL_REGISTRATION_PAGE_URL;
 	}
 
 }

src/main/resources/spring/DispatcherServletContext.xml

@@ -32,6 +32,8 @@
 	<mvc:view-controller path="/" view-name="site/index" />
 	<mvc:view-controller path="/site/maintenance" view-name="site/maintenance" />
 	<mvc:view-controller path="/password/restore" view-name="password/restore" />
+	<mvc:view-controller path="/successful/registration" view-name="account/activation_sent" />
+	<mvc:view-controller path="/successful/activation" view-name="account/activation_successful" />
 
 	<import resource="database.xml" />
 

src/test/java/ru/mystamps/web/tests/cases/WhenUserActivateAccount.java

@@ -40,6 +40,7 @@
 
 import static ru.mystamps.web.SiteMap.ACTIVATE_ACCOUNT_PAGE_WITH_KEY_URL;
 import static ru.mystamps.web.SiteMap.AUTHENTICATION_PAGE_URL;
+import static ru.mystamps.web.SiteMap.SUCCESSFUL_ACTIVATION_PAGE_URL;
 
 @RunWith(SpringJUnit4ClassRunner.class)
 @ContextConfiguration(locations = "classpath:spring/TestContext.xml")
@@ -278,6 +279,8 @@ public void afterActivationShouldExistsMessageWithLinkForAuthentication() {
 		page.fillField("activationKey", NOT_ACTIVATED_USER_ACT_KEY);
 		page.submit();
 
+		assertThat(page.getCurrentUrl()).isEqualTo(SUCCESSFUL_ACTIVATION_PAGE_URL);
+		
 		assertThat(page.textPresent(stripHtmlTags(tr("t_activation_successful")))).isTrue();
 
 		assertThat(page.linkHasLabelAndPointsTo("authentication", AUTHENTICATION_PAGE_URL))

src/test/java/ru/mystamps/web/tests/cases/WhenUserRegisterAccount.java

@@ -22,6 +22,7 @@
 
 import static ru.mystamps.web.SiteMap.AUTHENTICATION_PAGE_URL;
 import static ru.mystamps.web.SiteMap.RESTORE_PASSWORD_PAGE_URL;
+import static ru.mystamps.web.SiteMap.SUCCESSFUL_REGISTRATION_PAGE_URL;
 import static ru.mystamps.web.tests.TranslationUtils.tr;
 import static ru.mystamps.web.tests.TranslationUtils.stripHtmlTags;
 import static ru.mystamps.web.validation.ValidationRules.EMAIL_MAX_LENGTH;
@@ -99,7 +100,9 @@ public void emailShouldBeStripedFromLeadingAndTrailingSpaces() {
 	public void successfulMessageShouldBeShownAfterRegistration() {
 		page.fillField("email", "coder@rock.home");
 		page.submit();
-		// TODO: check page url
+		
+		assertThat(page.getCurrentUrl()).isEqualTo(SUCCESSFUL_REGISTRATION_PAGE_URL);
+		
 		assertThat(page.textPresent(tr("t_activation_sent_message"))).isTrue();
 	}