Skip to content

Commit 6e35db1

Browse files
php-coderphp-coder
committed
fix tests with "unstable" tag
1 parent 1336b9b commit 6e35db1

File tree

8 files changed

+27
-41
lines changed

8 files changed

+27
-41
lines changed

‎src/test/robotframework/collection/add-series/logic.robot

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ Force Tags collection series logic
88

99
*** Test Cases ***
1010
Add a series to user's collection
11-
[Tags] unstable
1211
Go To ${SITE_URL}/series/2
1312
Submit Form id=add-series-form
1413
Page Should Contain Link css=[href="/series/2"]

‎src/test/robotframework/collection/estimation/logic.robot

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ Message should be shown when a collection is empty
1313
Element Text Should Be id=empty-collection-msg In this collection is no stamps
1414

1515
Series with its price should be taken into account
16-
[Tags] unstable
1716
Go To ${SITE_URL}/series/1
1817
Input Text id=paid-price 100
1918
Select From List By Value id=paid-currency ${expectedCurrency}
@@ -25,7 +24,6 @@ Series with its price should be taken into account
2524
Table Header Should Contain collection-estimation 100.00 ${expectedCurrency}
2625

2726
Series without price should be shown but not taken into account
28-
[Tags] unstable
2927
Go To ${SITE_URL}/series/2
3028
Submit Form id=add-series-form
3129
Go To ${SITE_URL}/collection/paid/estimation

‎src/test/robotframework/collection/remove-series/logic.robot

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ Force Tags collection series logic
88

99
*** Test Cases ***
1010
Remove a series from user's collection
11-
[Tags] unstable
1211
Go To ${SITE_URL}/series/3
1312
Submit Form id=remove-series-form
1413
Page Should Not Contain Link css=[href="/series/3"]

‎src/test/robotframework/country/creation/logic.robot

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ Force Tags country logic
1010

1111
*** Test Cases ***
1212
Create country with name in English (fill only mandatory fields)
13-
[Tags] unstable
1413
Input Text id=name Germany
1514
Submit Form id=add-country-form
1615
Location Should Be ${SITE_URL}/country/germany

‎src/test/robotframework/selenium.utils.robot

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -32,21 +32,6 @@ Selectize By Value
3232
[Arguments] ${id} ${slug}
3333
Execute Javascript return $('#${id}').selectize()[0].selectize.setValue('${slug}');
3434

35-
Select Country
36-
[Documentation] Select the given value in a select list that is using selectize.js
37-
[Arguments] ${value}
38-
# We can't use "Select From List By Label" because
39-
# 1) it doesn't work with invisible elements (and selectize.js makes field invisible)
40-
# 2) selectize.js dynamically creates list of countries only when we're clicking on the field
41-
Click Element id=country-selectized
42-
${countryOption}= Catenate SEPARATOR=/
43-
... //*[contains(@class, "selectize-control")]
44-
... *[contains(@class, "selectize-dropdown")]
45-
... *[contains(@class, "selectize-dropdown-content")]
46-
... *[contains(@class, "option") and text()="${value}"]
47-
Wait Until Page Contains Element xpath=${countryOption}
48-
Click Element xpath=${countryOption}
49-
5035
Country Field Should Have Option
5136
[Documentation] Verify the selection of the select list that is using selectize.js
5237
[Arguments] ${value}

‎src/test/robotframework/series/creation/logic-admin.robot

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,8 @@ Create series by filling only required fields and providing a URL to image
3030
Page Should Contain Image id=series-image-1
3131

3232
Create series by filling all fields
33-
[Tags] unstable
3433
Select From List By Label id=category Sport
35-
Select Country Italy
34+
Selectize By Value country italy
3635
Input Text id=quantity 3
3736
Unselect Checkbox id=perforated
3837
Choose File id=image ${MAIN_RESOURCE_DIR}${/}test.png

‎src/test/robotframework/series/creation/misc-user.robot

Lines changed: 24 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -21,35 +21,37 @@ Issue year should have options for range from 1840 to the current year
2121
Should Be Equal As Integers ${numberOfYears} ${expectedNumberOfYears}
2222

2323
Catalog numbers should accept valid values
24-
[Tags] unstable
2524
[Template] Valid Catalog Numbers Should Be Accepted
2625
7
2726
7,8
2827
71, 81, 91
2928
1000
3029

3130
Catalog numbers should be stripped from any spaces
32-
[Tags] unstable
33-
Click Element id=add-catalog-numbers-link
34-
Input Text id=michelNumbers ${SPACE * 2}1 , 2${SPACE * 2}
35-
Input Text id=scottNumbers ${SPACE * 2}3 , 4${SPACE * 2}
36-
Input Text id=yvertNumbers ${SPACE * 2}5 , 6${SPACE * 2}
37-
Input Text id=gibbonsNumbers ${SPACE * 2}7 , 8${SPACE * 2}
38-
Input Text id=solovyovNumbers ${SPACE * 2}9 , 10${SPACE * 2}
39-
Input Text id=zagorskiNumbers ${SPACE * 2}11 , 12${SPACE * 2}
40-
Submit Form id=add-series-form
41-
Textfield Value Should Be id=michelNumbers 1,2
42-
Textfield Value Should Be id=scottNumbers 3,4
43-
Textfield Value Should Be id=yvertNumbers 5,6
44-
Textfield Value Should Be id=gibbonsNumbers 7,8
45-
Textfield Value Should Be id=solovyovNumbers 9,10
46-
Textfield Value Should Be id=zagorskiNumbers 11,12
31+
[Setup] Disable Client Validation
32+
Click Element id=add-catalog-numbers-link
33+
Wait Until Element Is Visible id=michelNumbers
34+
Input Text id=michelNumbers ${SPACE * 2}1 , 2${SPACE * 2}
35+
Input Text id=scottNumbers ${SPACE * 2}3 , 4${SPACE * 2}
36+
Input Text id=yvertNumbers ${SPACE * 2}5 , 6${SPACE * 2}
37+
Input Text id=gibbonsNumbers ${SPACE * 2}7 , 8${SPACE * 2}
38+
Input Text id=solovyovNumbers ${SPACE * 2}9 , 10${SPACE * 2}
39+
Input Text id=zagorskiNumbers ${SPACE * 2}11 , 12${SPACE * 2}
40+
Submit Form id=add-series-form
41+
Textfield Value Should Be id=michelNumbers 1,2
42+
Textfield Value Should Be id=scottNumbers 3,4
43+
Textfield Value Should Be id=yvertNumbers 5,6
44+
Textfield Value Should Be id=gibbonsNumbers 7,8
45+
Textfield Value Should Be id=solovyovNumbers 9,10
46+
Textfield Value Should Be id=zagorskiNumbers 11,12
4747

4848
Catalog numbers should ignore duplicate values
49-
[Tags] unstable
5049
Select From List By Label id=category Sport
5150
Input Text id=quantity 2
5251
Choose File id=image ${MAIN_RESOURCE_DIR}${/}test.png
52+
# Workaround for an invalid form when it contains required file input:
53+
# https://github.com/HtmlUnit/htmlunit/issues/76
54+
Remove Element Attribute image required
5355
Click Element id=add-catalog-numbers-link
5456
Input Text id=michelNumbers 104,105,104
5557
Input Text id=scottNumbers 114,115,114
@@ -95,9 +97,14 @@ Before Test Suite
9597
Log In As login=coder password=test
9698
Go To ${SITE_URL}/series/add
9799

100+
Disable Client Validation
101+
Remove Element Attribute quantity required
102+
Remove Element Attribute image required
103+
98104
Valid Catalog Numbers Should Be Accepted
99105
[Arguments] ${catalogNumbers}
100106
Click Element id=add-catalog-numbers-link
107+
Wait Until Element Is Visible id=michelNumbers
101108
Input Text id=michelNumbers ${catalogNumbers}
102109
Input Text id=scottNumbers ${catalogNumbers}
103110
Input Text id=yvertNumbers ${catalogNumbers}

‎src/test/robotframework/series/creation/validation-user.robot

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ Create series with an empty image
3737
Element Text Should Be id=image.errors File must not be empty
3838

3939
Catalog numbers should reject invalid values
40-
[Tags] unstable
4140
[Template] Invalid Catalog Numbers Should Be Rejected
4241
t
4342
t,t
@@ -50,7 +49,6 @@ Catalog numbers should reject invalid values
5049
10000
5150

5251
Catalog price should reject invalid values
53-
[Tags] unstable
5452
[Template] Invalid Catalog Price Should Be Rejected
5553
0
5654
-1
@@ -75,6 +73,7 @@ Invalid Catalog Numbers Should Be Rejected
7573
# invisible (because link is toggling the visibility and when there are
7674
# errors, fields are visible from the begining).
7775
Go To ${SITE_URL}/series/add
76+
Disable Client Validation
7877
Click Element id=add-catalog-numbers-link
7978
# we should wait until all 4 fields with class js-catalogs-info will be
8079
# visible but for simplicity we just check that the last field is visible
@@ -104,6 +103,7 @@ Invalid Catalog Price Should Be Rejected
104103
# invisible (because link is toggling the visibility and when there are
105104
# errors, fields are visible from the begining).
106105
Go To ${SITE_URL}/series/add
106+
Disable Client Validation
107107
Click Element id=add-catalog-numbers-link
108108
# we should wait until all 4 fields with class js-catalogs-info will be
109109
# visible but for simplicity we just check that the last field is visible

0 commit comments

Comments
 (0)