Skip to content

Commit 6794ae2

Browse files
committed
fixes
1 parent 44817f5 commit 6794ae2

File tree

11 files changed

+28
-48
lines changed

11 files changed

+28
-48
lines changed

src/main/java/ru/mystamps/web/Url.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public final class Url {
5151
public static final String INFO_SERIES_PAGE = "/series/{id}";
5252
public static final String ADD_IMAGE_SERIES_PAGE = "/series/{id}/image";
5353
public static final String SEARCH_SERIES_BY_CATALOG = "/series/search/by_catalog";
54-
public static final String INFO_COUNTRY_SERIES_PAGE = "/series/country_slug";
54+
public static final String INFO_COUNTRY_SERIES_PAGE = "/suggest/series_country";
5555

5656
public static final String ADD_CATEGORY_PAGE = "/category/add";
5757
public static final String LIST_CATEGORIES_PAGE = "/category/list";

src/main/java/ru/mystamps/web/controller/SeriesController.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,10 @@ public String searchSeriesByCatalog(
421421

422422
return "series/search_result";
423423
}
424-
424+
425+
/**
426+
* @author Shkarin John
427+
*/
425428
@ResponseBody
426429
@GetMapping(Url.INFO_COUNTRY_SERIES_PAGE)
427430
public String guessCountryBy(@CurrentUser Integer currentUserId) {

src/main/java/ru/mystamps/web/dao/impl/JdbcSeriesDao.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -327,10 +327,9 @@ public long countAddedSince(Date date) {
327327

328328
@Override
329329
public String guessCountryBy(Integer createdBy) {
330-
Map<String, Object> params = new HashMap<>();
331-
params.put("created_by", createdBy);
332-
333-
String result = jdbcTemplate.queryForObject(findLastCountryByIdSql, params, String.class);
330+
String result = jdbcTemplate.queryForObject(findLastCountryByIdSql,
331+
Collections.singletonMap("created_by", createdBy),
332+
String.class);
334333
if (result != null) {
335334
return result;
336335
}

src/main/java/ru/mystamps/web/service/CountryService.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525

2626
public interface CountryService {
2727
String add(AddCountryDto dto, Integer userId);
28-
2928
List<LinkEntityDto> findAllAsLinkEntities(String lang);
3029
LinkEntityDto findOneAsLinkEntity(String slug, String lang);
3130
long countAll();

src/main/java/ru/mystamps/web/service/SeriesServiceImpl.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,10 @@ public long countUpdatedSince(Date date) {
220220

221221
return seriesDao.countUpdatedSince(date);
222222
}
223-
223+
224+
/**
225+
* @author Shkarin John
226+
*/
224227
@Override
225228
@Transactional(readOnly = true)
226229
public String guessCountryBy(Integer createdBy) {

src/main/javascript/series/add.js

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -22,22 +22,19 @@ function initPage() {
2222
'placement': 'right'
2323
});
2424

25-
$.ajax({
26-
url : "/series/country_slug",
27-
success : function(data) {
28-
var slug = jQuery.parseJSON(data).country;
29-
if (slug == null)
30-
return;
31-
32-
var country = $("#guess_country");
33-
country[0].style.display = "block";
34-
country.click(function() {
35-
$(this)[0].style.display = "none";
25+
$.get("/suggest/series_country", function (data){
26+
var slug = jQuery.parseJSON(data).country;
27+
if (slug == null)
28+
return;
29+
30+
var country = $("#guess_country");
31+
country[0].style.display = "block";
32+
country.click(function() {
33+
$(this)[0].style.display = "none";
3634

37-
var select_country = $("#country").selectize();
38-
var selectize = select_country[0].selectize;
39-
selectize.setValue(slug);
40-
});
41-
}
35+
var select_country = $("#country").selectize();
36+
var selectize = select_country[0].selectize;
37+
selectize.setValue(slug);
38+
});
4239
});
4340
}

src/main/resources/liquibase/changelog.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,5 @@
1111
<include file="initial-state.xml" relativeToChangelogFile="true" />
1212
<include file="version/0.3.xml" relativeToChangelogFile="true" />
1313
<include file="version/0.4.xml" relativeToChangelogFile="true" />
14-
<include file="initial-test.xml" relativeToChangelogFile="true" />
1514

1615
</databaseChangeLog>

src/main/resources/liquibase/initial-test.xml

Lines changed: 0 additions & 16 deletions
This file was deleted.

src/main/resources/ru/mystamps/i18n/Messages.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ t_add_more_images_hint = Later you will be able to add additional images
121121
t_not_chosen = Not chosen
122122
t_create_category_hint = You can also <a tabindex="-1" href="{0}">add a new category</a>
123123
t_create_country_hint = You can also <a tabindex="-1" href="{0}">add a new country</a>
124-
t_guess_country = Guess the country
124+
t_guess_country = Guess a country
125125

126126
# series/info.html
127127
t_series_info = Info about series

src/main/webapp/WEB-INF/static/styles/main.css

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,3 @@ label {
107107
.goog-tooltip {
108108
color: white;
109109
}
110-
111-
#guess_country {
112-
display: none;
113-
}

src/main/webapp/WEB-INF/views/series/add.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,8 +203,8 @@ <h3 th:text="${#strings.capitalize(add_series)}">
203203
/*/-->
204204
</div>
205205

206-
<span id="guess_country">
207-
<a tabindex="-1" th:text="#{t_guess_country}" href="javascript:void(0)">Guess the country</a>
206+
<span id="guess_country" style="display: block;">
207+
<a tabindex="-1" th:text="#{t_guess_country}" href="javascript:void(0)">Guess a country</a>
208208
</span>
209209
</div>
210210

0 commit comments

Comments
 (0)