Skip to content

Commit 5c98e8f

Browse files
committed
SeriesServiceImplTest: remove 4 tests.
Tests which tests that something didn't happen are passing almost always even if we remove most of the code from a method. It's better to test that something happens. No functional changes.
1 parent 231bcf8 commit 5c98e8f

File tree

1 file changed

+0
-64
lines changed

1 file changed

+0
-64
lines changed

src/test/groovy/ru/mystamps/web/service/SeriesServiceImplTest.groovy

Lines changed: 0 additions & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -379,22 +379,6 @@ class SeriesServiceImplTest extends Specification {
379379
actual == expected
380380
}
381381

382-
@Unroll
383-
def "add() should not call services if michel numbers is '#numbers'"(String numbers) {
384-
given:
385-
form.setMichelNumbers(numbers)
386-
when:
387-
service.add(form, userId, false)
388-
then:
389-
0 * michelCatalogService.add(_ as Set<String>)
390-
and:
391-
0 * michelCatalogService.addToSeries(_ as Integer, _ as Set<String>)
392-
where:
393-
numbers | _
394-
'' | _
395-
null | _
396-
}
397-
398382
@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
399383
def "add() should add michel numbers to series"() {
400384
given:
@@ -422,22 +406,6 @@ class SeriesServiceImplTest extends Specification {
422406
})
423407
}
424408

425-
@Unroll
426-
def "add() should not call services if scott numbers is '#numbers'"(String numbers) {
427-
given:
428-
form.setScottNumbers(numbers)
429-
when:
430-
service.add(form, userId, false)
431-
then:
432-
0 * scottCatalogService.add(_ as Set<String>)
433-
and:
434-
0 * scottCatalogService.addToSeries(_ as Integer, _ as Set<String>)
435-
where:
436-
numbers | _
437-
'' | _
438-
null | _
439-
}
440-
441409
@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
442410
def "add() should add scott numbers to series"() {
443411
given:
@@ -465,22 +433,6 @@ class SeriesServiceImplTest extends Specification {
465433
})
466434
}
467435

468-
@Unroll
469-
def "add() should not call services if yvert numbers is '#numbers'"(String numbers) {
470-
given:
471-
form.setYvertNumbers(numbers)
472-
when:
473-
service.add(form, userId, false)
474-
then:
475-
0 * yvertCatalogService.add(_ as Set<String>)
476-
and:
477-
0 * yvertCatalogService.addToSeries(_ as Integer, _ as Set<String>)
478-
where:
479-
numbers | _
480-
'' | _
481-
null | _
482-
}
483-
484436
@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
485437
def "add() should add yvert numbers to series"() {
486438
given:
@@ -508,22 +460,6 @@ class SeriesServiceImplTest extends Specification {
508460
})
509461
}
510462

511-
@Unroll
512-
def "add() should not call services if gibbons numbers is '#numbers'"(String numbers) {
513-
given:
514-
form.setGibbonsNumbers(numbers)
515-
when:
516-
service.add(form, userId, false)
517-
then:
518-
0 * gibbonsCatalogService.add(_ as Set<String>)
519-
and:
520-
0 * gibbonsCatalogService.addToSeries(_ as Integer, _ as Set<String>)
521-
where:
522-
numbers | _
523-
'' | _
524-
null | _
525-
}
526-
527463
@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
528464
def "add() should add gibbons numbers to series"() {
529465
given:

0 commit comments

Comments
 (0)