SeriesServiceImpl.findByCatalogNumber(): extract help method.

Follow up to #299

No functional changes.

Author: php-coder

src/main/java/ru/mystamps/web/service/SeriesServiceImpl.java

@@ -250,45 +250,25 @@ public SeriesDto findFullInfoById(Integer seriesId, String lang) {
 	@Override
 	@Transactional(readOnly = true)
 	public List<SeriesInfoDto> findByMichelNumber(String michelNumberCode, String lang) {
-		List<Integer> seriesIds = michelCatalogService.findSeriesIdsByNumber(michelNumberCode);
-		if (seriesIds.isEmpty()) {
-			return Collections.emptyList();
-		}
-		
-		return seriesDao.findByIdsAsSeriesInfo(seriesIds, lang);
+		return findByCatalogNumber(michelCatalogService, michelNumberCode, lang);
 	}
 
 	@Override
 	@Transactional(readOnly = true)
 	public List<SeriesInfoDto> findByScottNumber(String scottNumberCode, String lang) {
-		List<Integer> seriesIds = scottCatalogService.findSeriesIdsByNumber(scottNumberCode);
-		if (seriesIds.isEmpty()) {
-			return Collections.emptyList();
-		}
-		
-		return seriesDao.findByIdsAsSeriesInfo(seriesIds, lang);
+		return findByCatalogNumber(scottCatalogService, scottNumberCode, lang);
 	}
 
 	@Override
 	@Transactional(readOnly = true)
 	public List<SeriesInfoDto> findByYvertNumber(String yvertNumberCode, String lang) {
-		List<Integer> seriesIds = yvertCatalogService.findSeriesIdsByNumber(yvertNumberCode);
-		if (seriesIds.isEmpty()) {
-			return Collections.emptyList();
-		}
-		
-		return seriesDao.findByIdsAsSeriesInfo(seriesIds, lang);
+		return findByCatalogNumber(yvertCatalogService, yvertNumberCode, lang);
 	}
 
 	@Override
 	@Transactional(readOnly = true)
 	public List<SeriesInfoDto> findByGibbonsNumber(String gibbonsNumberCode, String lang) {
-		List<Integer> seriesIds = gibbonsCatalogService.findSeriesIdsByNumber(gibbonsNumberCode);
-		if (seriesIds.isEmpty()) {
-			return Collections.emptyList();
-		}
-		
-		return seriesDao.findByIdsAsSeriesInfo(seriesIds, lang);
+		return findByCatalogNumber(gibbonsCatalogService, gibbonsNumberCode, lang);
 	}
 
 	@Override
@@ -341,6 +321,18 @@ public List<PurchaseAndSaleDto> findPurchasesAndSales(Integer seriesId) {
 		return seriesDao.findPurchasesAndSales(seriesId);
 	}
 
+	private List<SeriesInfoDto> findByCatalogNumber(
+		StampsCatalogService catalogService,
+		String number, String lang) {
+		
+		List<Integer> seriesIds = catalogService.findSeriesIdsByNumber(number);
+		if (seriesIds.isEmpty()) {
+			return Collections.emptyList();
+		}
+		
+		return seriesDao.findByIdsAsSeriesInfo(seriesIds, lang);
+	}
+	
 	private static void setDateOfReleaseIfProvided(AddSeriesDto dto, AddSeriesDbDto series) {
 		if (dto.getYear() == null) {
 			return;