WhenAdminAddCategory.categoryName{En,Ru}ShouldBeUnique: port to Robot Framework.

Addressed to #530

No functional changes.

Author: php-coder

src/main/resources/test/spring/test-data.properties

@@ -34,7 +34,8 @@ existing_yvert_number = 99
 existing_gibbons_number = 99
 
 # this category should always exist
-# (used in WhenUserAddSeries, WhenAdminAddSeries and WhenAdminAddCategory)
+# (used in WhenUserAddSeries, WhenAdminAddSeries and
+# src/test/robotframework/category/creation/validation.txt)
 valid_category_name_en = Sport
 # ATTENTION: must be encoded by native2asscii (MRESOURCES-175)
 valid_category_name_ru = \u0421\u043f\u043e\u0440\u0442

src/test/java/ru/mystamps/web/tests/cases/WhenAdminAddCategory.java

@@ -44,12 +44,6 @@ public class WhenAdminAddCategory extends WhenAnyUserAtAnyPageWithForm<AddCatego
 	@Value("${valid_admin_password}")
 	private String validAdminPassword;
 
-	@Value("${valid_category_name_en}")
-	private String existingCategoryNameEn;
-	
-	@Value("${valid_category_name_ru}")
-	private String existingCategoryNameRu;
-	
 	public WhenAdminAddCategory() {
 		super(AddCategoryPage.class);
 		hasTitle(tr("t_create_category"));
@@ -76,24 +70,6 @@ public void shouldHaveStandardStructure() {
 		checkStandardStructure();
 	}
 
-	@Test(groups = "invalid", dependsOnGroups = "std")
-	public void categoryNameEnShouldBeUnique() {
-		page.addCategory(existingCategoryNameEn, TEST_CATEGORY_NAME_RU);
-		
-		assertThat(page)
-			.field("name")
-			.hasError(tr("ru.mystamps.web.validation.jsr303.UniqueCategoryName.message"));
-	}
-	
-	@Test(groups = "invalid", dependsOnGroups = "std")
-	public void categoryNameRuShouldBeUnique() {
-		page.addCategory(TEST_CATEGORY_NAME_EN, existingCategoryNameRu);
-		
-		assertThat(page)
-			.field("nameRu")
-			.hasError(tr("ru.mystamps.web.validation.jsr303.UniqueCategoryName.message"));
-	}
-	
 	@Test(groups = "valid", dependsOnGroups = "std")
 	public void categoryNameEnWithAllowedCharactersShouldBeAccepted() {
 		page.addCategory("Valid-Name Category", "InvalidRussianCategory");

src/test/robotframework/category/creation/validation.txt

@@ -25,6 +25,14 @@ Create category with too long name
 	Element Text Should Be  id=name.errors  Value is greater than allowable maximum of 50 characters
 	Element Text Should Be  id=nameRu.errors  Value is greater than allowable maximum of 50 characters
 
+Create category with existing name
+	[Documentation]         Verify validation of non-unique name
+	Input Text              id=name  Sport
+	Input Text              id=nameRu  Спорт
+	Submit Form             id=add-category-form
+	Element Text Should Be  id=name.errors  Category already exists
+	Element Text Should Be  id=nameRu.errors  Category already exists
+
 *** Keywords ***
 Before Test Suite
 	[Documentation]                     Open browsers, register fail hook and login as admin