Use Preconditions.checkState() from Google Guava.

No functional changes.

Author: php-coder

src/test/java/ru/mystamps/web/tests/cases/WhenUserAtAnyPage.java

@@ -27,6 +27,8 @@
 
 import static org.fest.assertions.Assertions.assertThat;
 
+import static com.google.common.base.Preconditions.checkState;
+
 import static ru.mystamps.web.SiteMap.AUTHENTICATION_PAGE_URL;
 import static ru.mystamps.web.SiteMap.REGISTRATION_PAGE_URL;
 import static ru.mystamps.web.tests.TranslationUtils.tr;
@@ -93,12 +95,11 @@ private void checkServerResponseCode() {
 	}
 
 	private void shouldHaveTitle() {
-		if (title == null) {
-			throw new IllegalStateException(
-				"Page title was not set!"
-				+ " Did you call hasTitle() or hasTitleWithoutStandardPrefix() before?"
-			);
-		}
+		checkState(
+			title != null,
+			"Page title was not set!"
+			+ " Did you call hasTitle() or hasTitleWithoutStandardPrefix() before?"
+		);
 
 		assertThat(page.getTitle())
 			.overridingErrorMessage("title should be '" + title + "'")

src/test/java/ru/mystamps/web/tests/fest/AbstractPageWithFormAssert.java

@@ -21,6 +21,8 @@
 import org.fest.assertions.GenericAssert;
 import org.fest.assertions.Assertions;
 
+import static com.google.common.base.Preconditions.checkState;
+
 import ru.mystamps.web.tests.page.AbstractPageWithForm;
 
 /**
@@ -48,7 +50,7 @@ public AbstractPageWithFormAssert field(final String fieldName) {
 
 	public AbstractPageWithFormAssert hasError(final String expectedErrorMessage) {
 		isNotNull();
-		checkThatFieldNameNotNull();
+		checkState(fieldName != null, "Error in test case: field name should be specified");
 
 		final String errorMessage = actual.getFieldError(fieldName);
 
@@ -68,7 +70,7 @@ public AbstractPageWithFormAssert hasError(final String expectedErrorMessage) {
 
 	public AbstractPageWithFormAssert hasNoError() {
 		isNotNull();
-		checkThatFieldNameNotNull();
+		checkState(fieldName != null, "Error in test case: field name should be specified");
 
 		final String msg = String.format(
 			"Expected that field '%s' should not have any error",
@@ -84,7 +86,7 @@ public AbstractPageWithFormAssert hasNoError() {
 
 	public AbstractPageWithFormAssert hasValue(final String expectedValue) {
 		isNotNull();
-		checkThatFieldNameNotNull();
+		checkState(fieldName != null, "Error in test case: field name should be specified");
 
 		final String value = actual.getFieldValue(fieldName);
 
@@ -102,10 +104,4 @@ public AbstractPageWithFormAssert hasValue(final String expectedValue) {
 		return this;
 	}
 
-	private void checkThatFieldNameNotNull() {
-		if (fieldName == null) {
-			throw new IllegalArgumentException("Error in test case: field name not specified");
-		}
-	}
-	
 }

src/test/java/ru/mystamps/web/tests/page/AbstractPageWithForm.java

@@ -25,6 +25,8 @@
 
 import lombok.Getter;
 
+import static com.google.common.base.Preconditions.checkState;
+
 import ru.mystamps.web.tests.WebElementUtils;
 import ru.mystamps.web.tests.page.element.Form;
 import ru.mystamps.web.tests.page.element.Form.Field;
@@ -60,30 +62,29 @@ public boolean isSubmitButtonExists(final SubmitButton button) {
 	}
 
 	public void submit() {
-		if (form == null) {
-			throw new IllegalStateException(
-				"You are trying to submit form at page which does not have form"
-			);
-		}
+		
+		checkState(
+			form != null,
+			"You are trying to submit form at page which does not have form"
+		);
 
 		final List<SubmitButton> buttons = form.getSubmitButtons();
-		if (buttons.isEmpty()) {
-			throw new IllegalStateException(
-				"You are trying to submit form at page which does not have submit button"
-			);
-		}
+		
+		checkState(
+			!buttons.isEmpty(),
+			"You are trying to submit form at page which does not have submit button"
+		);
 
 		final String xpathOfFirstSubmitButton = buttons.get(0).toString();
 
 		getElementByXPath(xpathOfFirstSubmitButton).submit();
 	}
 
 	public boolean formExists() {
-		if (form == null) {
-			throw new IllegalStateException(
-				"You are trying to check form at page which does not has form"
-			);
-		}
+		checkState(
+			form != null,
+			"You are trying to check form at page which does not has form"
+		);
 
 		return elementWithXPathExists(form.toString());
 	}
@@ -97,11 +98,10 @@ public boolean inputHasAsterisk(final String id) {
 	}
 
 	public String getFieldValue(final String name) {
-		if (form == null) {
-			throw new IllegalStateException(
-				"You are trying to find field at page which does not have form"
-			);
-		}
+		checkState(
+			form != null,
+			"You are trying to find field at page which does not have form"
+		);
 
 		final String xpathField = form.getField(name).toString();
 

src/test/java/ru/mystamps/web/tests/page/ActivateAccountPage.java

@@ -20,6 +20,8 @@
 
 import org.openqa.selenium.WebDriver;
 
+import static com.google.common.base.Preconditions.checkState;
+
 import static ru.mystamps.web.SiteMap.ACTIVATE_ACCOUNT_PAGE_URL;
 
 import static ru.mystamps.web.tests.TranslationUtils.tr;
@@ -73,16 +75,17 @@ public void activateAccount(
 			final String passwordConfirmation,
 			final String activationKey) {
 
-		if (login == null
+		final boolean allFieldsAreNull =
+			login == null
 			&& name == null
 			&& password == null
 			&& passwordConfirmation == null
-			&& activationKey == null) {
-			
-			throw new IllegalStateException(
-				"Login, name, password with confirmation and activation key should not be null"
-			);
-		}
+			&& activationKey == null;
+		
+		checkState(
+			!allFieldsAreNull,
+			"Login, name, password with confirmation and activation key should not be null"
+		);
 
 		fillLogin(login);
 		fillName(name);

src/test/java/ru/mystamps/web/tests/page/AuthAccountPage.java

@@ -20,6 +20,8 @@
 
 import org.openqa.selenium.WebDriver;
 
+import static com.google.common.base.Preconditions.checkState;
+
 import static ru.mystamps.web.SiteMap.AUTHENTICATION_PAGE_URL;
 
 import static ru.mystamps.web.tests.TranslationUtils.tr;
@@ -57,9 +59,10 @@ public boolean authenticationFormExists() {
 	}
 
 	public void authorizeUser(final String login, final String password) {
-		if (login == null && password == null) {
-			throw new IllegalStateException("Login and password should not be a null");
-		}
+		checkState(
+			!(login == null && password == null),
+			"Login and password should not be a null"
+		);
 
 		fillLogin(login);
 		fillPassword(password);