Skip to content

Commit 499bd0e

Browse files
committed
Fix warning "Ignored property 'app.site-parser[3].image-url-attribute': unknown or unsupported"
Fix #767
1 parent a13cc2f commit 499bd0e

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

src/main/java/ru/mystamps/web/util/extractor/SiteParser.java

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,38 +55,32 @@ public boolean setField(String name, String value) {
5555
Validate.validState(StringUtils.isNotBlank(name), "Field name must be non-blank");
5656
Validate.validState(StringUtils.isNotBlank(value), "Field value must be non-blank");
5757

58-
boolean valid = false;
58+
boolean valid = true;
5959

6060
switch (name) {
6161

6262
case "name":
6363
setName(value);
64-
valid = true;
6564
break;
6665

6766
case "matched-url":
6867
setMatchedUrl(value);
69-
valid = true;
7068
break;
7169

7270
case "category-locator":
7371
setCategoryLocator(value);
74-
valid = true;
7572
break;
7673

7774
case "country-locator":
7875
setCountryLocator(value);
79-
valid = true;
8076
break;
8177

8278
case "short-description-locator":
8379
setShortDescriptionLocator(value);
84-
valid = true;
8580
break;
8681

8782
case "image-url-locator":
8883
setImageUrlLocator(value);
89-
valid = true;
9084
break;
9185

9286
case "image-url-attribute":
@@ -95,10 +89,10 @@ public boolean setField(String name, String value) {
9589

9690
case "issue-date-locator":
9791
setIssueDateLocator(value);
98-
valid = true;
9992
break;
10093

10194
default:
95+
valid = false;
10296
break;
10397
}
10498

src/test/java/ru/mystamps/web/util/extractor/SiteParserTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ public void setFieldShouldSupportSettingImageUrlAttribute() {
138138

139139
boolean valid = parser.setField("image-url-attribute", expectedAttributeName);
140140

141-
assertThat(valid, is(false));
141+
assertThat(valid, is(true));
142142
assertThat(parser.getImageUrlAttribute(), equalTo(expectedAttributeName));
143143
}
144144

0 commit comments

Comments
 (0)