/category/add: add validation for unique slug.

This fixes DuplicateKeyException when name contains mix of spaces and hyphens.

Fix #486

Author: php-coder

src/main/java/ru/mystamps/web/dao/CategoryDao.java

@@ -26,6 +26,7 @@
 public interface CategoryDao {
 	Integer add(AddCategoryDbDto category);
 	long countAll();
+	long countBySlug(String slug);
 	long countByName(String name);
 	long countByNameRu(String name);
 	long countCategoriesOfCollection(Integer collectionId);

src/main/java/ru/mystamps/web/dao/impl/JdbcCategoryDao.java

@@ -50,6 +50,9 @@ public class JdbcCategoryDao implements CategoryDao {
 	@Value("${category.count_all_categories}")
 	private String countAllSql;
 
+	@Value("${category.count_categories_by_slug}")
+	private String countBySlugSql;
+	
 	@Value("${category.count_categories_by_name}")
 	private String countByNameSql;
 
@@ -108,6 +111,15 @@ public long countAll() {
 		);
 	}
 
+	@Override
+	public long countBySlug(String slug) {
+		return jdbcTemplate.queryForObject(
+			countBySlugSql,
+			Collections.singletonMap("slug", slug),
+			Long.class
+		);
+	}
+	
 	@Override
 	public long countByName(String name) {
 		return jdbcTemplate.queryForObject(

src/main/java/ru/mystamps/web/model/AddCategoryForm.java

@@ -29,6 +29,7 @@
 import ru.mystamps.web.service.dto.AddCategoryDto;
 import ru.mystamps.web.validation.jsr303.UniqueCategoryName;
 import ru.mystamps.web.validation.jsr303.UniqueCategoryName.Lang;
+import ru.mystamps.web.validation.jsr303.UniqueCategorySlug;
 
 import static ru.mystamps.web.validation.ValidationRules.CATEGORY_NAME_EN_REGEXP;
 import static ru.mystamps.web.validation.ValidationRules.CATEGORY_NAME_MAX_LENGTH;
@@ -46,7 +47,8 @@
 	Group.Level3.class,
 	Group.Level4.class,
 	Group.Level5.class,
-	Group.Level6.class
+	Group.Level6.class,
+	Group.Level7.class
 })
 public class AddCategoryForm implements AddCategoryDto {
 
@@ -81,6 +83,7 @@ public class AddCategoryForm implements AddCategoryDto {
 		)
 	})
 	@UniqueCategoryName(lang = Lang.EN, groups = Group.Level6.class)
+	@UniqueCategorySlug(groups = Group.Level7.class)
 	private String name;
 
 	@NotEmpty(groups = Group.Level1.class)

src/main/java/ru/mystamps/web/model/Group.java

@@ -37,4 +37,7 @@ interface Level5 {
 	interface Level6 {
 	}
 
+	interface Level7 {
+	}
+	
 }

src/main/java/ru/mystamps/web/service/CategoryService.java

@@ -29,6 +29,7 @@ public interface CategoryService {
 	LinkEntityDto findOneAsLinkEntity(String slug, String lang);
 	long countAll();
 	long countCategoriesOf(Integer collectionId);
+	long countBySlug(String slug);
 	long countByName(String name);
 	long countByNameRu(String name);
 	long countAddedSince(Date date);

src/main/java/ru/mystamps/web/service/CategoryServiceImpl.java

@@ -109,6 +109,14 @@ public long countCategoriesOf(Integer collectionId) {
 		return categoryDao.countCategoriesOfCollection(collectionId);
 	}
 
+	@Override
+	@Transactional(readOnly = true)
+	public long countBySlug(String slug) {
+		Validate.isTrue(slug != null, "Category slug must be non null");
+		
+		return categoryDao.countBySlug(slug);
+	}
+	
 	@Override
 	@Transactional(readOnly = true)
 	public long countByName(String name) {

src/main/java/ru/mystamps/web/validation/jsr303/UniqueCategorySlug.java

@@ -0,0 +1,40 @@
+/*
+ * Copyright (C) 2009-2016 Slava Semushin <slava.semushin@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ */
+package ru.mystamps.web.validation.jsr303;
+
+import java.lang.annotation.Documented;
+import java.lang.annotation.Retention;
+import java.lang.annotation.Target;
+
+import javax.validation.Constraint;
+import javax.validation.Payload;
+
+import static java.lang.annotation.ElementType.ANNOTATION_TYPE;
+import static java.lang.annotation.ElementType.FIELD;
+import static java.lang.annotation.ElementType.METHOD;
+import static java.lang.annotation.RetentionPolicy.RUNTIME;
+
+@Target({ METHOD, FIELD, ANNOTATION_TYPE })
+@Retention(RUNTIME)
+@Constraint(validatedBy = UniqueCategorySlugValidator.class)
+@Documented
+public @interface UniqueCategorySlug {
+	String message() default "{ru.mystamps.web.validation.jsr303.UniqueCategorySlug.message}";
+	Class<?>[] groups() default {};
+	Class<? extends Payload>[] payload() default {};
+}

src/main/java/ru/mystamps/web/validation/jsr303/UniqueCategorySlugValidator.java

@@ -0,0 +1,51 @@
+/*
+ * Copyright (C) 2009-2016 Slava Semushin <slava.semushin@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ */
+package ru.mystamps.web.validation.jsr303;
+
+import javax.validation.ConstraintValidator;
+import javax.validation.ConstraintValidatorContext;
+
+import lombok.RequiredArgsConstructor;
+
+import ru.mystamps.web.service.CategoryService;
+import ru.mystamps.web.util.SlugUtils;
+
+@RequiredArgsConstructor
+public class UniqueCategorySlugValidator
+	implements ConstraintValidator<UniqueCategorySlug, String> {
+	
+	private final CategoryService categoryService;
+	
+	@Override
+	public void initialize(UniqueCategorySlug annotation) {
+		// Intentionally empty: nothing to initialize
+	}
+	
+	@Override
+	public boolean isValid(String value, ConstraintValidatorContext ctx) {
+		
+		if (value == null) {
+			return true;
+		}
+		
+		String slug = SlugUtils.slugify(value);
+		
+		return categoryService.countBySlug(slug) == 0;
+	}
+	
+}

src/main/resources/ru/mystamps/i18n/ValidationMessages.properties

@@ -9,6 +9,7 @@ ru.mystamps.web.validation.jsr303.FieldsMatch.message = Field '{second}' must ma
 ru.mystamps.web.validation.jsr303.UniqueLogin.message = Login already exists
 ru.mystamps.web.validation.jsr303.UniqueCountryName.message = Country already exists
 ru.mystamps.web.validation.jsr303.UniqueCategoryName.message = Category already exists
+ru.mystamps.web.validation.jsr303.UniqueCategorySlug.message = Category with similar name already exists
 ru.mystamps.web.validation.jsr303.ExistingActivationKey.message = Wrong activation key
 ru.mystamps.web.validation.jsr303.Email.message = Wrong e-mail address
 ru.mystamps.web.validation.jsr303.NotEmptyFilename.message = Value must not be empty

src/main/resources/ru/mystamps/i18n/ValidationMessages_ru.properties

@@ -9,6 +9,7 @@ ru.mystamps.web.validation.jsr303.FieldsMatch.message = Поле '{second}' до
 ru.mystamps.web.validation.jsr303.UniqueLogin.message = Логин уже существует
 ru.mystamps.web.validation.jsr303.UniqueCountryName.message = Страна уже есть в базе
 ru.mystamps.web.validation.jsr303.UniqueCategoryName.message = Категория уже есть в базе
+ru.mystamps.web.validation.jsr303.UniqueCategorySlug.message = Категория с похожим названием уже есть в базе
 ru.mystamps.web.validation.jsr303.ExistingActivationKey.message = Неправильный код активации
 ru.mystamps.web.validation.jsr303.Email.message = Неправильный адрес электронной почты
 ru.mystamps.web.validation.jsr303.ReleaseDateIsNotInFuture.message = Дата выпуска не может быть в будущем

src/main/resources/sql/category_dao_queries.properties

@@ -23,6 +23,11 @@ category.count_all_categories = \
 SELECT COUNT(*) \
   FROM categories
 
+category.count_categories_by_slug = \
+SELECT COUNT(*) \
+  FROM categories \
+ WHERE slug = :slug
+
 category.count_categories_by_name = \
 SELECT COUNT(*) \
   FROM categories \

src/test/groovy/ru/mystamps/web/service/CategoryServiceImplTest.groovy

@@ -312,6 +312,26 @@ class CategoryServiceImplTest extends Specification {
 			}) >> 0L
 	}
 
+	//
+	// Tests for countBySlug()
+	//
+	
+	def "countBySlug() should throw exception when slug is null"() {
+		when:
+			service.countBySlug(null)
+		then:
+			thrown IllegalArgumentException
+	}
+	
+	def "countBySlug() should call dao"() {
+		given:
+			categoryDao.countBySlug(_ as String) >> 3L
+		when:
+			long result = service.countBySlug('any-slug')
+		then:
+			result == 3L
+	}
+	
 	//
 	// Tests for countByName()
 	//