SiteParser.extractCategory(): add unit tests.

Addressed to #685

No functional changes.

Author: php-coder

src/main/java/ru/mystamps/web/util/extractor/SiteParser.java

@@ -151,7 +151,7 @@ public String toString() {
 		return name;
 	}
 
-	private String extractCategory(Element body) {
+	protected String extractCategory(Element body) {
 		String locator = ObjectUtils.firstNonNull(categoryLocator, shortDescriptionLocator);
 		if (locator == null) {
 			return null;

src/test/java/ru/mystamps/web/util/extractor/SiteParserTest.java

@@ -17,6 +17,10 @@
  */
 package ru.mystamps.web.util.extractor;
 
+import org.jsoup.Jsoup;
+import org.jsoup.nodes.Document;
+import org.jsoup.nodes.Element;
+
 import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
@@ -27,9 +31,11 @@
 import static io.qala.datagen.RandomShortApi.nullOr;
 import static io.qala.datagen.RandomShortApi.nullOrBlank;
 import static io.qala.datagen.RandomValue.between;
+
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.equalTo;
 import static org.hamcrest.Matchers.is;
+import static org.hamcrest.Matchers.nullValue;
 
 public class SiteParserTest {
 
@@ -285,6 +291,60 @@ public void toStringShouldReturnName() {
 		assertThat(parser.toString(), equalTo(expectedName));
 	}
 
+	//
+	// Tests for extractCategory()
+	//
+	
+	@Test
+	public void extractCategoryShouldReturnNullWhenLocatorsAreNotSet() {
+		parser.setCategoryLocator(null);
+		parser.setShortDescriptionLocator(null);
+		Element doc = createEmptyDocument();
+		
+		String category = parser.extractCategory(doc);
+		
+		assertThat(category, is(nullValue()));
+	}
+	
+	@Test
+	public void extractCategoryShouldReturnNullWhenElementNotFound() {
+		parser.setCategoryLocator(Random.jsoupLocator());
+		Element doc = createEmptyDocument();
+		
+		String category = parser.extractCategory(doc);
+		
+		assertThat(category, is(nullValue()));
+	}
+	
+	@Test
+	public void extractCategoryShouldReturnTextOfCategoryLocator() {
+		parser.setCategoryLocator("#category");
+		
+		String expectedName = Random.categoryName();
+		String html = String.format("<div id='category'>%s</div>", expectedName);
+		Element doc = createDocumentFromText(html);
+		
+		String category = parser.extractCategory(doc);
+		
+		String msg = String.format("couldn't extract a category from '%s'", doc);
+		assertThat(msg, category, equalTo(expectedName));
+	}
+	
+	@Test
+	public void extractCategoryShouldReturnTextOfShortDescriptionLocator() {
+		parser.setCategoryLocator(null);
+		parser.setShortDescriptionLocator("#desc");
+		
+		String expectedName = Random.categoryName();
+		String html = String.format("<div id='desc'>%s</div>", expectedName);
+		Element doc = createDocumentFromText(html);
+		
+		String category = parser.extractCategory(doc);
+		
+		String msg = String.format("couldn't extract a category from '%s'", doc);
+		assertThat(msg, category, equalTo(expectedName));
+	}
+	
 	private static String describe(SiteParser parser) {
 		StringBuilder sb = new StringBuilder();
 		sb.append("SiteParser[name=")
@@ -307,4 +367,13 @@ private static String describe(SiteParser parser) {
 		return sb.toString();
 	}
 
+	private static Element createDocumentFromText(String html) {
+		Document doc = Jsoup.parseBodyFragment(html);
+		return doc.body();
+	}
+	
+	private static Element createEmptyDocument() {
+		return createDocumentFromText("");
+	}
+	
 }