Skip to content

Commit 2b14e70

Browse files
committed
refactor: improve log messages by prefix them with image id.
1 parent 6fcb730 commit 2b14e70

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

src/main/java/ru/mystamps/web/feature/image/FilesystemImagePersistenceStrategy.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public void save(MultipartFile file, ImageInfoDto image) {
8383
Path dest = generateFilePath(storageDir, image);
8484
writeToFile(file, dest);
8585

86-
log.info("Image data has been written into file {}", dest);
86+
log.info("Image #{}: data has been written into file {}", image.getId(), dest);
8787

8888
} catch (IOException ex) {
8989
throw new ImagePersistenceException(ex);
@@ -96,7 +96,7 @@ public void savePreview(byte[] data, ImageInfoDto image) {
9696
Path dest = generateFilePath(previewDir, image);
9797
writeToFile(data, dest);
9898

99-
log.info("Image preview data has been written into file {}", dest);
99+
log.info("Image #{}: preview has been written into file {}", image.getId(), dest);
100100

101101
} catch (IOException ex) {
102102
throw new ImagePersistenceException(ex);
@@ -160,8 +160,14 @@ public void removeIfPossible(ImageInfoDto image) {
160160
Path dest = generateFilePath(storageDir, image);
161161
try {
162162
Files.deleteIfExists(dest);
163+
log.debug("Image #{}: data ({}) has been removed", image.getId(), dest);
164+
163165
} catch (Exception ex) { // NOPMD: AvoidCatchingGenericException
164-
log.warn("Couldn't delete file {}: {}", dest, ex.getMessage());
166+
log.warn(
167+
"Couldn't delete file {}: {}. You have to remove it manually",
168+
dest,
169+
ex.getMessage()
170+
);
165171
}
166172
}
167173

src/main/java/ru/mystamps/web/feature/image/ImageServiceImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public ImageInfoDto save(MultipartFile file) {
7373
}
7474

7575
ImageInfoDto imageInfo = new ImageInfoDto(imageId, imageType);
76-
log.info("Image info has been saved to database ({})", imageInfo);
76+
log.info("Image #{}: meta data has been saved ({})", imageId, imageInfo);
7777

7878
imagePersistenceStrategy.save(file, imageInfo);
7979

0 commit comments

Comments
 (0)