refactor(WhenUserAddSeries): port issueYearFieldShouldHaveOptionsForRangeFrom1840ToCurrentYear() to Robot Framework.

Also remove a similar test from misc-admin.robot: one test for
that case is enough. If this will be broken only for admin it
won't be so critical as when it's broken for users.

Addressed to #530

No functional changes.

Author: php-coder

src/test/java/ru/mystamps/web/tests/cases/WhenUserAddSeries.java

@@ -30,8 +30,6 @@
 
 import java.io.File;
 import java.net.URISyntaxException;
-import java.time.Year;
-import java.util.ArrayList;
 import java.util.List;
 
 import static org.fest.assertions.api.Assertions.assertThat;
@@ -40,22 +38,10 @@
 
 public class WhenUserAddSeries extends WhenAnyUserAtAnyPageWithForm<AddSeriesPage> {
 
-	private static final int SINCE_YEAR     = 1840;
-	private static final int CURRENT_YEAR   = Year.now().getValue();
-	
-	private static final List<String> EXPECTED_YEARS =
-		new ArrayList<>(CURRENT_YEAR - SINCE_YEAR + 1);
-	
 	private static final String SAMPLE_IMAGE_NAME = "test/test.png";
 	private static final String SAMPLE_IMAGE_PATH;
 
 	static {
-		EXPECTED_YEARS.add("Year");
-		// years in reverse order
-		for (int i = CURRENT_YEAR; i >= SINCE_YEAR; i--) {
-			EXPECTED_YEARS.add(String.valueOf(i));
-		}
-		
 		try {
 			SAMPLE_IMAGE_PATH = new File(
 				WhenUserAddSeries.class.getClassLoader().getResource(SAMPLE_IMAGE_NAME).toURI()
@@ -185,13 +171,6 @@ public void catalogPricesShouldRejectInvalidValues(String price, String msg) {
 		assertThat(page).field("zagorskiPrice").hasError(msg);
 	}
 
-	@Test(groups = "misc", dependsOnGroups = "std")
-	public void issueYearFieldShouldHaveOptionsForRangeFrom1840ToCurrentYear() {
-		page.showDateOfRelease();
-		
-		assertThat(page.getYearFieldValues()).isEqualTo(EXPECTED_YEARS);
-	}
-	
 	@Test(groups = "misc", dependsOnGroups = "std")
 	public void catalogNumbersShouldBeStripedFromSpaces() {
 		page.showCatalogNumbers();

src/test/java/ru/mystamps/web/tests/page/AddSeriesPage.java

@@ -149,10 +149,6 @@ public void fillCountry(String value) {
 			.click();
 	}
 
-	public List<String> getYearFieldValues() {
-		return getSelectOptions("year");
-	}
-	
 	public void fillDay(String value) {
 		if (value != null) {
 			new Select(getElementByName("day")).selectByVisibleText(value);

src/test/robotframework/series/creation/misc-admin.robot

@@ -1,6 +1,5 @@
 *** Settings ***
 Documentation    Verify miscellaneous aspects of series creation
-Library          Collections
 Library          SeleniumLibrary
 Resource         ../../auth.steps.robot
 Suite Setup      Before Test Suite
@@ -73,18 +72,6 @@ Catalog numbers should accept existing numbers
 	Element Text Should Be     id=solovyov_catalog_info  \#77
 	Element Text Should Be     id=zagorski_catalog_info  \#83
 
-Issue year should have options for range from 1840 to the current year
-	Go To                        ${SITE_URL}/series/add
-	Click Element                id=specify-issue-date-link
-	${availableYears}=           Get List Items  id=year
-	${currentYear}=              Get Time  year  NOW
-	${numberOfYears}=            Get Length  ${availableYears}
-	# +2 here is to include the current year and option with title
-	${expectedNumberOfYears}=    Evaluate  ${currentYear}-1840+2
-	List Should Contain Value    ${availableYears}  1840
-	List Should Contain Value    ${availableYears}  ${currentYear}
-	Should Be Equal As Integers  ${numberOfYears}  ${expectedNumberOfYears}
-
 Comment should be stripped from leading and trailing spaces
 	Click Element             id=add-comment-link
 	Input Text                id=comment  ${SPACE * 2}example comment${SPACE * 2}

src/test/robotframework/series/creation/misc-user.robot

@@ -0,0 +1,31 @@
+*** Settings ***
+Documentation    Verify miscellaneous aspects of series creation
+Library          Collections
+Library          SeleniumLibrary
+Resource         ../../auth.steps.robot
+Suite Setup      Before Test Suite
+Suite Teardown   After Test Suite
+Force Tags       series  misc
+
+*** Test Cases ***
+Issue year should have options for range from 1840 to the current year
+	Click Element                id=specify-issue-date-link
+	${availableYears}=           Get List Items  id=year
+	${currentYear}=              Get Time  year  NOW
+	${numberOfYears}=            Get Length  ${availableYears}
+	# +2 here is to include the current year and option with title
+	${expectedNumberOfYears}=    Evaluate  ${currentYear}-1840+2
+	List Should Contain Value    ${availableYears}  1840
+	List Should Contain Value    ${availableYears}  ${currentYear}
+	Should Be Equal As Integers  ${numberOfYears}   ${expectedNumberOfYears}
+
+*** Keywords ***
+Before Test Suite
+	Open Browser                        ${SITE_URL}/account/auth  ${BROWSER}
+	Register Keyword To Run On Failure  Log Source
+	Log In As                           login=coder  password=test
+	Go To                               ${SITE_URL}/series/add
+
+After Test Suite
+	Log Out
+	Close Browser