Skip to content

Commit 1ecb58d

Browse files
committed
refactor(WhenUserAddSeries): port shouldCreateSeriesWithAllFieldsFilled() to Robot Framework.
Addressed to #530 No functional changes.
1 parent 0b8f5a0 commit 1ecb58d

File tree

8 files changed

+39
-632
lines changed

8 files changed

+39
-632
lines changed

src/main/resources/test/spring/test-data.properties

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ valid_country_name_ru = \u0418\u0442\u0430\u043b\u0438\u044f
2525
# this category should always exist
2626
# (used in WhenUserAddSeries, src/test/robotframework/category/creation/validation.robot and
2727
# src/test/robotframework/series/creation/misc-admin.robot)
28-
valid_category_name_en = Sport
2928
# ATTENTION: must be encoded by native2asscii (MRESOURCES-175)
3029
valid_category_name_ru = \u0421\u043f\u043e\u0440\u0442
3130

src/test/config/testng.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
11
<!DOCTYPE suite SYSTEM "http://testng.org/testng-1.0.dtd">
22
<suite name="Functional tests on Selenium">
33

4-
<test name="When user add series">
5-
<classes>
6-
<class name="ru.mystamps.web.tests.cases.WhenUserAddSeries" />
7-
</classes>
8-
</test>
9-
104
<test name="When any user at any page">
115
<classes>
126
<class name="ru.mystamps.web.tests.cases.WhenAnyUserAtAnyPage" />

src/test/java/ru/mystamps/web/tests/cases/WhenUserAddSeries.java

Lines changed: 0 additions & 152 deletions
This file was deleted.

src/test/java/ru/mystamps/web/tests/page/AbstractPage.java

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@
3333
@RequiredArgsConstructor(access = PROTECTED)
3434
public abstract class AbstractPage {
3535

36-
// CheckStyle: ignore LineLength for next 1 line
37-
private static final String LOGOUT_BUTTON_LOCATOR = "//form[@id=\"logout-form\"]/input[@type=\"submit\"]";
3836
private static final String A_HREF_LOCATOR = "//a[@href=\"%s\"]";
3937

4038
protected final WebDriver driver;
@@ -146,29 +144,4 @@ private WebElement getElement(By byMethod) {
146144
}
147145
}
148146

149-
public void login(String login, String password) {
150-
Validate.isTrue(!"".equals(login), "login must be not null and not empty");
151-
Validate.isTrue(!"".equals(password), "password must be not null and not empty");
152-
153-
// FIXME: check than we already authenticated and do nothing
154-
AuthAccountPage authPage = new AuthAccountPage(driver);
155-
authPage.open();
156-
authPage.authorizeUser(login, password);
157-
158-
// return to current page
159-
open();
160-
// FIXME: test for presence link with text "Sign out" to ensure than all right?
161-
}
162-
163-
public void logout() {
164-
// FIXME: check than we not authenticated and do nothing
165-
166-
WebElement logoutButton = getElementByXPath(LOGOUT_BUTTON_LOCATOR);
167-
logoutButton.submit();
168-
169-
// return to current page
170-
open();
171-
// FIXME: test for presence link with text "Sign in" to ensure than all right?
172-
}
173-
174147
}

0 commit comments

Comments
 (0)