Skip to content

Commit 1533140

Browse files
committed
ErrorController: use constants from RequestDispatcher class.
No functional changes.
1 parent 51eb6a3 commit 1533140

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

src/main/java/ru/mystamps/web/controller/ErrorController.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
*/
1818
package ru.mystamps.web.controller;
1919

20+
import javax.servlet.RequestDispatcher;
2021
import javax.servlet.http.HttpServletRequest;
2122

2223
import org.slf4j.Logger;
@@ -45,7 +46,7 @@ public void notFound(
4546
HttpServletRequest request,
4647
@CurrentUser Integer currentUserId,
4748
// CheckStyle: ignore LineLength for next 1 line
48-
@RequestAttribute(name = "javax.servlet.error.request_uri", required = false) String page,
49+
@RequestAttribute(name = RequestDispatcher.ERROR_REQUEST_URI, required = false) String page,
4950
@RequestHeader(name = "referer", required = false) String referer,
5051
@RequestHeader(name = "user-agent", required = false) String agent) {
5152

@@ -58,10 +59,10 @@ public void notFound(
5859

5960
@RequestMapping(Url.INTERNAL_ERROR_PAGE)
6061
public void internalError(
61-
// CheckStyle: ignore LineLength for next 2 lines
62-
@RequestAttribute(name = "javax.servlet.error.exception_type", required = false) Class<?> exceptionType,
63-
@RequestAttribute(name = "javax.servlet.error.exception", required = false) Exception exception,
64-
@RequestAttribute(name = "javax.servlet.error.request_uri", required = false) String page) {
62+
// CheckStyle: ignore LineLength for next 3 lines
63+
@RequestAttribute(name = RequestDispatcher.ERROR_EXCEPTION_TYPE, required = false) Class<?> exceptionType,
64+
@RequestAttribute(name = RequestDispatcher.ERROR_EXCEPTION, required = false) Exception exception,
65+
@RequestAttribute(name = RequestDispatcher.ERROR_REQUEST_URI, required = false) String page) {
6566

6667
// TODO: log to database (with *.status_code, *.message, *.servlet_name and user details)
6768

0 commit comments

Comments
 (0)