UserServiceTest: test that addRegistrationRequest() and registerUser() generates unique values.

Author: php-coder

src/test/java/ru/mystamps/web/service/UserServiceTest.java

@@ -34,6 +34,7 @@
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.any;
 import static org.mockito.Mockito.anyString;
+import static org.mockito.Mockito.atLeastOnce;
 import static org.mockito.Mockito.never;
 import static org.mockito.Mockito.when;
 
@@ -94,6 +95,19 @@ public void addRegistrationRequestShouldGenerateActivationKey() {
 		assertThat(activationKey).matches("^[\\p{Lower}\\p{Digit}]+$");
 	}
 
+	@Test
+	public void addRegistrationRequestShouldGenerateUniqueActivationKey() {
+		service.addRegistrationRequest(TEST_EMAIL);
+		verify(usersActivationDao).add(activationCaptor.capture());
+		final String firstActivationKey = activationCaptor.getValue().getActivationKey();
+		
+		service.addRegistrationRequest(TEST_EMAIL);
+		verify(usersActivationDao, atLeastOnce()).add(activationCaptor.capture());
+		final String secondActivationKey = activationCaptor.getValue().getActivationKey();
+		
+		assertThat(firstActivationKey).isNotEqualTo(secondActivationKey);
+	}
+	
 	@Test(expected = IllegalArgumentException.class)
 	public void addRegistrationRequestShouldThrowExceptionWhenEmailIsNull() {
 		service.addRegistrationRequest(null);
@@ -246,6 +260,21 @@ public void registerUserShouldGenerateSalt() {
 		assertThat(salt).matches("^[\\p{Alnum}]+$");
 	}
 
+	@Test
+	public void registerUserShouldGenerateUniqueSalt() {
+		when(usersActivationDao.findByActivationKey(anyString())).thenReturn(getUsersActivation());
+		
+		service.registerUser(TEST_LOGIN, TEST_PASSWORD, TEST_NAME, TEST_ACTIVATION_KEY);
+		verify(userDao).add(userCaptor.capture());
+		final String firstSalt = userCaptor.getValue().getSalt();
+		
+		service.registerUser(TEST_LOGIN, TEST_PASSWORD, TEST_NAME, TEST_ACTIVATION_KEY);
+		verify(userDao, atLeastOnce()).add(userCaptor.capture());
+		final String secondSalt = userCaptor.getValue().getSalt();
+		
+		assertThat(firstSalt).isNotEqualTo(secondSalt);
+	}
+	
 	@Test(expected = IllegalArgumentException.class)
 	public void registerUserShouldThrowExceptionWhenPasswordIsNull() {
 		service.registerUser(TEST_LOGIN, null, TEST_NAME, TEST_ACTIVATION_KEY);