Added static modifier to sl4j logger instance.

And also renamed it to upper case, due to its static nature.

Reported by PMD.

No functional changes.

Author: php-coder

src/main/java/ru/mystamps/web/controller/NotFoundErrorController.java

@@ -37,7 +37,7 @@
 @Controller
 @RequestMapping(Url.NOT_FOUND_PAGE)
 public class NotFoundErrorController {
-	private final Logger log = LoggerFactory.getLogger(NotFoundErrorController.class);
+	private static final Logger LOG = LoggerFactory.getLogger(NotFoundErrorController.class);
 
 	private final SiteService siteService;
 
@@ -68,7 +68,7 @@ public void notFound(
 		} catch (final Exception ex) {
 			// intentionally ignored:
 			// database error should not break showing of 404 page
-			log.warn("Cannot log 404 error", ex);
+			LOG.warn("Cannot log 404 error", ex);
 		}
 	}
 

src/main/java/ru/mystamps/web/service/CronService.java

@@ -44,7 +44,7 @@ public class CronService {
 
 	private static final long CHECK_UNACTIVATED_REQUESTS_PERIOD = 12 * DateUtils.MILLIS_PER_HOUR;
 
-	private final Logger log = LoggerFactory.getLogger(CronService.class);
+	private static final Logger LOG = LoggerFactory.getLogger(CronService.class);
 
 	@Inject
 	private UsersActivationDao usersActivationDao;
@@ -63,12 +63,12 @@ public void purgeUsersActivations() {
 		checkState(expiredActivations != null, "Expired activations should be non null");
 
 		if (expiredActivations.isEmpty()) {
-			log.info("Expired activations was not found.");
+			LOG.info("Expired activations was not found.");
 			return;
 		}
 
 		for (final UsersActivation activation : expiredActivations) {
-			log.info(
+			LOG.info(
 				"Delete expired activation (key: {}, email: {}, created: {})",
 				new Object[] {
 					activation.getActivationKey(),

src/main/java/ru/mystamps/web/service/SiteService.java

@@ -41,7 +41,8 @@
 
 @Service
 public class SiteService {
-	private final Logger log = LoggerFactory.getLogger(SiteService.class);
+	
+	private static final Logger LOG = LoggerFactory.getLogger(SiteService.class);
 
 	@Inject
 	private UserDao users;
@@ -94,7 +95,7 @@ private void log(
 		if (userId != null) {
 			currentUser = users.findOne(userId);
 			if (currentUser == null) {
-				log.warn("Cannot find user with id {}", userId);
+				LOG.warn("Cannot find user with id {}", userId);
 			}
 		}
 		activity.setUser(currentUser);

src/main/java/ru/mystamps/web/service/UserService.java

@@ -43,7 +43,7 @@
 @Service
 public class UserService {
 
-	private final Logger log = LoggerFactory.getLogger(UserService.class);
+	private static final Logger LOG = LoggerFactory.getLogger(UserService.class);
 
 	@Inject
 	private UserDao users;
@@ -94,7 +94,7 @@ public void registerUser(final String login, final String password,
 		final UsersActivation activation =
 			usersActivation.findByActivationKey(activationKey);
 		if (activation == null) {
-			log.warn("Cannot find registration request for activation key '{}'", activationKey);
+			LOG.warn("Cannot find registration request for activation key '{}'", activationKey);
 			return;
 		}
 
@@ -120,7 +120,7 @@ public void registerUser(final String login, final String password,
 		users.save(user);
 		usersActivation.delete(activation);
 
-		log.info(
+		LOG.info(
 			"Added user (login='{}', name='{}', activation key='{}')",
 			new Object[]{login, finalName, activationKey}
 		);

src/main/java/ru/mystamps/web/support/spring/security/AuthenticationFailureListener.java

@@ -34,7 +34,7 @@
 public class AuthenticationFailureListener
 	implements ApplicationListener<AuthenticationFailureBadCredentialsEvent> {
 
-	private final Logger log = LoggerFactory.getLogger(AuthenticationFailureListener.class);
+	private static final Logger LOG = LoggerFactory.getLogger(AuthenticationFailureListener.class);
 
 	@Inject
 	private SiteService siteService;
@@ -43,7 +43,7 @@ public class AuthenticationFailureListener
 	public void onApplicationEvent(final AuthenticationFailureBadCredentialsEvent event) {
 		final HttpServletRequest request = getRequest();
 		if (request == null) {
-			log.warn("Can't get http request object");
+			LOG.warn("Can't get http request object");
 			return;
 		}
 

src/main/java/ru/mystamps/web/support/spring/security/CustomUserDetailsService.java

@@ -43,7 +43,7 @@
  */
 public class CustomUserDetailsService implements UserDetailsService {
 
-	private final Logger log = LoggerFactory.getLogger(CustomUserDetailsService.class);
+	private static final Logger LOG = LoggerFactory.getLogger(CustomUserDetailsService.class);
 
 	@Inject
 	private UserService userService;
@@ -53,15 +53,15 @@ public class CustomUserDetailsService implements UserDetailsService {
 	public UserDetails loadUserByUsername(final String login) {
 		checkArgument(login != null, "Login should be non null");
 
-		log.debug("Find user by login '{}'", login);
+		LOG.debug("Find user by login '{}'", login);
 
 		final User user = userService.findByLogin(login);
 		if (user == null) {
-			log.debug("User '{}' not found", login);
+			LOG.debug("User '{}' not found", login);
 			throw new UsernameNotFoundException("User not found");
 		}
 
-		log.debug("User '{}' found", login);
+		LOG.debug("User '{}' found", login);
 
 		return new CustomUserDetails(user, getAuthorities());
 	}