WhenAdminAddSeries.catalogPricesShouldRejectInvalidValues: port to Robot Framework.

Addressed to #530

No functional changes.

Author: php-coder

src/test/java/ru/mystamps/web/tests/cases/WhenAdminAddSeries.java

@@ -29,14 +29,12 @@
 import org.testng.annotations.AfterClass;
 import org.testng.annotations.BeforeClass;
 import org.testng.annotations.BeforeMethod;
-import org.testng.annotations.DataProvider;
 import org.testng.annotations.Test;
 
 import ru.mystamps.web.tests.page.AbstractPage;
 import ru.mystamps.web.tests.page.AddSeriesPage;
 import ru.mystamps.web.tests.page.InfoSeriesPage;
 
-import static ru.mystamps.web.tests.TranslationUtils.tr;
 import static ru.mystamps.web.tests.fest.PageWithFormAssert.assertThat;
 
 import static org.fest.assertions.api.Assertions.assertThat;
@@ -118,23 +116,6 @@ public void shouldHaveStandardStructure() {
 		checkStandardStructure();
 	}
 
-	@Test(groups = "invalid", dependsOnGroups = "std", dataProvider = "invalidCatalogPrices")
-	public void catalogPricesShouldRejectInvalidValues(String price, String msg) {
-		page.showCatalogNumbers();
-		
-		page.fillMichelPrice(price);
-		page.fillScottPrice(price);
-		page.fillYvertPrice(price);
-		page.fillGibbonsPrice(price);
-		
-		page.submit();
-		
-		assertThat(page).field("michelPrice").hasError(msg);
-		assertThat(page).field("scottPrice").hasError(msg);
-		assertThat(page).field("yvertPrice").hasError(msg);
-		assertThat(page).field("gibbonsPrice").hasError(msg);
-	}
-	
 	@Test(groups = "misc", dependsOnGroups = "std")
 	public void issueYearFieldShouldHaveOptionsForRangeFrom1840ToCurrentYear() {
 		page.showDateOfRelease();
@@ -169,7 +150,7 @@ public void commentShouldBeStripedFromLeadingAndTrailingSpaces() {
 		assertThat(page).field("comment").hasValue("example comment");
 	}
 
-	@Test(groups = "logic", dependsOnGroups = { "std", "invalid", "misc" })
+	@Test(groups = "logic", dependsOnGroups = { "std", "misc" })
 	public void shouldIgnoreDuplicatedCatalogNumbers() {
 		page.fillCategory(validCategoryName);
 		page.fillQuantity("2");
@@ -191,7 +172,7 @@ public void shouldIgnoreDuplicatedCatalogNumbers() {
 		assertThat(nextPage.getGibbonsCatalogInfo()).isEqualTo("#134, 135");
 	}
 
-	@Test(groups = "logic", dependsOnGroups = { "std", "invalid", "misc" })
+	@Test(groups = "logic", dependsOnGroups = { "std", "misc" })
 	public void shouldAllowExistingCatalogNumbers() {
 		page.fillCategory(validCategoryName);
 		page.fillQuantity("2");
@@ -212,15 +193,4 @@ public void shouldAllowExistingCatalogNumbers() {
 		assertThat(nextPage.getGibbonsCatalogInfo()).isEqualTo("#" + existingGibbonsNumber);
 	}
 
-	@DataProvider(name = "invalidCatalogPrices")
-	public Object[][] getInvalidCatalogPrices() {
-		String expectedErrorMessage = tr("ru.mystamps.web.validation.jsr303.Price.message");
-		
-		return new Object[][] {
-			{"0", expectedErrorMessage},
-			{"-1", expectedErrorMessage},
-			{"NaN", expectedErrorMessage}
-		};
-	}
-	
 }

src/test/robotframework/series/creation/validation.robot

@@ -43,6 +43,13 @@ Catalog numbers should reject invalid values
 	1,09
 	10000
 
+Catalog price should reject invalid values
+	[Documentation]  Verify that fields with catalog price reject invalid values
+	[Template]       Invalid Catalog Price Should Be Rejected
+	0
+	-1
+	NaN
+
 Create series with too long comment
 	[Documentation]                Verify validation of too long comment
 	${letter}=                     Set Variable  x
@@ -90,3 +97,17 @@ Invalid Catalog Numbers Should Be Rejected
 	Element Text Should Be  id=scottNumbers.errors  Value must be comma delimited numbers
 	Element Text Should Be  id=yvertNumbers.errors  Value must be comma delimited numbers
 	Element Text Should Be  id=gibbonsNumbers.errors  Value must be comma delimited numbers
+
+Invalid Catalog Price Should Be Rejected
+	[Documentation]         Test that specifying catalog price cause an error
+	[Arguments]             ${catalogPrice}
+	Click Element           id=add-catalog-numbers-link
+	Input Text              id=michelPrice  ${catalogPrice}
+	Input Text              id=scottPrice  ${catalogPrice}
+	Input Text              id=yvertPrice  ${catalogPrice}
+	Input Text              id=gibbonsPrice  ${catalogPrice}
+	Submit Form             id=add-series-form
+	Element Text Should Be  id=michelPrice.errors  Invalid value
+	Element Text Should Be  id=scottPrice.errors  Invalid value
+	Element Text Should Be  id=yvertPrice.errors  Invalid value
+	Element Text Should Be  id=gibbonsPrice.errors  Invalid value