Made JSONStream a bit more PSR-7 stream compliant

Author: WyriHaximus

src/JsonStream.php

@@ -3,7 +3,7 @@
 namespace ApiClients\Middleware\Json;
 
 use Psr\Http\Message\StreamInterface;
-use RuntimeException;
+use RingCentral\Psr7\BufferStream;
 
 class JsonStream implements StreamInterface
 {
@@ -12,9 +12,17 @@ class JsonStream implements StreamInterface
      */
     private $json = [];
 
+    /**
+     * @var StreamInterface
+     */
+    private $bufferStream;
+
     public function __construct(array $json)
     {
         $this->json = $json;
+        $jsonString = json_encode($json);
+        $this->bufferStream = new BufferStream(strlen($jsonString));
+        $this->bufferStream->write($jsonString);
     }
 
     /**
@@ -32,7 +40,7 @@ public function __toString()
 
     public function getContents()
     {
-        return '';
+        return $this->bufferStream->getContents();
     }
 
     public function close()
@@ -45,61 +53,62 @@ public function detach()
 
     public function getSize()
     {
-        return count($this->json);
+        return $this->bufferStream->getSize();
     }
 
     public function isReadable()
     {
-        return true;
+        return $this->bufferStream->isReadable();
     }
 
     public function isWritable()
     {
-        return false;
+        return $this->bufferStream->isWritable();
     }
 
     public function isSeekable()
     {
-        return false;
+        return $this->bufferStream->isSeekable();
     }
 
     public function rewind()
     {
+        return $this->bufferStream->rewind();
     }
 
     public function seek($offset, $whence = SEEK_SET)
     {
-        throw new RuntimeException('Cannot seek a BufferStream');
+        return $this->bufferStream->seek($offset, $whence);
     }
 
     public function eof()
     {
-        return true;
+        return $this->bufferStream->eof();
     }
 
     public function tell()
     {
-        throw new RuntimeException('Cannot determine the position of a BufferStream');
+        return $this->bufferStream->tell();
     }
 
     /**
      * Reads data from the buffer.
      */
     public function read($length)
     {
-        throw new RuntimeException('Cannot read from a JsonStream');
+        return $this->bufferStream->read($length);
     }
 
     /**
      * Writes data to the buffer.
      */
     public function write($string)
     {
-        throw new RuntimeException('Cannot write to a JsonStream');
+        return $this->bufferStream->write($string);
     }
 
     public function getMetadata($key = null)
     {
-        return [];
+        return $this->bufferStream->getMetadata($key);
     }
 }

tests/JsonStreamTest.php

@@ -5,53 +5,14 @@
 
 use ApiClients\Middleware\Json\JsonStream;
 use ApiClients\Tools\TestUtilities\TestCase;
-use RuntimeException;
 
 class JsonStreamTest extends TestCase
 {
     public function testBasics()
     {
         $stream = new JsonStream([]);
         self::assertSame([], $stream->getJson());
-        self::assertSame('', (string)$stream);
-        self::assertSame('', $stream->getContents());
-        self::assertSame(0, $stream->getSize());
-        self::assertSame(true, $stream->isReadable());
-        self::assertSame(false, $stream->isWritable());
-        self::assertSame(false, $stream->isSeekable());
-        self::assertSame(true, $stream->eof());
-        self::assertSame([], $stream->getMetadata());
-
-        $stream->close();
-        $stream->detach();
-        $stream->rewind();
-    }
-
-    public function testSeek()
-    {
-        $this->expectException(RuntimeException::class);
-        $this->expectExceptionMessage('Cannot seek a BufferStream');
-        (new JsonStream([]))->seek(0);
-    }
-
-    public function testTell()
-    {
-        $this->expectException(RuntimeException::class);
-        $this->expectExceptionMessage('Cannot determine the position of a BufferStream');
-        (new JsonStream([]))->tell();
-    }
-
-    public function testRead()
-    {
-        $this->expectException(RuntimeException::class);
-        $this->expectExceptionMessage('Cannot read from a JsonStream');
-        (new JsonStream([]))->read(0);
-    }
-
-    public function testWrite()
-    {
-        $this->expectException(RuntimeException::class);
-        $this->expectExceptionMessage('Cannot write to a JsonStream');
-        (new JsonStream([]))->write('');
+        self::assertSame(2, $stream->getSize());
+        self::assertSame('[]', $stream->getContents());
     }
 }