Skip to content

Updated IDENTIFIER to allow more than 4 underscores. Also additional test code. #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 18, 2019

Conversation

davidofferman
Copy link
Contributor

@davidofferman davidofferman commented Jul 18, 2019

Hello!

  • Type: bug fix | code quality

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:

  • Fixed code to allow underscore only IDENTIFIER to have more than 4 underscores.
  • Removed parser.c and scanner.c from repo and added to .gitignore since they are auto generated.
  • Test code for assignment operators -= and *=.
  • Test code for bitwise operators.
  • Test code for constant variable type.

Thanks

@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #75 into development will increase coverage by 1.04%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development      #75      +/-   ##
===============================================
+ Coverage        38.59%   39.63%   +1.04%     
===============================================
  Files                5        5              
  Lines             4444     2712    -1732     
===============================================
- Hits              1715     1075     -640     
+ Misses            2729     1637    -1092
Impacted Files Coverage Δ
parser/scanner.re 56.83% <100%> (+4.4%) ⬆️
parser/base.c 55.49% <0%> (ø)
parser/parser.h 49.4% <0%> (+0.44%) ⬆️
parser/zephir.lemon 20.28% <0%> (+1.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75a3176...bdd833a. Read the comment docs.

@sergeyklay sergeyklay merged commit ca800dc into zephir-lang:development Jul 18, 2019
@sergeyklay
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants