Merge pull request #728 from ParsePlatform/nlutsenko.initializers

Improve designated initializer flow for all classes with custom initializers.

Author: nlutsenko

Parse/Internal/Analytics/Controller/PFAnalyticsController.h

@@ -27,6 +27,8 @@ NS_ASSUME_NONNULL_BEGIN
 ///--------------------------------------
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
+
 - (instancetype)initWithDataSource:(id<PFEventuallyQueueProvider>)dataSource NS_DESIGNATED_INITIALIZER;
 
 + (instancetype)controllerWithDataSource:(id<PFEventuallyQueueProvider>)dataSource;

Parse/Internal/Analytics/Controller/PFAnalyticsController.m

@@ -27,10 +27,6 @@ @implementation PFAnalyticsController
 #pragma mark - Init
 ///--------------------------------------
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 - (instancetype)initWithDataSource:(id<PFEventuallyQueueProvider>)dataSource {
     self = [super init];
     if (!self) return nil;

Parse/Internal/CloudCode/PFCloudCodeController.h

@@ -23,6 +23,8 @@
 ///--------------------------------------
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
+
 - (instancetype)initWithDataSource:(id<PFCommandRunnerProvider>)dataSource NS_DESIGNATED_INITIALIZER;
 
 + (instancetype)controllerWithDataSource:(id<PFCommandRunnerProvider>)dataSource;

Parse/Internal/CloudCode/PFCloudCodeController.m

@@ -22,11 +22,7 @@ @implementation PFCloudCodeController
 
 ///--------------------------------------
 #pragma mark - Init
-///--------------------------------------
-
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
+///--------------------------------------s
 
 - (instancetype)initWithDataSource:(id<PFCommandRunnerProvider>)dataSource {
     self = [super init];

Parse/Internal/Commands/CommandRunner/URLRequestConstructor/PFCommandURLRequestConstructor.h

@@ -26,6 +26,8 @@
 ///--------------------------------------
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
+
 + (instancetype)constructorWithDataSource:(id<PFInstallationIdentifierStoreProvider>)dataSource serverURL:(NSURL *)serverURL;
 
 ///--------------------------------------

Parse/Internal/Commands/CommandRunner/URLRequestConstructor/PFCommandURLRequestConstructor.m

@@ -27,10 +27,6 @@ @implementation PFCommandURLRequestConstructor
 #pragma mark - Init
 ///--------------------------------------
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 - (instancetype)initWithDataSource:(id<PFInstallationIdentifierStoreProvider>)dataSource serverURL:(NSURL *)serverURL {
     self = [super init];
     if (!self) return nil;

Parse/Internal/Commands/CommandRunner/URLSession/PFURLSessionCommandRunner.h

@@ -16,6 +16,7 @@ NS_ASSUME_NONNULL_BEGIN
 @interface PFURLSessionCommandRunner : NSObject <PFCommandRunning>
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
 
 + (instancetype)commandRunnerWithDataSource:(id<PFInstallationIdentifierStoreProvider>)dataSource
                               retryAttempts:(NSUInteger)retryAttempts

Parse/Internal/Commands/CommandRunner/URLSession/PFURLSessionCommandRunner.m

@@ -48,10 +48,6 @@ @implementation PFURLSessionCommandRunner
 #pragma mark - Init
 ///--------------------------------------
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 - (instancetype)initWithDataSource:(id<PFInstallationIdentifierStoreProvider>)dataSource
                      applicationId:(NSString *)applicationId
                          clientKey:(NSString *)clientKey

Parse/Internal/Commands/CommandRunner/URLSession/Session/PFURLSession.h

@@ -37,6 +37,8 @@ NS_ASSUME_NONNULL_BEGIN
 ///--------------------------------------
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
+
 - (instancetype)initWithConfiguration:(NSURLSessionConfiguration *)configuration
                              delegate:(id<PFURLSessionDelegate>)delegate NS_DESIGNATED_INITIALIZER;
 

Parse/Internal/Commands/CommandRunner/URLSession/Session/PFURLSession.m

@@ -37,10 +37,6 @@ @implementation PFURLSession
 #pragma mark - Init
 ///--------------------------------------
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 - (instancetype)initWithConfiguration:(NSURLSessionConfiguration *)configuration
                              delegate:(id<PFURLSessionDelegate>)delegate {
     // NOTE: cast to id suppresses warning about designated initializer.

Parse/Internal/Commands/CommandRunner/URLSession/Session/TaskDelegate/PFURLSessionDataTaskDelegate.h

@@ -26,6 +26,8 @@ NS_ASSUME_NONNULL_BEGIN
 @property (nullable, nonatomic, copy, readonly) NSString *responseString;
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
+
 - (instancetype)initForDataTask:(NSURLSessionDataTask *)dataTask
           withCancellationToken:(nullable BFCancellationToken *)cancellationToken NS_DESIGNATED_INITIALIZER;
 

Parse/Internal/Commands/CommandRunner/URLSession/Session/TaskDelegate/PFURLSessionDataTaskDelegate.m

@@ -31,10 +31,6 @@ @implementation PFURLSessionDataTaskDelegate
 #pragma mark - Init
 ///--------------------------------------
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 - (instancetype)initForDataTask:(NSURLSessionDataTask *)dataTask
           withCancellationToken:(BFCancellationToken *)cancellationToken {
     self = [super init];

Parse/Internal/Config/Controller/PFConfigController.h

@@ -28,6 +28,8 @@
 ///--------------------------------------
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
+
 - (instancetype)initWithDataSource:(id<PFPersistenceControllerProvider, PFCommandRunnerProvider>)dataSource NS_DESIGNATED_INITIALIZER;
 
 ///--------------------------------------

Parse/Internal/Config/Controller/PFConfigController.m

@@ -34,10 +34,6 @@ @implementation PFConfigController
 #pragma mark - Init
 ///--------------------------------------
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 - (instancetype)initWithDataSource:(id<PFPersistenceControllerProvider, PFCommandRunnerProvider>)dataSource {
     self = [super init];
     if (!self) return nil;

Parse/Internal/Config/Controller/PFCurrentConfigController.h

@@ -25,6 +25,8 @@
 ///--------------------------------------
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
+
 - (instancetype)initWithDataSource:(id<PFPersistenceControllerProvider>)dataSource NS_DESIGNATED_INITIALIZER;
 
 + (instancetype)controllerWithDataSource:(id<PFPersistenceControllerProvider>)dataSource;

Parse/Internal/Config/Controller/PFCurrentConfigController.m

@@ -34,10 +34,6 @@ @implementation PFCurrentConfigController
 #pragma mark - Init
 ///--------------------------------------
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 - (instancetype)initWithDataSource:(id<PFPersistenceControllerProvider>)dataSource {
     self = [super init];
     if (!self) return nil;

Parse/Internal/File/Controller/PFFileController.h

@@ -32,6 +32,8 @@
 ///--------------------------------------
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
+
 - (instancetype)initWithDataSource:(id<PFCommandRunnerProvider, PFFileManagerProvider>)dataSource NS_DESIGNATED_INITIALIZER;
 
 + (instancetype)controllerWithDataSource:(id<PFCommandRunnerProvider, PFFileManagerProvider>)dataSource;

Parse/Internal/File/Controller/PFFileController.m

@@ -44,10 +44,6 @@ @implementation PFFileController
 #pragma mark - Init
 ///--------------------------------------
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 - (instancetype)initWithDataSource:(id<PFCommandRunnerProvider, PFFileManagerProvider>)dataSource {
     self = [super init];
     if (!self) return nil;

Parse/Internal/File/Controller/PFFileStagingController.h

@@ -28,6 +28,8 @@ NS_ASSUME_NONNULL_BEGIN
 ///--------------------------------------
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
+
 - (instancetype)initWithDataSource:(id<PFFileManagerProvider>)dataSource NS_DESIGNATED_INITIALIZER;
 
 + (instancetype)controllerWithDataSource:(id<PFFileManagerProvider>)dataSource;

Parse/Internal/File/Controller/PFFileStagingController.m

@@ -26,10 +26,6 @@ @implementation PFFileStagingController {
 #pragma mark - Init
 ///--------------------------------------
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 - (instancetype)initWithDataSource:(id<PFFileManagerProvider>)dataSource {
     self = [super init];
     if (!self) return nil;

Parse/Internal/Installation/InstallationIdentifierStore/PFInstallationIdentifierStore.h

@@ -24,6 +24,8 @@
 ///--------------------------------------
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
+
 - (instancetype)initWithDataSource:(id<PFPersistenceControllerProvider>)dataSource NS_DESIGNATED_INITIALIZER;
 
 ///--------------------------------------

Parse/Internal/Installation/InstallationIdentifierStore/PFInstallationIdentifierStore.m

@@ -37,10 +37,6 @@ @implementation PFInstallationIdentifierStore
 #pragma mark - Init
 ///--------------------------------------
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 - (instancetype)initWithDataSource:(id<PFPersistenceControllerProvider>)dataSource {
     self = [super init];
     if (!self) return nil;

Parse/Internal/KeyValueCache/PFKeyValueCache.h

@@ -20,6 +20,8 @@ NS_ASSUME_NONNULL_BEGIN
 ///--------------------------------------
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
+
 - (instancetype)initWithCacheDirectoryPath:(NSString *)path;
 
 ///--------------------------------------

Parse/Internal/KeyValueCache/PFKeyValueCache.m

@@ -32,10 +32,6 @@ @interface PFKeyValueCacheEntry ()
 
 @implementation PFKeyValueCacheEntry
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 - (instancetype)initWithValue:(NSString *)value {
     return [self initWithValue:value creationTime:[NSDate date]];
 }
@@ -73,10 +69,6 @@ @implementation PFKeyValueCache {
 #pragma mark - Init
 ///--------------------------------------
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 - (instancetype)initWithCacheDirectoryPath:(NSString *)path {
     return [self initWithCacheDirectoryURL:[NSURL fileURLWithPath:path]
                                fileManager:[NSFileManager defaultManager]

Parse/Internal/LocalDataStore/OfflineStore/PFOfflineStore.m

@@ -93,10 +93,6 @@ @implementation PFOfflineStore
 #pragma mark - Init
 ///--------------------------------------
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 - (instancetype)initWithFileManager:(PFFileManager *)fileManager options:(PFOfflineStoreOptions)options {
     self = [super init];
     if (!self) return nil;

Parse/Internal/LocalDataStore/SQLite/PFSQLiteDatabaseController.h

@@ -26,6 +26,8 @@ NS_ASSUME_NONNULL_BEGIN
 ///--------------------------------------
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
+
 - (instancetype)initWithFileManager:(PFFileManager *)fileManager NS_DESIGNATED_INITIALIZER;
 + (instancetype)controllerWithFileManager:(PFFileManager *)fileManager;
 

Parse/Internal/LocalDataStore/SQLite/PFSQLiteDatabaseController.m

@@ -25,10 +25,6 @@ @implementation PFSQLiteDatabaseController {
 #pragma mark - Init
 ///--------------------------------------
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 - (instancetype)initWithFileManager:(PFFileManager *)fileManager {
     self = [super init];
     if (!self) return nil;

Parse/Internal/MultiProcessLock/PFMultiProcessFileLock.h

@@ -20,6 +20,8 @@
 ///--------------------------------------
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
+
 - (instancetype)initForFileWithPath:(NSString *)path NS_DESIGNATED_INITIALIZER;
 + (instancetype)lockForFileWithPath:(NSString *)path;
 

Parse/Internal/MultiProcessLock/PFMultiProcessFileLock.m

@@ -30,10 +30,6 @@ @implementation PFMultiProcessFileLock
 #pragma mark - Init
 ///--------------------------------------
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 - (instancetype)initForFileWithPath:(NSString *)path {
     self = [super init];
     if (!self) return nil;

Parse/Internal/Object/BatchController/PFObjectBatchController.h

@@ -28,6 +28,8 @@ NS_ASSUME_NONNULL_BEGIN
 ///--------------------------------------
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
+
 - (instancetype)initWithDataSource:(id<PFCommandRunnerProvider>)dataSource NS_DESIGNATED_INITIALIZER;
 + (instancetype)controllerWithDataSource:(id<PFCommandRunnerProvider>)dataSource;
 

Parse/Internal/Object/BatchController/PFObjectBatchController.m

@@ -30,10 +30,6 @@ @implementation PFObjectBatchController
 #pragma mark - Init
 ///--------------------------------------
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 - (instancetype)initWithDataSource:(id<PFCommandRunnerProvider>)dataSource {
     self = [super init];
     if (!self) return nil;

Parse/Internal/Object/Controller/PFObjectController.h

@@ -26,6 +26,8 @@ NS_ASSUME_NONNULL_BEGIN
 ///--------------------------------------
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
+
 - (instancetype)initWithDataSource:(id<PFCommandRunnerProvider>)dataSource NS_DESIGNATED_INITIALIZER;
 + (instancetype)controllerWithDataSource:(id<PFCommandRunnerProvider>)dataSource;
 

Parse/Internal/Object/Controller/PFObjectController.m

@@ -27,10 +27,6 @@ @implementation PFObjectController
 #pragma mark - Init
 ///--------------------------------------
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 - (instancetype)initWithDataSource:(id<PFCommandRunnerProvider>)dataSource {
     self = [super init];
     if (!self) return nil;

Parse/Internal/Object/FilePersistence/PFObjectFilePersistenceController.h

@@ -26,6 +26,8 @@
 ///--------------------------------------
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
+
 - (instancetype)initWithDataSource:(id<PFPersistenceControllerProvider>)dataSource NS_DESIGNATED_INITIALIZER;
 + (instancetype)controllerWithDataSource:(id<PFPersistenceControllerProvider>)dataSource;
 

Parse/Internal/Object/FilePersistence/PFObjectFilePersistenceController.m

@@ -23,10 +23,6 @@ @implementation PFObjectFilePersistenceController
 #pragma mark - Init
 ///--------------------------------------
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 - (instancetype)initWithDataSource:(id<PFPersistenceControllerProvider>)dataSource {
     self = [super init];
     if (!self) return nil;

Parse/Internal/Object/LocalIdStore/PFObjectLocalIdStore.h

@@ -28,6 +28,8 @@
 ///--------------------------------------
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
+
 - (instancetype)initWithDataSource:(id<PFFileManagerProvider>)dataSource NS_DESIGNATED_INITIALIZER;
 + (instancetype)storeWithDataSource:(id<PFFileManagerProvider>)dataSource;
 

Parse/Internal/Object/LocalIdStore/PFObjectLocalIdStore.m

@@ -81,10 +81,6 @@ @interface PFObjectLocalIdStore () {
 
 @implementation PFObjectLocalIdStore
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 /**
  * Creates a new LocalIdManager with default options.
  */

Parse/Internal/Object/PinningStore/PFPinningObjectStore.h

@@ -28,6 +28,8 @@ NS_ASSUME_NONNULL_BEGIN
 ///--------------------------------------
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
+
 - (instancetype)initWithDataSource:(id<PFOfflineStoreProvider>)dataSource NS_DESIGNATED_INITIALIZER;
 + (instancetype)storeWithDataSource:(id<PFOfflineStoreProvider>)dataSource;