Skip to content

Commit f5f98e2

Browse files
author
wigginsp
committed
Release v1.0.22 - Fix CoreStore bug
1 parent 654a282 commit f5f98e2

File tree

2 files changed

+22
-32
lines changed

2 files changed

+22
-32
lines changed

lib/src/data/core_store_impl.dart

Lines changed: 22 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,20 @@
11
part of flutter_parse_sdk;
22

33
class CoreStoreImp implements CoreStore {
4-
54
CoreStoreImp._internal(this._store);
6-
75
static CoreStoreImp _instance;
8-
96
static Future<CoreStoreImp> getInstance(
107
{DatabaseFactory factory, String password = 'flutter_sdk'}) async {
11-
128
if (_instance == null) {
139
factory ??= databaseFactoryIo;
1410
final SembastCodec codec = getXXTeaSembastCodec(password: password);
1511
String dbDirectory = '';
16-
17-
if (Platform.isIOS || Platform.isAndroid) {
12+
if (Platform.isIOS || Platform.isAndroid)
1813
dbDirectory = (await getApplicationDocumentsDirectory()).path;
19-
final String dbPath = path.join('$dbDirectory/parse', 'parse.db');
20-
final Database db = await factory.openDatabase(dbPath, codec: codec);
21-
_instance = CoreStoreImp._internal(db);
22-
}
14+
final String dbPath = path.join('$dbDirectory+/parse', 'parse.db');
15+
final Database db = await factory.openDatabase(dbPath, codec: codec);
16+
_instance = CoreStoreImp._internal(db);
2317
}
24-
2518
return _instance;
2619
}
2720

@@ -38,67 +31,67 @@ class CoreStoreImp implements CoreStore {
3831
}
3932

4033
@override
41-
Future<String> get(String key) {
34+
Future<dynamic> get(String key) {
4235
return _store.get(key);
4336
}
4437

4538
@override
4639
Future<bool> getBool(String key) async {
47-
final bool storedValue = await _store.get(key);
48-
return storedValue;
40+
final bool storedItem = await _store.get(key);
41+
return storedItem;
4942
}
5043

5144
@override
5245
Future<double> getDouble(String key) async {
53-
final double storedValue = await _store.get(key);
54-
return storedValue;
46+
final double storedItem = await _store.get(key);
47+
return storedItem;
5548
}
5649

5750
@override
5851
Future<int> getInt(String key) async {
59-
final int storedValue = await _store.get(key);
60-
return storedValue;
52+
final int storedItem = await _store.get(key);
53+
return storedItem;
6154
}
6255

6356
@override
6457
Future<String> getString(String key) async {
65-
final String storedValue = await _store.get(key);
66-
return storedValue;
58+
final String storedItem = await _store.get(key);
59+
return storedItem;
6760
}
6861

6962
@override
7063
Future<List<String>> getStringList(String key) async {
71-
final List<String> storedValue = await _store.get(key);
72-
return storedValue;
64+
final List<String> storedItem = await _store.get(key);
65+
return storedItem;
7366
}
7467

7568
@override
76-
Future<dynamic> remove(String key) {
69+
Future<void> remove(String key) {
7770
return _store.delete(key);
7871
}
7972

8073
@override
81-
Future<dynamic> setBool(String key, bool value) {
74+
Future<void> setBool(String key, bool value) {
8275
return _store.put(value, key);
8376
}
8477

8578
@override
86-
Future<dynamic> setDouble(String key, double value) {
79+
Future<void> setDouble(String key, double value) {
8780
return _store.put(value, key);
8881
}
8982

9083
@override
91-
Future<dynamic> setInt(String key, int value) {
84+
Future<void> setInt(String key, int value) {
9285
return _store.put(value, key);
9386
}
9487

9588
@override
96-
Future<dynamic> setString(String key, String value) {
89+
Future<void> setString(String key, String value) {
9790
return _store.put(value, key);
9891
}
9992

10093
@override
101-
Future<dynamic> setStringList(String key, List<String> values) {
94+
Future<void> setStringList(String key, List<String> values) {
10295
return _store.put(values, key);
10396
}
104-
}
97+
}

lib/src/data/parse_core_data.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@ class ParseCoreData {
2626
CoreStore store}) {
2727
_instance = ParseCoreData._init(appId, serverUrl);
2828

29-
_instance.storage ??=
30-
store ?? CoreStoreImp.getInstance(password: masterKey);
31-
3229
_instance.storage ??=
3330
store ?? CoreStoreImp.getInstance(password: masterKey);
3431

0 commit comments

Comments
 (0)