Skip to content

Commit 67dc20f

Browse files
authored
update metric computations (#16)
1 parent da414f1 commit 67dc20f

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

analysis/metrics.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ def speedupk(df: pd.DataFrame, k: int, n: int) -> pd.DataFrame:
9898
(df["parallelism_model"] == "cuda") |
9999
(df["parallelism_model"] == "hip") |
100100
((df["parallelism_model"] == "kokkos") & (df["num_threads"] == 32)) |
101-
((df["parallelism_model"] == "omp") & (df["num_threads"] == 64)) |
101+
((df["parallelism_model"] == "omp") & (df["num_threads"] == 32)) |
102102
((df["parallelism_model"] == "mpi") & (df["num_procs"] == 512)) |
103103
((df["parallelism_model"] == "mpi+omp") & (df["num_procs"] == 4) & (df["num_threads"] == 64))]
104104
df = df.copy()
@@ -153,17 +153,17 @@ def efficiencyk(df: pd.DataFrame, k: int, n: int) -> pd.DataFrame:
153153
(df["parallelism_model"] == "cuda") |
154154
(df["parallelism_model"] == "hip") |
155155
((df["parallelism_model"] == "kokkos") & (df["num_threads"] == 32)) |
156-
((df["parallelism_model"] == "omp") & (df["num_threads"] == 64)) |
156+
((df["parallelism_model"] == "omp") & (df["num_threads"] == 32)) |
157157
((df["parallelism_model"] == "mpi") & (df["num_procs"] == 512)) |
158158
((df["parallelism_model"] == "mpi+omp") & (df["num_procs"] == 4) & (df["num_threads"] == 64))]
159159

160-
# set n_resources column to 1 for serial; 32 for kokkos; 64 for omp; 512 for mpi; 4*64 for mpi+omp;
160+
# set n_resources column to 1 for serial; 32 for kokkos; 32 for omp; 512 for mpi; 4*64 for mpi+omp;
161161
# set it to problem_size for cuda and hip
162162
df["n_resources"] = 1
163163
df.loc[df["parallelism_model"] == "cuda", "n_resources"] = df["problem_size"]
164164
df.loc[df["parallelism_model"] == "hip", "n_resources"] = df["problem_size"]
165165
df.loc[df["parallelism_model"] == "kokkos", "n_resources"] = 32
166-
df.loc[df["parallelism_model"] == "omp", "n_resources"] = 64
166+
df.loc[df["parallelism_model"] == "omp", "n_resources"] = 32
167167
df.loc[df["parallelism_model"] == "mpi", "n_resources"] = 512
168168
df.loc[df["parallelism_model"] == "mpi+omp", "n_resources"] = 4*64
169169

0 commit comments

Comments
 (0)