From 9812992bd329ed4caac6e878ee317213f4fb86b1 Mon Sep 17 00:00:00 2001 From: Charlie-XIAO Date: Wed, 30 Aug 2023 00:52:10 +0800 Subject: [PATCH 1/2] black will complain if there is no additional empty line --- scripts/no_bool_in_generic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/no_bool_in_generic.py b/scripts/no_bool_in_generic.py index c483d221a4266..15bc2247469c7 100644 --- a/scripts/no_bool_in_generic.py +++ b/scripts/no_bool_in_generic.py @@ -65,7 +65,7 @@ def replace_bool_with_bool_t(to_replace, content: str) -> str: + replaced_line[col_offset + 4 :] ) new_lines.append(replaced_line) - return "\n".join(new_lines) + return "\n".join(new_lines) + "\n" def check_for_bool_in_generic(content: str) -> tuple[bool, str]: From ee636fb5892e5b6d53b73b0d41fae5cc1cf83369 Mon Sep 17 00:00:00 2001 From: Charlie-XIAO Date: Wed, 30 Aug 2023 10:21:13 +0800 Subject: [PATCH 2/2] also update the test --- scripts/tests/test_no_bool_in_generic.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/tests/test_no_bool_in_generic.py b/scripts/tests/test_no_bool_in_generic.py index 0bc91c5d1cf1e..a57612548dcc5 100644 --- a/scripts/tests/test_no_bool_in_generic.py +++ b/scripts/tests/test_no_bool_in_generic.py @@ -1,7 +1,7 @@ from scripts.no_bool_in_generic import check_for_bool_in_generic -BAD_FILE = "def foo(a: bool) -> bool:\n return bool(0)" -GOOD_FILE = "def foo(a: bool_t) -> bool_t:\n return bool(0)" +BAD_FILE = "def foo(a: bool) -> bool:\n return bool(0)\n" +GOOD_FILE = "def foo(a: bool_t) -> bool_t:\n return bool(0)\n" def test_bad_file_with_replace():