From 902db676d119cdd140ac4421e705e38ce00dd873 Mon Sep 17 00:00:00 2001 From: color455nm Date: Thu, 24 Aug 2023 20:12:35 +0200 Subject: [PATCH 1/4] typing improvements on level and fill_value in Series.eq --- pandas/core/series.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/core/series.py b/pandas/core/series.py index 318f3fee2756b..90185e8608d81 100644 --- a/pandas/core/series.py +++ b/pandas/core/series.py @@ -5946,7 +5946,7 @@ def _flex_method(self, other, op, *, level=None, fill_value=None, axis: Axis = 0 return op(self, other) @Appender(ops.make_flex_doc("eq", "series")) - def eq(self, other, level=None, fill_value=None, axis: Axis = 0) -> Series: + def eq(self, other, level: Level | None = None, fill_value: float | None = None, axis: Axis = 0) -> Series: return self._flex_method( other, operator.eq, level=level, fill_value=fill_value, axis=axis ) From c92bae0779477174b581f8f282747a0dabe3209a Mon Sep 17 00:00:00 2001 From: color455nm Date: Thu, 24 Aug 2023 20:54:39 +0200 Subject: [PATCH 2/4] minor fix --- pandas/core/series.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/pandas/core/series.py b/pandas/core/series.py index 90185e8608d81..f29d98ae89699 100644 --- a/pandas/core/series.py +++ b/pandas/core/series.py @@ -5946,7 +5946,13 @@ def _flex_method(self, other, op, *, level=None, fill_value=None, axis: Axis = 0 return op(self, other) @Appender(ops.make_flex_doc("eq", "series")) - def eq(self, other, level: Level | None = None, fill_value: float | None = None, axis: Axis = 0) -> Series: + def eq( + self, + other, + level: Level | None = None, + fill_value: float | None = None, + axis: Axis = 0, + ) -> Series: return self._flex_method( other, operator.eq, level=level, fill_value=fill_value, axis=axis ) From 80476c4bf801dcbec968d1d26937c40374fca522 Mon Sep 17 00:00:00 2001 From: color455nm Date: Thu, 24 Aug 2023 22:08:13 +0200 Subject: [PATCH 3/4] Typing improvements freq in Series.to_timestamp --- pandas/core/series.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/core/series.py b/pandas/core/series.py index f29d98ae89699..5e36e6df33d5c 100644 --- a/pandas/core/series.py +++ b/pandas/core/series.py @@ -5630,7 +5630,7 @@ def dropna( def to_timestamp( self, - freq=None, + freq: str | None = None, how: Literal["s", "e", "start", "end"] = "start", copy: bool | None = None, ) -> Series: From e76e9612153ac191d43f50f5fc93007124d3a1ca Mon Sep 17 00:00:00 2001 From: color455nm Date: Fri, 25 Aug 2023 07:36:57 +0200 Subject: [PATCH 4/4] change typing from str to Frequency --- pandas/core/series.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pandas/core/series.py b/pandas/core/series.py index 5e36e6df33d5c..f1bc67810b788 100644 --- a/pandas/core/series.py +++ b/pandas/core/series.py @@ -166,6 +166,7 @@ DtypeBackend, DtypeObj, FilePath, + Frequency, IgnoreRaise, IndexKeyFunc, IndexLabel, @@ -5630,7 +5631,7 @@ def dropna( def to_timestamp( self, - freq: str | None = None, + freq: Frequency | None = None, how: Literal["s", "e", "start", "end"] = "start", copy: bool | None = None, ) -> Series: