From 08bfb621efe882fc83ce3322ec2d669e39873667 Mon Sep 17 00:00:00 2001 From: Jonas Haag Date: Wed, 22 Mar 2023 08:18:41 +0200 Subject: [PATCH 1/2] Add fillna_method 'pad' extension array tests --- pandas/tests/extension/base/missing.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/tests/extension/base/missing.py b/pandas/tests/extension/base/missing.py index cab81f864d8d8..2523cbf2d6f78 100644 --- a/pandas/tests/extension/base/missing.py +++ b/pandas/tests/extension/base/missing.py @@ -117,7 +117,7 @@ def test_fillna_series(self, data_missing): def test_fillna_series_method(self, data_missing, fillna_method): fill_value = data_missing[1] - if fillna_method == "ffill": + if fillna_method in {"pad", "ffill"}: data_missing = data_missing[::-1] result = pd.Series(data_missing).fillna(method=fillna_method) From faf1a045aaaf082f10a4f50875ec5a29c316f23b Mon Sep 17 00:00:00 2001 From: Jonas Haag Date: Wed, 22 Mar 2023 08:20:07 +0200 Subject: [PATCH 2/2] Add fillna_method 'pad' extension array tests --- pandas/tests/extension/conftest.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pandas/tests/extension/conftest.py b/pandas/tests/extension/conftest.py index 0d14128e3bebf..c7d719d996720 100644 --- a/pandas/tests/extension/conftest.py +++ b/pandas/tests/extension/conftest.py @@ -169,10 +169,10 @@ def use_numpy(request): return request.param -@pytest.fixture(params=["ffill", "bfill"]) +@pytest.fixture(params=["bfill", "pad", "ffill"]) def fillna_method(request): """ - Parametrized fixture giving method parameters 'ffill' and 'bfill' for + Parametrized fixture giving method parameters 'bfill', 'pad', and 'ffill' for Series.fillna(method=) testing. """ return request.param