From 305c674189889e7c88105c8b141847c1db81d583 Mon Sep 17 00:00:00 2001 From: luke <2736230899@qq.com> Date: Wed, 28 Dec 2022 17:28:06 +0800 Subject: [PATCH 1/3] add test_mask_return_dtype --- pandas/tests/frame/indexing/test_mask.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/pandas/tests/frame/indexing/test_mask.py b/pandas/tests/frame/indexing/test_mask.py index e8a49ab868425..a8c1c03864246 100644 --- a/pandas/tests/frame/indexing/test_mask.py +++ b/pandas/tests/frame/indexing/test_mask.py @@ -7,6 +7,7 @@ from pandas import ( NA, DataFrame, + Float64Dtype, Series, StringDtype, Timedelta, @@ -130,3 +131,12 @@ def test_mask_where_dtype_timedelta(): [np.nan, np.nan, np.nan, Timedelta("3 day"), Timedelta("4 day")] ) tm.assert_frame_equal(df.where(df > Timedelta(2, unit="d")), expected) + + +def test_mask_return_dtype(): + # GH#50488 + ser = Series([0.0, 1.0, 2.0, 3.0], dtype=Float64Dtype) + cond = ~ser.isna() + other = Series([True, False, True, False]) + excepted = Series([1.0, 0.0, 1.0, 0.0], dtype=ser.dtype) + tm.assert_series_equal(ser.mask(cond, other), excepted) From cc2487e6484a5df9e615d2a722f11922d0b64542 Mon Sep 17 00:00:00 2001 From: luke <2736230899@qq.com> Date: Wed, 28 Dec 2022 21:00:32 +0800 Subject: [PATCH 2/3] eaiser to read --- pandas/tests/frame/indexing/test_mask.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pandas/tests/frame/indexing/test_mask.py b/pandas/tests/frame/indexing/test_mask.py index a8c1c03864246..da982ed963800 100644 --- a/pandas/tests/frame/indexing/test_mask.py +++ b/pandas/tests/frame/indexing/test_mask.py @@ -139,4 +139,5 @@ def test_mask_return_dtype(): cond = ~ser.isna() other = Series([True, False, True, False]) excepted = Series([1.0, 0.0, 1.0, 0.0], dtype=ser.dtype) - tm.assert_series_equal(ser.mask(cond, other), excepted) + result = ser.mask(cond, other) + tm.assert_series_equal(result, excepted) From 38628322c0e3fb53296ed40de02a2c9e7eb2dc8c Mon Sep 17 00:00:00 2001 From: luke396 <77875500+luke396@users.noreply.github.com> Date: Wed, 4 Jan 2023 12:42:57 +0800 Subject: [PATCH 3/3] Update pandas/tests/frame/indexing/test_mask.py Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> --- pandas/tests/frame/indexing/test_mask.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/tests/frame/indexing/test_mask.py b/pandas/tests/frame/indexing/test_mask.py index da982ed963800..23458b096a140 100644 --- a/pandas/tests/frame/indexing/test_mask.py +++ b/pandas/tests/frame/indexing/test_mask.py @@ -135,7 +135,7 @@ def test_mask_where_dtype_timedelta(): def test_mask_return_dtype(): # GH#50488 - ser = Series([0.0, 1.0, 2.0, 3.0], dtype=Float64Dtype) + ser = Series([0.0, 1.0, 2.0, 3.0], dtype=Float64Dtype()) cond = ~ser.isna() other = Series([True, False, True, False]) excepted = Series([1.0, 0.0, 1.0, 0.0], dtype=ser.dtype)